pam_wrapper.git
5 months agopwrap: Fix PAM_WRAPPER_DISABLE_DEEPBIND environment variable master
Andreas Schneider [Fri, 10 Nov 2023 14:38:37 +0000 (15:38 +0100)]
pwrap: Fix PAM_WRAPPER_DISABLE_DEEPBIND environment variable

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
5 months agotests: Define PATH_MAX for Hurd.
Simon Josefsson [Tue, 22 Aug 2023 06:53:30 +0000 (08:53 +0200)]
tests: Define PATH_MAX for Hurd.

Signed-off-by: Simon Josefsson <simon@josefsson.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
5 months agodoc/pam_matrix.8: Fix typo 'allows to'.
Simon Josefsson [Fri, 18 Aug 2023 09:25:54 +0000 (11:25 +0200)]
doc/pam_matrix.8: Fix typo 'allows to'.

Signed-off-by: Simon Josefsson <simon@josefsson.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
5 months agodie quickly upon mkdir failure
Jan Kundrát [Mon, 6 Nov 2023 17:34:58 +0000 (18:34 +0100)]
die quickly upon mkdir failure

We just had this failure in our CI system that's currently running just
three PAM-wrapped tests in parallel. Since this is a classic TOCTOU race
(albeit in a test code, and therefore with little to no security
implications), the `mkdir` can fail, and when that happens it's much
better to just die quickly rather than continuing as if nothing
happened.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
8 months agoBump version to 1.1.5 pam_wrapper-1.1.5
Andreas Schneider [Mon, 17 Jul 2023 12:50:14 +0000 (14:50 +0200)]
Bump version to 1.1.5

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
9 months agocmake: Remove -Werror=declaration-after-statement
Andreas Schneider [Mon, 10 Jul 2023 09:32:23 +0000 (11:32 +0200)]
cmake: Remove -Werror=declaration-after-statement

This is not compatible with Python 3.12

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
14 months agocmake: Fix cmocka >= 1.1.6 find_package() in CONFIG mode
Andreas Schneider [Fri, 17 Feb 2023 16:51:27 +0000 (17:51 +0100)]
cmake: Fix cmocka >= 1.1.6 find_package() in CONFIG mode

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
14 months agocmake: Drop FindCMocka.cmake Module
Andreas Schneider [Fri, 17 Feb 2023 17:08:45 +0000 (18:08 +0100)]
cmake: Drop FindCMocka.cmake Module

We should use config mode.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
20 months agoDrop support for Python 2
Andreas Schneider [Tue, 2 Aug 2022 07:21:55 +0000 (09:21 +0200)]
Drop support for Python 2

Python 2 is already EOL!

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agogitlab-ci: Introduce test stages
Andreas Schneider [Tue, 2 Aug 2022 09:45:05 +0000 (11:45 +0200)]
gitlab-ci: Introduce test stages

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agogitlab-ci: Change the obj-dir so it doesn't create problems
Andreas Schneider [Tue, 2 Aug 2022 09:55:02 +0000 (11:55 +0200)]
gitlab-ci: Change the obj-dir so it doesn't create problems

The artifacts seem to be downloaded in the analysis stage if something
fails in the test stage. This should fix it for now.

Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agogitlab-ci: Fix indentation found by yamllint
Andreas Schneider [Tue, 2 Aug 2022 09:40:42 +0000 (11:40 +0200)]
gitlab-ci: Fix indentation found by yamllint

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agoBump version to 1.1.4 pam_wrapper-1.1.4
Andreas Schneider [Fri, 25 Jun 2021 08:12:07 +0000 (10:12 +0200)]
Bump version to 1.1.4

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agogitlab-ci: Allow freebsd to fail
Andreas Schneider [Tue, 5 Oct 2021 07:31:12 +0000 (09:31 +0200)]
gitlab-ci: Allow freebsd to fail

Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agotests: Allow to filter tests
Andreas Schneider [Fri, 25 Jun 2021 11:45:31 +0000 (13:45 +0200)]
tests: Allow to filter tests

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agocmake: Check for -Wno-bad-function-cast
Andreas Schneider [Fri, 25 Jun 2021 08:52:14 +0000 (10:52 +0200)]
cmake: Check for -Wno-bad-function-cast

Fixes the build on freebsd.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agocmake: Remove configure check for pam_modutil_search_key
Andreas Schneider [Fri, 23 Oct 2020 16:37:57 +0000 (18:37 +0200)]
cmake: Remove configure check for pam_modutil_search_key

This was just temporary for openSUSE Tumbleweed.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
2 years agoRevert "pwrap: Add back pso_copy for openSUSE Tumbleweed"
Andreas Schneider [Fri, 23 Oct 2020 16:37:08 +0000 (18:37 +0200)]
Revert "pwrap: Add back pso_copy for openSUSE Tumbleweed"

Tumbleweed has pam 1.4.0 now!

This reverts commit 97fdcec92ee34cf061222e3d12c2624ec7ab4ff7.

Reviewed-by: Samuel Cabrero <scabrero@samba.org>
2 years agolibpamtest: Fix missing pam_handle argument in run_pamtest_conv macro
Samuel Cabrero [Fri, 25 Jun 2021 08:06:09 +0000 (10:06 +0200)]
libpamtest: Fix missing pam_handle argument in run_pamtest_conv macro

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agoAccept whole range of supported pids
Jakub Jelen [Thu, 24 Jun 2021 08:24:31 +0000 (10:24 +0200)]
Accept whole range of supported pids

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agocmake: Silence warning with gcc version >= 8
Samuel Cabrero [Mon, 21 Jun 2021 10:46:20 +0000 (12:46 +0200)]
cmake: Silence warning with gcc version >= 8

src/python/pypamtest.c:1149:17: warning[-Wcast-function-type]: cast between
incompatible function types from ‘PyObject * (*)(PyObject *, PyObject *,
PyObject *)’ {aka ‘struct _object * (*)(struct _object *, struct _object *,
struct _object *)’} to ‘PyObject * (*)(PyObject *, PyObject *)’
{aka ‘struct _object * (*)(struct _object *, struct _object *)’}

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agopython: Export pam_setcred flags, to be used in python testcase objects
Samuel Cabrero [Fri, 18 Jun 2021 13:38:31 +0000 (15:38 +0200)]
python: Export pam_setcred flags, to be used in python testcase objects

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibpamtest: Add a new keyword parameter to reuse the PAM handle
Samuel Cabrero [Fri, 18 Jun 2021 08:36:17 +0000 (10:36 +0200)]
libpamtest: Add a new keyword parameter to reuse the PAM handle

Add a new keyword parameter to pass and reuse a PAM handle obtained by a
previous run having a test object of type PAMTEST_KEEPHANDLE.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agopython: Store the pam handle in the python test object
Samuel Cabrero [Fri, 18 Jun 2021 07:21:12 +0000 (09:21 +0200)]
python: Store the pam handle in the python test object

There was no way to get the PAM handler from a PAMTEST_KEEPHANDLE test
object.

The PAM handle is stored in the pam_handle member of the test object.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agopython: Store the pam env in the python test object
Samuel Cabrero [Fri, 18 Jun 2021 07:19:25 +0000 (09:19 +0200)]
python: Store the pam env in the python test object

There was no way to retrieve the PAM environment from a
PAMTEST_GETENVLIST test object.

The PAM environment is stored as a dictionary in the pam_env member of
the test object.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agotests: Correctly implement free_vlist()
Andreas Schneider [Mon, 19 Apr 2021 14:12:30 +0000 (16:12 +0200)]
tests: Correctly implement free_vlist()

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 years agolibpamtest: fix comments for pamtest_conv_data
Valentin Vidic [Sun, 7 Feb 2021 20:29:01 +0000 (21:29 +0100)]
libpamtest: fix comments for pamtest_conv_data

Comment descriptions were reversed for out_err and out_info.

Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agolibpamtest: include stddef.h in libpamtest.h
Valentin Vidic [Sun, 7 Feb 2021 20:25:36 +0000 (21:25 +0100)]
libpamtest: include stddef.h in libpamtest.h

If libpamtest.h is the first include build fails with:

  /usr/include/libpamtest.h:265:11: error: unknown type name ‘size_t’

Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agopam_wrapper.c: fall back to pragma init/fini for constructor/destructor if possible
Björn Jacke [Fri, 30 Oct 2020 14:52:40 +0000 (15:52 +0100)]
pam_wrapper.c: fall back to pragma init/fini for constructor/destructor if possible

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoconfigure: check for pragma init/fini for constructors/destructors
Björn Jacke [Fri, 30 Oct 2020 14:51:38 +0000 (15:51 +0100)]
configure: check for pragma init/fini for constructors/destructors

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoBump version to 1.1.3 pam_wrapper-1.1.3
Andreas Schneider [Thu, 26 Mar 2020 08:17:40 +0000 (09:17 +0100)]
Bump version to 1.1.3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
4 years agocmake: Fix paths in pkgconfig and cmake config files
Andreas Schneider [Wed, 25 Mar 2020 12:11:00 +0000 (13:11 +0100)]
cmake: Fix paths in pkgconfig and cmake config files

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
4 years agoBump version to 1.1.2 pam_wrapper-1.1.2
Andreas Schneider [Tue, 24 Mar 2020 13:30:35 +0000 (14:30 +0100)]
Bump version to 1.1.2

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
4 years agodoc: Fix manpage installation
Andreas Schneider [Tue, 24 Mar 2020 13:29:06 +0000 (14:29 +0100)]
doc: Fix manpage installation

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
4 years agoBump version to 1.1.1 pam_wrapper-1.1.1
Andreas Schneider [Tue, 24 Mar 2020 07:52:19 +0000 (08:52 +0100)]
Bump version to 1.1.1

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agogitlab-ci: Work around a Python 3.8 bug
Andreas Schneider [Tue, 24 Mar 2020 07:08:50 +0000 (08:08 +0100)]
gitlab-ci: Work around a Python 3.8 bug

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agogitlab-ci: Add ubuntu target
Andreas Schneider [Mon, 23 Mar 2020 17:49:27 +0000 (18:49 +0100)]
gitlab-ci: Add ubuntu target

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Add back pso_copy for openSUSE Tumbleweed
Andreas Schneider [Tue, 24 Mar 2020 06:32:06 +0000 (07:32 +0100)]
pwrap: Add back pso_copy for openSUSE Tumbleweed

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Check for pam_modutil_search_key
Andreas Schneider [Tue, 24 Mar 2020 06:22:37 +0000 (07:22 +0100)]
cmake: Check for pam_modutil_search_key

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Use PSO_COPY_READ_SIZE in pso_copy()
Andreas Schneider [Tue, 24 Mar 2020 10:19:36 +0000 (11:19 +0100)]
pwrap: Use PSO_COPY_READ_SIZE in pso_copy()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agoRevert "pwrap: Fix pso_copy to work with libpam.so.0.84.2"
Andreas Schneider [Tue, 24 Mar 2020 06:05:28 +0000 (07:05 +0100)]
Revert "pwrap: Fix pso_copy to work with libpam.so.0.84.2"

This reverts commit 047e9fb616d21e202add9f16347cea2084444104.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Create two pwrap_init() functions
Andreas Schneider [Mon, 23 Mar 2020 16:44:22 +0000 (17:44 +0100)]
pwrap: Create two pwrap_init() functions

One for pam_start() and one for pam_start_confdir() support.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Log the return code of pam_start()
Andreas Schneider [Mon, 23 Mar 2020 16:47:16 +0000 (17:47 +0100)]
pwrap: Log the return code of pam_start()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Improve debug message in p_rmdirs_at()
Andreas Schneider [Mon, 23 Mar 2020 16:39:57 +0000 (17:39 +0100)]
pwrap: Improve debug message in p_rmdirs_at()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Initialize pointers with NULL in p_rmdirs_at()
Andreas Schneider [Mon, 23 Mar 2020 16:34:37 +0000 (17:34 +0100)]
pwrap: Initialize pointers with NULL in p_rmdirs_at()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotests: Define PAM_AUTH_ERROR in init function
Andreas Schneider [Tue, 24 Mar 2020 07:37:24 +0000 (08:37 +0100)]
tests: Define PAM_AUTH_ERROR in init function

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotests: Workaround an off-by-one error in FreeBSD
Andreas Schneider [Tue, 24 Mar 2020 06:39:10 +0000 (07:39 +0100)]
tests: Workaround an off-by-one error in FreeBSD

https://www.openpam.org/wiki/Errata/2019-02-22

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agoBump version to 1.1.0 pam_wrapper-1.1.0
Andreas Schneider [Thu, 19 Mar 2020 12:09:49 +0000 (13:09 +0100)]
Bump version to 1.1.0

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agoRename ChangeLog file
Andreas Schneider [Thu, 19 Mar 2020 12:04:32 +0000 (13:04 +0100)]
Rename ChangeLog file

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agogitingore: Ignore compile database
Andreas Schneider [Fri, 20 Mar 2020 08:34:22 +0000 (09:34 +0100)]
gitingore: Ignore compile database

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotests: Fix pypamtest_test.py on BSD
Andreas Schneider [Fri, 20 Mar 2020 11:22:30 +0000 (12:22 +0100)]
tests: Fix pypamtest_test.py on BSD

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Set up a pthread_atfork() handler to not delete or config directory
Andreas Schneider [Fri, 20 Mar 2020 11:06:58 +0000 (12:06 +0100)]
pwrap: Set up a pthread_atfork() handler to not delete or config directory

Python3 has some strange behavior. It forks a child which then exits.
This child calls the destructor which deletes our /tmp/pam.X directory.

As we later try to bind the symbol the directory is gone and we detected
and error which results in exit(-1).

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Move the constructor to the end of the source file
Andreas Schneider [Fri, 20 Mar 2020 10:57:26 +0000 (11:57 +0100)]
pwrap: Move the constructor to the end of the source file

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Set initialised to false in the destructor
Andreas Schneider [Fri, 20 Mar 2020 10:52:25 +0000 (11:52 +0100)]
pwrap: Set initialised to false in the destructor

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodoc: Add generated pam_chatty.8 man page
Bastien Nocera [Wed, 4 Mar 2020 11:50:44 +0000 (12:50 +0100)]
doc: Add generated pam_chatty.8 man page

And install it.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodoc: Add pam_chatty man page source
Bastien Nocera [Wed, 4 Mar 2020 11:50:29 +0000 (12:50 +0100)]
doc: Add pam_chatty man page source

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agomodules: Remove duplicated discard_const* macros
Bastien Nocera [Wed, 4 Mar 2020 11:37:43 +0000 (12:37 +0100)]
modules: Remove duplicated discard_const* macros

They were already defined a couple of lines above.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotests: Add test for verbose PAM modules
Bastien Nocera [Wed, 22 Jan 2020 11:22:30 +0000 (12:22 +0100)]
tests: Add test for verbose PAM modules

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agotests: Add service file for chatty module
Bastien Nocera [Wed, 22 Jan 2020 11:21:05 +0000 (12:21 +0100)]
tests: Add service file for chatty module

So we can test it.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agomodules: Add pam_chatty module
Bastien Nocera [Wed, 22 Jan 2020 11:17:03 +0000 (12:17 +0100)]
modules: Add pam_chatty module

Add a simple PAM module that will output "num_lines" lines of PAM info
and/or error output.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopython: Fix crash when the PAM module outputs too much data
Bastien Nocera [Wed, 22 Jan 2020 10:50:37 +0000 (11:50 +0100)]
python: Fix crash when the PAM module outputs too much data

This code expected each input (whether echo on or echo off input),
to generate at most one info or error output, which is obviously not
correct. A PAM module with external inputs can throw dozens of messages
and warnings even if the only expected input is a password.

Allocate those placeholder arrays to be as big as possible to accomodate
chatty PAM modules.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14245

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopython: Add failure test
Bastien Nocera [Wed, 22 Jan 2020 10:49:31 +0000 (11:49 +0100)]
python: Add failure test

We only had successful pam tests, add a failing one, and check that it
fails.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopython: Fix typos
Bastien Nocera [Mon, 20 Jan 2020 17:35:40 +0000 (18:35 +0100)]
python: Fix typos

Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Add support for pam_start_confdir()
Andreas Schneider [Fri, 6 Mar 2020 16:35:28 +0000 (17:35 +0100)]
pwrap: Add support for pam_start_confdir()

This allows us to not do some ugly binary editing hacks to libpam.so.

https://github.com/linux-pam/linux-pam/commit/7a84910896d5579bd9c016696224d7d69a307bd9

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Add a check for pam_start_confdir()
Andreas Schneider [Fri, 6 Mar 2020 16:18:06 +0000 (17:18 +0100)]
cmake: Add a check for pam_start_confdir()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Add link to compile database
Andreas Schneider [Fri, 6 Mar 2020 16:35:16 +0000 (17:35 +0100)]
cmake: Add link to compile database

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agogitlab-ci: Setup CI for pam_wrapper
Andreas Schneider [Fri, 31 Jan 2020 13:01:27 +0000 (14:01 +0100)]
gitlab-ci: Setup CI for pam_wrapper

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Do not run python tests with AddressSanitizer
Andreas Schneider [Fri, 31 Jan 2020 13:57:44 +0000 (14:57 +0100)]
cmake: Do not run python tests with AddressSanitizer

It will complain about python malloc and fail.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Write new cmake config files
Andreas Schneider [Fri, 31 Jan 2020 12:59:52 +0000 (13:59 +0100)]
cmake: Write new cmake config files

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Use GNUInstallDirs
Andreas Schneider [Fri, 31 Jan 2020 12:47:37 +0000 (13:47 +0100)]
cmake: Use GNUInstallDirs

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Use target_include_directories()
Andreas Schneider [Fri, 31 Jan 2020 12:41:35 +0000 (13:41 +0100)]
cmake: Use target_include_directories()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Support running the tests with AddressSanitizer
Andreas Schneider [Fri, 31 Jan 2020 12:32:46 +0000 (13:32 +0100)]
cmake: Support running the tests with AddressSanitizer

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Add AddressSanitizer and UndefinedSanitizer
Andreas Schneider [Fri, 31 Jan 2020 12:21:06 +0000 (13:21 +0100)]
cmake: Add AddressSanitizer and UndefinedSanitizer

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Update add_cmocka_test()
Andreas Schneider [Fri, 31 Jan 2020 12:25:59 +0000 (13:25 +0100)]
cmake: Update add_cmocka_test()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Look for cmocka 1.1.0 at least
Andreas Schneider [Fri, 31 Jan 2020 12:22:50 +0000 (13:22 +0100)]
cmake: Look for cmocka 1.1.0 at least

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Move compiler flags to new file
Andreas Schneider [Fri, 31 Jan 2020 12:19:41 +0000 (13:19 +0100)]
cmake: Move compiler flags to new file

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Improve checks for compiler flags
Andreas Schneider [Fri, 31 Jan 2020 12:16:45 +0000 (13:16 +0100)]
cmake: Improve checks for compiler flags

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Update cmake defaults
Andreas Schneider [Fri, 31 Jan 2020 12:06:13 +0000 (13:06 +0100)]
cmake: Update cmake defaults

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Require at least cmake 3.5.0
Andreas Schneider [Fri, 31 Jan 2020 11:59:31 +0000 (12:59 +0100)]
cmake: Require at least cmake 3.5.0

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agoREADME: Rename to a markdown file
Andreas Schneider [Fri, 31 Jan 2020 12:03:33 +0000 (13:03 +0100)]
README: Rename to a markdown file

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agodoc: Document PAM_WRAPPER_DISABLE_DEEPBIND
Andreas Schneider [Fri, 31 Jan 2020 11:48:58 +0000 (12:48 +0100)]
doc: Document PAM_WRAPPER_DISABLE_DEEPBIND

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Fix pso_copy to work with libpam.so.0.84.2
Andreas Schneider [Fri, 15 Nov 2019 08:58:27 +0000 (09:58 +0100)]
pwrap: Fix pso_copy to work with libpam.so.0.84.2

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Use a define in pso_copy()
Andreas Schneider [Fri, 15 Nov 2019 08:45:22 +0000 (09:45 +0100)]
pwrap: Use a define in pso_copy()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Improve logging
Andreas Schneider [Fri, 15 Nov 2019 08:40:04 +0000 (09:40 +0100)]
pwrap: Improve logging

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agocmake: Add checks for getprogname() and getexecname()
Andreas Schneider [Fri, 15 Nov 2019 08:39:21 +0000 (09:39 +0100)]
cmake: Add checks for getprogname() and getexecname()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agopwrap: Add support for running with Sanitizers
Andreas Schneider [Fri, 15 Nov 2019 08:34:03 +0000 (09:34 +0100)]
pwrap: Add support for running with Sanitizers

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agocpack: Do not package pyc files
Andreas Schneider [Thu, 28 Feb 2019 11:58:28 +0000 (12:58 +0100)]
cpack: Do not package pyc files

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agoBump version to 1.0.7 pam_wrapper-1.0.7
Andreas Schneider [Tue, 25 Sep 2018 18:16:47 +0000 (20:16 +0200)]
Bump version to 1.0.7

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
5 years agopwrap: Don't do a deep bind if we run with libasan
Andreas Schneider [Sat, 1 Sep 2018 17:46:36 +0000 (19:46 +0200)]
pwrap: Don't do a deep bind if we run with libasan

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
5 years agopam_set_items: Add logging
Andreas Schneider [Thu, 20 Sep 2018 08:08:00 +0000 (10:08 +0200)]
pam_set_items: Add logging

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
5 years agopypamtest: Fix number of responses
Andreas Schneider [Mon, 25 Jun 2018 09:02:45 +0000 (11:02 +0200)]
pypamtest: Fix number of responses

The number of responses needs to match the number of provided messages.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
5 years agopwrap: Add PAM_TEXT_INFO and PAM_ERROR_MSG to responses
Andreas Schneider [Tue, 26 Jun 2018 06:46:44 +0000 (08:46 +0200)]
pwrap: Add PAM_TEXT_INFO and PAM_ERROR_MSG to responses

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
5 years agolibpamtest: Check that message count matches response count
Andreas Schneider [Mon, 25 Jun 2018 08:39:51 +0000 (10:39 +0200)]
libpamtest: Check that message count matches response count

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
5 years agocmake: Don't keep CMAKE_REQUIRED_LIBRARIES around
Andreas Schneider [Tue, 28 Aug 2018 09:18:36 +0000 (11:18 +0200)]
cmake: Don't keep CMAKE_REQUIRED_LIBRARIES around

This can cause issues with detecting features.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agoctest: Move to new dashboard
Andreas Schneider [Thu, 5 Jul 2018 08:16:27 +0000 (10:16 +0200)]
ctest: Move to new dashboard

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agocmake: Fix python2 and python3 detection
Andreas Schneider [Tue, 3 Jul 2018 09:33:04 +0000 (11:33 +0200)]
cmake: Fix python2 and python3 detection

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agopwrap: Improve error message
Andreas Schneider [Fri, 29 Jun 2018 13:23:34 +0000 (15:23 +0200)]
pwrap: Improve error message

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agopwrap: Don't clean the stale dir twice
Andreas Schneider [Fri, 29 Jun 2018 13:23:12 +0000 (15:23 +0200)]
pwrap: Don't clean the stale dir twice

This is already done above.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agotests: Fix length calulation
Andreas Schneider [Mon, 25 Jun 2018 09:02:22 +0000 (11:02 +0200)]
tests: Fix length calulation

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
5 years agoRename COPYING to LICENSE
Andreas Schneider [Fri, 22 Jun 2018 07:14:29 +0000 (09:14 +0200)]
Rename COPYING to LICENSE

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>