Andreas Schneider [Thu, 26 Mar 2020 08:17:40 +0000 (09:17 +0100)]
Bump version to 1.1.3
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Wed, 25 Mar 2020 12:11:00 +0000 (13:11 +0100)]
cmake: Fix paths in pkgconfig and cmake config files
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 13:30:35 +0000 (14:30 +0100)]
Bump version to 1.1.2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 13:29:06 +0000 (14:29 +0100)]
doc: Fix manpage installation
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 07:52:19 +0000 (08:52 +0100)]
Bump version to 1.1.1
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 07:08:50 +0000 (08:08 +0100)]
gitlab-ci: Work around a Python 3.8 bug
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 23 Mar 2020 17:49:27 +0000 (18:49 +0100)]
gitlab-ci: Add ubuntu target
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 06:32:06 +0000 (07:32 +0100)]
pwrap: Add back pso_copy for openSUSE Tumbleweed
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 06:22:37 +0000 (07:22 +0100)]
cmake: Check for pam_modutil_search_key
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 10:19:36 +0000 (11:19 +0100)]
pwrap: Use PSO_COPY_READ_SIZE in pso_copy()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 06:05:28 +0000 (07:05 +0100)]
Revert "pwrap: Fix pso_copy to work with libpam.so.0.84.2"
This reverts commit
047e9fb616d21e202add9f16347cea2084444104.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 23 Mar 2020 16:44:22 +0000 (17:44 +0100)]
pwrap: Create two pwrap_init() functions
One for pam_start() and one for pam_start_confdir() support.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 23 Mar 2020 16:47:16 +0000 (17:47 +0100)]
pwrap: Log the return code of pam_start()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 23 Mar 2020 16:39:57 +0000 (17:39 +0100)]
pwrap: Improve debug message in p_rmdirs_at()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 23 Mar 2020 16:34:37 +0000 (17:34 +0100)]
pwrap: Initialize pointers with NULL in p_rmdirs_at()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 07:37:24 +0000 (08:37 +0100)]
tests: Define PAM_AUTH_ERROR in init function
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 24 Mar 2020 06:39:10 +0000 (07:39 +0100)]
tests: Workaround an off-by-one error in FreeBSD
https://www.openpam.org/wiki/Errata/2019-02-22
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 19 Mar 2020 12:09:49 +0000 (13:09 +0100)]
Bump version to 1.1.0
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 19 Mar 2020 12:04:32 +0000 (13:04 +0100)]
Rename ChangeLog file
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 20 Mar 2020 08:34:22 +0000 (09:34 +0100)]
gitingore: Ignore compile database
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 20 Mar 2020 11:22:30 +0000 (12:22 +0100)]
tests: Fix pypamtest_test.py on BSD
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 20 Mar 2020 11:06:58 +0000 (12:06 +0100)]
pwrap: Set up a pthread_atfork() handler to not delete or config directory
Python3 has some strange behavior. It forks a child which then exits.
This child calls the destructor which deletes our /tmp/pam.X directory.
As we later try to bind the symbol the directory is gone and we detected
and error which results in exit(-1).
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 20 Mar 2020 10:57:26 +0000 (11:57 +0100)]
pwrap: Move the constructor to the end of the source file
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 20 Mar 2020 10:52:25 +0000 (11:52 +0100)]
pwrap: Set initialised to false in the destructor
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 4 Mar 2020 11:50:44 +0000 (12:50 +0100)]
doc: Add generated pam_chatty.8 man page
And install it.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 4 Mar 2020 11:50:29 +0000 (12:50 +0100)]
doc: Add pam_chatty man page source
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 4 Mar 2020 11:37:43 +0000 (12:37 +0100)]
modules: Remove duplicated discard_const* macros
They were already defined a couple of lines above.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 22 Jan 2020 11:22:30 +0000 (12:22 +0100)]
tests: Add test for verbose PAM modules
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 22 Jan 2020 11:21:05 +0000 (12:21 +0100)]
tests: Add service file for chatty module
So we can test it.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 22 Jan 2020 11:17:03 +0000 (12:17 +0100)]
modules: Add pam_chatty module
Add a simple PAM module that will output "num_lines" lines of PAM info
and/or error output.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 22 Jan 2020 10:50:37 +0000 (11:50 +0100)]
python: Fix crash when the PAM module outputs too much data
This code expected each input (whether echo on or echo off input),
to generate at most one info or error output, which is obviously not
correct. A PAM module with external inputs can throw dozens of messages
and warnings even if the only expected input is a password.
Allocate those placeholder arrays to be as big as possible to accomodate
chatty PAM modules.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14245
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Wed, 22 Jan 2020 10:49:31 +0000 (11:49 +0100)]
python: Add failure test
We only had successful pam tests, add a failing one, and check that it
fails.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Bastien Nocera [Mon, 20 Jan 2020 17:35:40 +0000 (18:35 +0100)]
python: Fix typos
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 6 Mar 2020 16:35:28 +0000 (17:35 +0100)]
pwrap: Add support for pam_start_confdir()
This allows us to not do some ugly binary editing hacks to libpam.so.
https://github.com/linux-pam/linux-pam/commit/
7a84910896d5579bd9c016696224d7d69a307bd9
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 6 Mar 2020 16:18:06 +0000 (17:18 +0100)]
cmake: Add a check for pam_start_confdir()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 6 Mar 2020 16:35:16 +0000 (17:35 +0100)]
cmake: Add link to compile database
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 13:01:27 +0000 (14:01 +0100)]
gitlab-ci: Setup CI for pam_wrapper
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 13:57:44 +0000 (14:57 +0100)]
cmake: Do not run python tests with AddressSanitizer
It will complain about python malloc and fail.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:59:52 +0000 (13:59 +0100)]
cmake: Write new cmake config files
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:47:37 +0000 (13:47 +0100)]
cmake: Use GNUInstallDirs
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:41:35 +0000 (13:41 +0100)]
cmake: Use target_include_directories()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:32:46 +0000 (13:32 +0100)]
cmake: Support running the tests with AddressSanitizer
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:21:06 +0000 (13:21 +0100)]
cmake: Add AddressSanitizer and UndefinedSanitizer
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:25:59 +0000 (13:25 +0100)]
cmake: Update add_cmocka_test()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:22:50 +0000 (13:22 +0100)]
cmake: Look for cmocka 1.1.0 at least
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:19:41 +0000 (13:19 +0100)]
cmake: Move compiler flags to new file
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:16:45 +0000 (13:16 +0100)]
cmake: Improve checks for compiler flags
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:06:13 +0000 (13:06 +0100)]
cmake: Update cmake defaults
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 11:59:31 +0000 (12:59 +0100)]
cmake: Require at least cmake 3.5.0
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 12:03:33 +0000 (13:03 +0100)]
README: Rename to a markdown file
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 31 Jan 2020 11:48:58 +0000 (12:48 +0100)]
doc: Document PAM_WRAPPER_DISABLE_DEEPBIND
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 15 Nov 2019 08:58:27 +0000 (09:58 +0100)]
pwrap: Fix pso_copy to work with libpam.so.0.84.2
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 15 Nov 2019 08:45:22 +0000 (09:45 +0100)]
pwrap: Use a define in pso_copy()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 15 Nov 2019 08:40:04 +0000 (09:40 +0100)]
pwrap: Improve logging
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 15 Nov 2019 08:39:21 +0000 (09:39 +0100)]
cmake: Add checks for getprogname() and getexecname()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 15 Nov 2019 08:34:03 +0000 (09:34 +0100)]
pwrap: Add support for running with Sanitizers
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 28 Feb 2019 11:58:28 +0000 (12:58 +0100)]
cpack: Do not package pyc files
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 25 Sep 2018 18:16:47 +0000 (20:16 +0200)]
Bump version to 1.0.7
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Andreas Schneider [Sat, 1 Sep 2018 17:46:36 +0000 (19:46 +0200)]
pwrap: Don't do a deep bind if we run with libasan
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Andreas Schneider [Thu, 20 Sep 2018 08:08:00 +0000 (10:08 +0200)]
pam_set_items: Add logging
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Andreas Schneider [Mon, 25 Jun 2018 09:02:45 +0000 (11:02 +0200)]
pypamtest: Fix number of responses
The number of responses needs to match the number of provided messages.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Andreas Schneider [Tue, 26 Jun 2018 06:46:44 +0000 (08:46 +0200)]
pwrap: Add PAM_TEXT_INFO and PAM_ERROR_MSG to responses
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Andreas Schneider [Mon, 25 Jun 2018 08:39:51 +0000 (10:39 +0200)]
libpamtest: Check that message count matches response count
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Andreas Schneider [Tue, 28 Aug 2018 09:18:36 +0000 (11:18 +0200)]
cmake: Don't keep CMAKE_REQUIRED_LIBRARIES around
This can cause issues with detecting features.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 5 Jul 2018 08:16:27 +0000 (10:16 +0200)]
ctest: Move to new dashboard
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 3 Jul 2018 09:33:04 +0000 (11:33 +0200)]
cmake: Fix python2 and python3 detection
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 29 Jun 2018 13:23:34 +0000 (15:23 +0200)]
pwrap: Improve error message
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 29 Jun 2018 13:23:12 +0000 (15:23 +0200)]
pwrap: Don't clean the stale dir twice
This is already done above.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 25 Jun 2018 09:02:22 +0000 (11:02 +0200)]
tests: Fix length calulation
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 22 Jun 2018 07:14:29 +0000 (09:14 +0200)]
Rename COPYING to LICENSE
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Fri, 22 Jun 2018 07:13:52 +0000 (09:13 +0200)]
cpack: Do not package build dirs in source tarball
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 27 Mar 2018 09:05:04 +0000 (11:05 +0200)]
Bump version to 1.0.6
Signed-off-by: Andreas Schneider <asn@samba.org>
Ralph Boehme [Mon, 26 Mar 2018 16:03:08 +0000 (18:03 +0200)]
pwrap: remove pdir handling from p_copy()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Ralph Boehme [Mon, 26 Mar 2018 14:42:00 +0000 (16:42 +0200)]
pwrap: Fix overflow checking
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Mon, 26 Mar 2018 13:45:43 +0000 (15:45 +0200)]
pwrap: Avoid strncpy in pwrap_init()
CID 47508
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Tue, 27 Feb 2018 08:17:06 +0000 (09:17 +0100)]
pwrap: Add missing config.h includes
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 22 Feb 2018 16:02:12 +0000 (17:02 +0100)]
pwrap: Remove trailing whitespaces
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Thu, 22 Feb 2018 14:46:12 +0000 (15:46 +0100)]
Bump version to 1.0.5
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Nikos Mavrogiannopoulos [Mon, 19 Feb 2018 20:23:23 +0000 (21:23 +0100)]
pwrap: Use a more unique name for pamdir
Parallel builds fail quite predictable when using libpam_wrapper.
It seems that the temporary directory used are created sequentially
and that caused issues like:
PWRAP_ERROR(8157) - pwrap_load_lib_handle: Failed to dlopen library: /tmp/pam.0/lib/libpam.so.0: cannot open shared object file: No such file or directory
When a directory was cleaned up, incorrectly. I have not pin-pointed
the race condition, but this patch starts from a random letter (using
the PID of the process) in the temporary directory name, providing
better assurances of uniqueness.
Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Mon, 12 Feb 2018 11:01:22 +0000 (12:01 +0100)]
cmake: Build python2 and python3 modules if possible
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Wed, 22 Nov 2017 14:27:44 +0000 (15:27 +0100)]
cmake: Improve PAM_WRAPPER_LOACATION
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Uri Simchoni [Wed, 22 Nov 2017 20:48:23 +0000 (20:48 +0000)]
pam_wrapper: Use a constant string format specifier in test
This fixes a warning about non-constant format specifier.
clang 4.0.0 warns against non-constant format specifier since
it cannot validate the format against the parameters.
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Uri Simchoni [Sun, 19 Nov 2017 13:08:30 +0000 (13:08 +0000)]
pam_wrapper: use uintptr_t as base for const-discarding
Seems like HAVE_INTPTR_T is not available on FreeBSD. Use
the uintptr_t-base const discarding to avoid picky compiler
warnings (other places in Samba also use uintptr_t).
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Uri Simchoni [Wed, 22 Nov 2017 14:23:26 +0000 (15:23 +0100)]
pam_wrapper: #ifdef-out unused functions
When pam_vsyslog is not available, avoid building functions
that are being used to wrap it, in order to avoid picky
compiler warnings.
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Lumir Balhar [Fri, 13 Oct 2017 13:36:15 +0000 (15:36 +0200)]
pypamtest: Fix Python 2.6 compatibility
PyErr_NewExceptionWithDoc() isn't available in Python 2.6 so it can
be used only in higher versions of Python.
Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Mon, 15 May 2017 14:37:44 +0000 (16:37 +0200)]
Bump version to 1.0.4
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Andreas Schneider [Tue, 11 Apr 2017 06:39:44 +0000 (08:39 +0200)]
pwrap: Do not leak srcfd on error
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Volker Lendecke [Mon, 1 May 2017 15:57:27 +0000 (17:57 +0200)]
pam_wrapper: Fix the build without pam_vsyslog
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 07:55:29 +0000 (09:55 +0200)]
Bump version to 1.0.3
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 09:51:32 +0000 (11:51 +0200)]
doc: Document PAM_WRAPPER_USE_SYSLOG variable
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 09:47:37 +0000 (11:47 +0200)]
pwrap: Do not log to syslog by default but use our logging
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 10:08:54 +0000 (12:08 +0200)]
pwrap: Do an early return in pwrap_vlog if log level doesn't match
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 09:41:12 +0000 (11:41 +0200)]
pwrap: Add pwrap_vlog() functions
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 07:56:15 +0000 (09:56 +0200)]
pwrap: Remove useless break
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 07:15:07 +0000 (09:15 +0200)]
libpamtest: Do not declare variable in for-loop
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 07:13:40 +0000 (09:13 +0200)]
pypamtest: Add sanity checks in new_conv_list()
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 6 Apr 2017 07:09:53 +0000 (09:09 +0200)]
pypamtest: Do not use variable declaration in for-loop
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andreas Schneider [Thu, 30 Mar 2017 06:46:44 +0000 (08:46 +0200)]
cmake: Add Python 3.6 if we look for the python library
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Wed, 29 Mar 2017 14:16:18 +0000 (16:16 +0200)]
pwrap: Do not discard const value
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Reviewed-by: Ralph Boehme <slow@samba.org>
Andreas Schneider [Wed, 29 Mar 2017 13:53:20 +0000 (15:53 +0200)]
cmake: Remove unused define
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Reviewed-by: Ralph Boehme <slow@samba.org>
git.samba.org / pam_wrapper.git / log