Fix the overwriting of errno before use in a DEBUG statement and use the return value...
[samba.git] / source3 / modules / onefs_streams.c
index 284e199fc5537a7d1b52b69aa9143cea341a4b53..0a1d98c809a9e2e53eb4e13cea1dbed1e7c7a24c 100644 (file)
  */
 
 #include "includes.h"
+#include "smbd/smbd.h"
 #include "onefs.h"
 #include "onefs_config.h"
 
 #include <sys/isi_enc.h>
 
-/*
- * OneFS stores streams without the explicit :$DATA at the end, so this strips
- * it off.  All onefs_stream functions must call through this instead of
- * split_ntfs_stream_name directly.
- */
-NTSTATUS onefs_split_ntfs_stream_name(TALLOC_CTX *mem_ctx, const char *fname,
-                                     char **pbase, char **pstream)
+NTSTATUS onefs_stream_prep_smb_fname(TALLOC_CTX *ctx,
+                                    const struct smb_filename *smb_fname_in,
+                                    struct smb_filename **smb_fname_out)
 {
+       char *stream_name = NULL;
        NTSTATUS status;
-       char *stream;
-
-       status = split_ntfs_stream_name(mem_ctx, fname, pbase, pstream);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       /* Default $DATA stream.  */
-       if (pstream == NULL || *pstream == NULL) {
-               return NT_STATUS_OK;
-       }
 
-       /* Strip off the $DATA. */
-       stream = strrchr_m(*pstream, ':');
-       SMB_ASSERT(stream);
-       stream[0] = '\0';
+       /*
+        * Only attempt to strip off the trailing :$DATA if there is an actual
+        * stream there.  If it is the default stream, the smb_fname_out will
+        * just have a NULL stream so the base file is opened.
+        */
+       if (smb_fname_in->stream_name &&
+           !is_ntfs_default_stream_smb_fname(smb_fname_in)) {
+               char *str_tmp = smb_fname_in->stream_name;
 
-       return NT_STATUS_OK;
-}
+               /* First strip off the leading ':' */
+               if (str_tmp[0] == ':') {
+                       str_tmp++;
+               }
 
-int onefs_is_stream(const char *path, char **pbase, char **pstream,
-                   bool *is_stream)
-{
-       (*is_stream) = is_ntfs_stream_name(path);
+               /* Create a new copy of the stream_name. */
+               stream_name = talloc_strdup(ctx, str_tmp);
+               if (stream_name == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
 
-       if (!(*is_stream)) {
-               return 0;
+               /* Strip off the :$DATA if one exists. */
+               str_tmp = strrchr_m(stream_name, ':');
+               if (str_tmp) {
+                       if (strcasecmp_m(str_tmp, ":$DATA") != 0) {
+                               return NT_STATUS_INVALID_PARAMETER;
+                       }
+                       str_tmp[0] = '\0';
+               }
        }
 
-       if (!NT_STATUS_IS_OK(onefs_split_ntfs_stream_name(talloc_tos(), path,
-                                                         pbase, pstream))) {
-               DEBUG(10, ("onefs_split_ntfs_stream_name failed\n"));
-               errno = ENOMEM;
-               return -1;
-       }
+       /*
+        * If there was a stream that wasn't the default stream the leading
+        * colon and trailing :$DATA has now been stripped off.  Create a new
+        * smb_filename to pass back.
+        */
+       status = create_synthetic_smb_fname(ctx, smb_fname_in->base_name,
+                                           stream_name, &smb_fname_in->st,
+                                           smb_fname_out);
+       TALLOC_FREE(stream_name);
 
-       return 0;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(5, ("Failed to prep stream name for %s: %s\n",
+                         *smb_fname_out ?
+                         smb_fname_str_dbg(*smb_fname_out) : "NULL",
+                         nt_errstr(status)));
+       }
+       return status;
 }
 
 int onefs_close(vfs_handle_struct *handle, struct files_struct *fsp)
@@ -95,6 +104,9 @@ static int get_stream_dir_fd(connection_struct *conn, const char *base,
        int dir_fd;
        int saved_errno;
 
+       DEBUG(10, ("Getting stream directory fd: %s (%d)\n", base,
+                  base_fdp ? *base_fdp : -1));
+
        /* If a valid base_fdp was given, use it. */
        if (base_fdp && *base_fdp >= 0) {
                base_fd = *base_fdp;
@@ -114,6 +126,8 @@ static int get_stream_dir_fd(connection_struct *conn, const char *base,
                                                0,
                                                NULL);
                if (base_fd < 0) {
+                       DEBUG(5, ("Failed getting base fd: %s\n",
+                                 strerror(errno)));
                        return -1;
                }
        }
@@ -146,71 +160,91 @@ static int get_stream_dir_fd(connection_struct *conn, const char *base,
                *base_fdp = base_fd;
        }
 
+       if (dir_fd < 0) {
+               DEBUG(5, ("Failed getting stream directory fd: %s\n",
+                         strerror(errno)));
+       }
+
        return dir_fd;
 }
 
-int onefs_rename(vfs_handle_struct *handle, const char *oldname,
-                const char *newname)
+int onefs_rename(vfs_handle_struct *handle,
+                const struct smb_filename *smb_fname_src,
+                const struct smb_filename *smb_fname_dst)
 {
-       TALLOC_CTX *frame = NULL;
-       int ret = -1;
-       int dir_fd = -1;
+       struct smb_filename *smb_fname_src_onefs = NULL;
+       struct smb_filename *smb_fname_dst_onefs = NULL;
+       NTSTATUS status;
        int saved_errno;
-       bool old_is_stream;
-       bool new_is_stream;
-       char *obase = NULL;
-       char *osname = NULL;
-       char *nbase = NULL;
-       char *nsname = NULL;
+       int dir_fd = -1;
+       int ret = -1;
 
        START_PROFILE(syscall_rename_at);
 
-       frame = talloc_stackframe();
-
-       ret = onefs_is_stream(oldname, &obase, &osname, &old_is_stream);
-       if (ret) {
-               END_PROFILE(syscall_rename_at);
-               return ret;
+       if (!is_ntfs_stream_smb_fname(smb_fname_src) &&
+           !is_ntfs_stream_smb_fname(smb_fname_dst)) {
+               ret = SMB_VFS_NEXT_RENAME(handle, smb_fname_src,
+                                         smb_fname_dst);
+               goto done;
        }
 
-       ret = onefs_is_stream(newname, &nbase, &nsname, &new_is_stream);
-       if (ret) {
-               END_PROFILE(syscall_rename_at);
-               return ret;
+       /* For now don't allow renames from or to the default stream. */
+       if (is_ntfs_default_stream_smb_fname(smb_fname_src) ||
+           is_ntfs_default_stream_smb_fname(smb_fname_dst)) {
+               DEBUG(3, ("Unable to rename to/from a default stream: %s -> "
+                         "%s\n", smb_fname_str_dbg(smb_fname_src),
+                         smb_fname_str_dbg(smb_fname_dst)));
+               errno = ENOSYS;
+               goto done;
        }
 
-       if (!old_is_stream && !new_is_stream) {
-               ret = SMB_VFS_NEXT_RENAME(handle, oldname, newname);
-               END_PROFILE(syscall_rename_at);
-               return ret;
+       /* prep stream smb_filename structs. */
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname_src,
+                                            &smb_fname_src_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               goto done;
+       }
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname_dst,
+                                            &smb_fname_dst_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               goto done;
        }
 
-       dir_fd = get_stream_dir_fd(handle->conn, obase, NULL);
+       dir_fd = get_stream_dir_fd(handle->conn, smb_fname_src->base_name,
+                                  NULL);
        if (dir_fd < -1) {
                goto done;
        }
 
-       DEBUG(8,("onefs_rename called for %s : %s  => %s : %s\n",
-               obase, osname,  nbase, nsname));
+       DEBUG(8, ("onefs_rename called for %s => %s\n",
+                 smb_fname_str_dbg(smb_fname_src_onefs),
+                 smb_fname_str_dbg(smb_fname_dst_onefs)));
 
        /* Handle rename of stream to default stream specially. */
-       if (nsname == NULL) {
-               ret = enc_renameat(dir_fd, osname, ENC_DEFAULT, AT_FDCWD,
-                                  nbase, ENC_DEFAULT);
+       if (smb_fname_dst_onefs->stream_name == NULL) {
+               ret = enc_renameat(dir_fd, smb_fname_src_onefs->stream_name,
+                                  ENC_DEFAULT, AT_FDCWD,
+                                  smb_fname_dst_onefs->base_name,
+                                  ENC_DEFAULT);
        } else {
-               ret = enc_renameat(dir_fd, osname, ENC_DEFAULT, dir_fd, nsname,
+               ret = enc_renameat(dir_fd, smb_fname_src_onefs->stream_name,
+                                  ENC_DEFAULT, dir_fd,
+                                  smb_fname_dst_onefs->stream_name,
                                   ENC_DEFAULT);
        }
 
  done:
        END_PROFILE(syscall_rename_at);
+       TALLOC_FREE(smb_fname_src_onefs);
+       TALLOC_FREE(smb_fname_dst_onefs);
 
        saved_errno = errno;
        if (dir_fd >= 0) {
                close(dir_fd);
        }
        errno = saved_errno;
-       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -298,6 +332,9 @@ static int stat_stream(struct connection_struct *conn, const char *base,
        /* Stat the stream. */
        ret = onefs_sys_fstat_at(dir_fd, stream, sbuf, flags);
        if (ret != -1) {
+               DEBUG(10, ("stat of stream '%s' failed: %s\n", stream,
+                          strerror(errno)));
+       } else {
                /* Now stat the base file and merge the results. */
                ret = onefs_sys_fstat(base_fd, &base_sbuf);
                if (ret != -1) {
@@ -312,28 +349,37 @@ static int stat_stream(struct connection_struct *conn, const char *base,
        return ret;
 }
 
-int onefs_stat(vfs_handle_struct *handle, const char *path,
-              SMB_STRUCT_STAT *sbuf)
+int onefs_stat(vfs_handle_struct *handle, struct smb_filename *smb_fname)
 {
+       struct smb_filename *smb_fname_onefs = NULL;
+       NTSTATUS status;
        int ret;
-       bool is_stream;
-       char *base = NULL;
-       char *stream = NULL;
 
-       ret = onefs_is_stream(path, &base, &stream, &is_stream);
-       if (ret)
-               return ret;
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname,
+                                            &smb_fname_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               return -1;
+       }
 
-       if (!is_stream) {
-               ret = onefs_sys_stat(path, sbuf);
-       } else if (!stream) {
-               /* If it's the ::$DATA stream just stat the base file name. */
-               ret = onefs_sys_stat(base, sbuf);
+       /*
+        * If the smb_fname has no stream or is :$DATA, then just stat the
+        * base stream. Otherwise stat the stream.
+        */
+       if (!is_ntfs_stream_smb_fname(smb_fname_onefs)) {
+               ret = onefs_sys_stat(smb_fname_onefs->base_name,
+                                    &smb_fname->st);
        } else {
-               ret = stat_stream(handle->conn, base, stream, sbuf, 0);
+               ret = stat_stream(handle->conn, smb_fname_onefs->base_name,
+                                 smb_fname_onefs->stream_name, &smb_fname->st,
+                                 0);
        }
 
-       onefs_adjust_stat_time(handle->conn, path, sbuf);
+       onefs_adjust_stat_time(handle->conn, smb_fname->base_name,
+                              &smb_fname->st);
+
+       TALLOC_FREE(smb_fname_onefs);
+
        return ret;
 }
 
@@ -357,125 +403,135 @@ int onefs_fstat(vfs_handle_struct *handle, struct files_struct *fsp,
                }
        }
 
-       onefs_adjust_stat_time(handle->conn, fsp->fsp_name, sbuf);
+       onefs_adjust_stat_time(handle->conn, fsp->fsp_name->base_name, sbuf);
        return ret;
 }
 
-int onefs_lstat(vfs_handle_struct *handle, const char *path,
-               SMB_STRUCT_STAT *sbuf)
+int onefs_lstat(vfs_handle_struct *handle, struct smb_filename *smb_fname)
 {
+       struct smb_filename *smb_fname_onefs = NULL;
+       NTSTATUS status;
        int ret;
-       bool is_stream;
-       char *base = NULL;
-       char *stream = NULL;
 
-       ret = onefs_is_stream(path, &base, &stream, &is_stream);
-       if (ret)
-               return ret;
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname,
+                                            &smb_fname_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               return -1;
+       }
 
-       if (!is_stream) {
-               ret = onefs_sys_lstat(path, sbuf);
-       } else if (!stream) {
-               /* If it's the ::$DATA stream just stat the base file name. */
-               ret = onefs_sys_lstat(base, sbuf);
+       /*
+        * If the smb_fname has no stream or is :$DATA, then just stat the
+        * base stream. Otherwise stat the stream.
+        */
+       if (!is_ntfs_stream_smb_fname(smb_fname_onefs)) {
+               ret = onefs_sys_lstat(smb_fname_onefs->base_name,
+                                     &smb_fname->st);
        } else {
-               ret = stat_stream(handle->conn, base, stream, sbuf,
+               ret = stat_stream(handle->conn, smb_fname_onefs->base_name,
+                                 smb_fname_onefs->stream_name, &smb_fname->st,
                                  AT_SYMLINK_NOFOLLOW);
        }
 
-       onefs_adjust_stat_time(handle->conn, path, sbuf);
+       onefs_adjust_stat_time(handle->conn, smb_fname->base_name,
+                              &smb_fname->st);
+
+       TALLOC_FREE(smb_fname_onefs);
+
        return ret;
 }
 
-int onefs_unlink(vfs_handle_struct *handle, const char *path)
+int onefs_unlink(vfs_handle_struct *handle,
+                const struct smb_filename *smb_fname)
 {
+       struct smb_filename *smb_fname_onefs = NULL;
        int ret;
-       bool is_stream;
-       char *base = NULL;
-       char *stream = NULL;
        int dir_fd, saved_errno;
+       NTSTATUS status;
 
-       ret = onefs_is_stream(path, &base, &stream, &is_stream);
-       if (ret) {
-               return ret;
+       /* Not a stream. */
+       if (!is_ntfs_stream_smb_fname(smb_fname)) {
+               return SMB_VFS_NEXT_UNLINK(handle, smb_fname);
        }
 
-       if (!is_stream) {
-               return SMB_VFS_NEXT_UNLINK(handle, path);
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname,
+                                            &smb_fname_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               return -1;
        }
 
-       /* If it's the ::$DATA stream just unlink the base file name. */
-       if (!stream) {
-               return SMB_VFS_NEXT_UNLINK(handle, base);
+       /* Default stream (the ::$DATA was just stripped off). */
+       if (!is_ntfs_stream_smb_fname(smb_fname_onefs)) {
+               ret = SMB_VFS_NEXT_UNLINK(handle, smb_fname_onefs);
+               goto out;
        }
 
-       dir_fd = get_stream_dir_fd(handle->conn, base, NULL);
+       dir_fd = get_stream_dir_fd(handle->conn, smb_fname_onefs->base_name,
+                                  NULL);
        if (dir_fd < 0) {
-               return -1;
+               ret = -1;
+               goto out;
        }
 
-       ret = enc_unlinkat(dir_fd, stream, ENC_DEFAULT, 0);
+       ret = enc_unlinkat(dir_fd, smb_fname_onefs->stream_name, ENC_DEFAULT,
+                          0);
 
        saved_errno = errno;
        close(dir_fd);
        errno = saved_errno;
+ out:
+       TALLOC_FREE(smb_fname_onefs);
        return ret;
 }
 
-int onefs_vtimes_streams(vfs_handle_struct *handle, const char *fname,
+int onefs_vtimes_streams(vfs_handle_struct *handle,
+                        const struct smb_filename *smb_fname,
                         int flags, struct timespec times[3])
 {
+       struct smb_filename *smb_fname_onefs = NULL;
        int ret;
-       bool is_stream;
-       char *base;
-       char *stream;
        int dirfd;
        int saved_errno;
+       NTSTATUS status;
 
        START_PROFILE(syscall_ntimes);
 
-       ret = onefs_is_stream(fname, &base, &stream, &is_stream);
-       if (ret)
-               return ret;
-
-       if (!is_stream) {
-               ret = vtimes(fname, times, flags);
+       if (!is_ntfs_stream_smb_fname(smb_fname)) {
+               ret = vtimes(smb_fname->base_name, times, flags);
                return ret;
        }
 
-       dirfd = get_stream_dir_fd(handle->conn, base, NULL);
-       if (dirfd < -1) {
+       status = onefs_stream_prep_smb_fname(talloc_tos(), smb_fname,
+                                            &smb_fname_onefs);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
                return -1;
        }
 
-       ret = enc_vtimesat(dirfd, stream, ENC_DEFAULT, times, flags);
+       /* Default stream (the ::$DATA was just stripped off). */
+       if (!is_ntfs_stream_smb_fname(smb_fname_onefs)) {
+               ret = vtimes(smb_fname_onefs->base_name, times, flags);
+               goto out;
+       }
 
-       END_PROFILE(syscall_ntimes);
+       dirfd = get_stream_dir_fd(handle->conn, smb_fname->base_name, NULL);
+       if (dirfd < -1) {
+               ret = -1;
+               goto out;
+       }
+
+       ret = enc_vtimesat(dirfd, smb_fname_onefs->stream_name, ENC_DEFAULT,
+                          times, flags);
 
        saved_errno = errno;
        close(dirfd);
        errno = saved_errno;
-       return ret;
-}
-
-int onefs_chflags(vfs_handle_struct *handle, const char *path,
-                 unsigned int flags)
-{
-       char *base = NULL;
-       char *stream = NULL;
 
-       if (!NT_STATUS_IS_OK(onefs_split_ntfs_stream_name(talloc_tos(), path,
-                                                         &base, &stream))) {
-               DEBUG(10, ("onefs_split_ntfs_stream_name failed\n"));
-               errno = ENOMEM;
-               return -1;
-       }
-
-       /*
-        * Only set the attributes on the base file.  ifs_createfile handles
-        * file creation attribute semantics.
-        */
-       return SMB_VFS_NEXT_CHFLAGS(handle, base, flags);
+ out:
+       END_PROFILE(syscall_ntimes);
+       TALLOC_FREE(smb_fname_onefs);
+       return ret;
 }
 
 /*
@@ -491,12 +547,12 @@ struct streaminfo_state {
 
 static bool add_one_stream(TALLOC_CTX *mem_ctx, unsigned int *num_streams,
                           struct stream_struct **streams,
-                          const char *name, SMB_OFF_T size,
-                          SMB_OFF_T alloc_size)
+                          const char *name, off_t size,
+                          off_t alloc_size)
 {
        struct stream_struct *tmp;
 
-       tmp = TALLOC_REALLOC_ARRAY(mem_ctx, *streams, struct stream_struct,
+       tmp = talloc_realloc(mem_ctx, *streams, struct stream_struct,
                                   (*num_streams)+1);
        if (tmp == NULL) {
                return false;
@@ -527,8 +583,8 @@ static NTSTATUS walk_onefs_streams(connection_struct *conn, files_struct *fsp,
        int dir_fd = -1;
        int stream_fd = -1;
        int ret;
-       SMB_STRUCT_DIR *dirp = NULL;
-       SMB_STRUCT_DIRENT *dp = NULL;
+       DIR *dirp = NULL;
+       struct dirent *dp = NULL;
        files_struct fake_fs;
        struct fd_handle fake_fh;
        SMB_STRUCT_STAT stream_sbuf;
@@ -571,7 +627,11 @@ static NTSTATUS walk_onefs_streams(connection_struct *conn, files_struct *fsp,
 
        fake_fs.conn = conn;
        fake_fs.fh = &fake_fh;
-       fake_fs.fsp_name = SMB_STRDUP(fname);
+       status = create_synthetic_smb_fname(talloc_tos(), fname, NULL, NULL,
+                                           &fake_fs.fsp_name);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto out;
+       }
 
        /* Iterate over the streams in the ADS directory. */
        while ((dp = SMB_VFS_READDIR(conn, dirp, NULL)) != NULL) {
@@ -638,7 +698,7 @@ out:
                close(base_fd);
        }
 
-       SAFE_FREE(fake_fs.fsp_name);
+       TALLOC_FREE(fake_fs.fsp_name);
        return status;
 }
 
@@ -656,40 +716,34 @@ NTSTATUS onefs_streaminfo(vfs_handle_struct *handle,
 
        /* Get a valid stat. */
        if ((fsp != NULL) && (fsp->fh->fd != -1)) {
-               if (is_ntfs_stream_name(fsp->fsp_name)) {
-                       return NT_STATUS_INVALID_PARAMETER;
-               }
                ret = SMB_VFS_FSTAT(fsp, &sbuf);
        } else {
-               if (is_ntfs_stream_name(fname)) {
-                       return NT_STATUS_INVALID_PARAMETER;
+               struct smb_filename *smb_fname = NULL;
+
+               status = create_synthetic_smb_fname(talloc_tos(), fname, NULL,
+                                                   NULL, &smb_fname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
-               ret = SMB_VFS_STAT(handle->conn, fname, &sbuf);
+               ret = SMB_VFS_STAT(handle->conn, smb_fname);
+
+               sbuf = smb_fname->st;
+
+               TALLOC_FREE(smb_fname);
        }
 
        if (ret == -1) {
                return map_nt_error_from_unix(errno);
        }
 
-       state.streams = NULL;
-       state.num_streams = 0;
+       state.streams = *pstreams;
+       state.num_streams = *pnum_streams;
 
        if (lp_parm_bool(SNUM(handle->conn), PARM_ONEFS_TYPE,
                PARM_IGNORE_STREAMS, PARM_IGNORE_STREAMS_DEFAULT)) {
                goto out;
        }
 
-       /* Add the default stream. */
-       if (S_ISREG(sbuf.st_ex_mode)) {
-               if (!add_one_stream(mem_ctx,
-                                   &state.num_streams, &state.streams,
-                                   "", sbuf.st_ex_size,
-                                   SMB_VFS_GET_ALLOC_SIZE(handle->conn, fsp,
-                                                          &sbuf))) {
-                       return NT_STATUS_NO_MEMORY;
-               }
-       }
-
        state.mem_ctx = mem_ctx;
        state.handle = handle;
        state.status = NT_STATUS_OK;
@@ -713,5 +767,5 @@ NTSTATUS onefs_streaminfo(vfs_handle_struct *handle,
  out:
        *num_streams = state.num_streams;
        *streams = state.streams;
-       return NT_STATUS_OK;
+       return SMB_VFS_NEXT_STREAMINFO(handle, fsp, fname, mem_ctx, pnum_streams, pstreams);
 }