Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"
authorJeremy Allison <jra@samba.org>
Fri, 8 Jan 2010 18:17:46 +0000 (10:17 -0800)
committerJeremy Allison <jra@samba.org>
Fri, 8 Jan 2010 18:17:46 +0000 (10:17 -0800)
commitd7713d11a6dc2d66c820d7496bc45eb5fe527fbf
tree0720ac7ab70626eddb887d273477eecbdc9a5063
parentfca0c4de2ab8890af4d5f15009a2777691f222bd
Re-fix bug 5202 - cannot change ACLs on writable file with "dos filemode=yes"

This bug re-occurred for 3.3.x and above.

The reason is that to change a NT ACL we now have to open the file requesting
WRITE_DAC and WRITE_OWNER access. The mapping from POSIX "w" to NT permissions
in posix_acls doesn't add these bits when "dos filemode = yes", so even though
the permission or owner change would be allowed by the POSIX ACL code, the
NTCreateX call fails with ACCESS_DENIED now we always check NT permissions
first.

Added in the mapping from "w" to WRITE_DAC and WRITE_OWNER access.

Jeremy.
source3/smbd/posix_acls.c