cvs2svn Import User [Fri, 18 Sep 1998 14:05:06 +0000 (14:05 +0000)]
This commit was manufactured by cvs2svn to create tag
'release-2-0-0-alpha-6'.
Samba Release Account [Fri, 18 Sep 1998 14:05:05 +0000 (14:05 +0000)]
preparing for release of 2.0.0 alpha 6
Andrew Tridgell [Fri, 18 Sep 1998 13:52:30 +0000 (13:52 +0000)]
oops ... I got the filenames wrong in my cleanup of the wins database
save, so it started saving weird filenames (from an unitialised
fstring).
chaos reigns!
Richard Sharpe [Fri, 18 Sep 1998 12:47:46 +0000 (12:47 +0000)]
Adding rewritten restore code ... Old code is still there
surrounded by a OLD_DOTARPUT.
Andrew Tridgell [Fri, 18 Sep 1998 03:53:14 +0000 (03:53 +0000)]
got rid of SMB_STRUCT_STATVFS. I don't think we should be defining
structures that only apply on some platforms.
Andrew Tridgell [Fri, 18 Sep 1998 03:00:20 +0000 (03:00 +0000)]
gto ri of a bunch more #ifdef LARGE_SMB_OFF_T checks by introducing a
SOFF_T() macro for setting an SMB_OFF_T variable
also limited mmap based reads to MAX_MMAP_SIZE. We really can't mmap
2^50 bytes due to virtual address space problems.
Andrew Tridgell [Fri, 18 Sep 1998 02:30:03 +0000 (02:30 +0000)]
added a SMB_OFF_T_BITS define, allowing us to get rid of most of the
#ifdefs for LARGE_OFF_T.
Andrew Tridgell [Fri, 18 Sep 1998 02:28:21 +0000 (02:28 +0000)]
fixed a typo (LLARGE_SMB_OFF_T instead of LARGE_SMB_OFF_T)
Andrew Tridgell [Fri, 18 Sep 1998 02:27:24 +0000 (02:27 +0000)]
removed another use of the LL suffix. Hopefully this is the last one
(a grep doesn't show any more)
Andrew Tridgell [Fri, 18 Sep 1998 02:26:36 +0000 (02:26 +0000)]
fixed a usage of off_t that should have been SMB_OFF_T
Andrew Tridgell [Fri, 18 Sep 1998 02:21:07 +0000 (02:21 +0000)]
got rid of some #ifdef LARGE_XXXX stuff and got rid of non-portable LL
suffix from some constants.
Jeremy Allison [Fri, 18 Sep 1998 00:30:28 +0000 (00:30 +0000)]
include/includes.h:
lib/system.c: Can't assume every system has a statvfs varient.
Return -1 for those that don't.
smbd/reply.c: Fixed printf warning.
Jeremy.
Jeremy Allison [Fri, 18 Sep 1998 00:12:15 +0000 (00:12 +0000)]
nmbd/nmbd_winsserver.c: Fixed printf style warning.
script/mkproto.awk: Added SMB_BIG_UINT.
Jeremy.
Jeremy Allison [Thu, 17 Sep 1998 23:06:57 +0000 (23:06 +0000)]
configure configure.in: Added checks for statvfs64. Last bit of 64 bit widening (I hope :-).
include/config.h.in: Added #undef STAT_STATVFS64.
include/includes.h: Added SMB_STRUCT_STATVFS type, Changed SMB_BIG_INTEGER to
SMB_BIG_UINT and SMB_BIG_INT types.
include/smb.h: Added flag defines from CIFS spec.
lib/debug.c: Fixed one more mode_t issue.
lib/system.c: Added sys_statvfs wrapper.
lib/util.c: Changed trim_string to use size_t.
param/loadparm.c: Moved "blocking locks" into locking section. Alphabetised
locking options. Question - shuld we do this for all options ?
passdb/ldap.c: Changed SMB_BIG_INTEGER to SMB_BIG_UINT.
passdb/nispass.c: Changed SMB_BIG_INTEGER to SMB_BIG_UINT.
passdb/smbpass.c: Changed SMB_BIG_INTEGER to SMB_BIG_UINT.
smbd/dfree.c: Changed to use 64 bit types if available. Moved to use unsigned
types.
smbd/dosmode.c: Fixed one more mode_t issue.
smbd/negprot.c: Changed literals to be FLAG_ #defines.
smbd/nttrans.c: Removed dead code.
smbd/open.c: Changed disk_free call.
smbd/process.c: Changed literals to be FLAG_ #defines.
smbd/reply.c: Changed disk_free call.
smbd/trans2.c: Fixed but in SMB_QUERY_FS_VOLUME_INFO call. Was using
UNICODE - should use ascii.
tests/summary.c: Added STAT_STATVFS64 check.
Jeremy.
Jeremy Allison [Thu, 17 Sep 1998 19:16:12 +0000 (19:16 +0000)]
configure configure.in: Added tests for fseek64 and ftell64.
config.h.in: Added fseek64 and ftell64.
includes.h: Added definition of SMB_BIG_INTEGER.
smb.h: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
access.c: Tidyup of dbug statement.
system.c: Added sys_fseek and sys_ftell. Changed mode calls to use mode_t.
asyncdns.c: Tidyup of comment.
loadparm.c: Tidyup of set_default_server_announce_type() function definition.
ldap.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
nispass.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
smbpass.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
smbpassfile.c: Use sys_fseek().
chgpasswd.c: Tidyup of debug statement.
dosmode.c: Changed mode calls to use mode_t.
ipc.c: Removal of dead code.
nttrans.c: Changed mode calls to use mode_t.
open.c: Changed mode calls to use mode_t.
pipes.c: Removal of dead code.
reply.c: Removal of dead code.
trans2.c: Removal of dead code. Changed mode calls to use mode_t.
Jeremy.
Jeremy Allison [Thu, 17 Sep 1998 19:09:16 +0000 (19:09 +0000)]
configure, configure.in: Added fseek64 and ftell64.
config.h.in: Added fseek64 and ftell64.
includes.h: Added definition of SMB_BIG_INTEGER.
smb.h: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
access.c: Tidyup of dbug statement.
system.c: Added sys_fseek and sys_ftell. Changed mode calls to use mode_t.
asyncdns.c: Tidyup of comment.
loadparm.c: Tidyup of set_default_server_announce_type() function definition.
ldap.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
nispass.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
smbpass.c: Changed (*getsmbpwpos) and (*setsmbpwpos) to use SMB_BIG_INTEGER.
smbpassfile.c: Use sys_fseek().
chgpasswd.c: Tidyup of debug statement.
dosmode.c: Changed mode calls to use mode_t.
ipc.c: Removal of dead code.
nttrans.c: Changed mode calls to use mode_t.
open.c: Changed mode calls to use mode_t.
pipes.c: Removal of dead code.
reply.c: Removal of dead code.
trans2.c: Removal of dead code. Changed mode calls to use mode_t.
Jeremy.
Samba Release Account [Thu, 17 Sep 1998 08:35:56 +0000 (08:35 +0000)]
preparing for release of 2.0.0 alpha 5
Andrew Tridgell [Thu, 17 Sep 1998 08:35:07 +0000 (08:35 +0000)]
fixed another potential fork bomb where the wins file becomes
non-writeable for some reason.
Andrew Tridgell [Thu, 17 Sep 1998 08:27:46 +0000 (08:27 +0000)]
fixed the nmbd fork bomb. It was a silly mistake, as
expected. wins_write_database() didn't exit after doing its stuff, so
when it returned you had two copies of nmbd :)
Andrew Tridgell [Thu, 17 Sep 1998 08:23:00 +0000 (08:23 +0000)]
fixed a typo in my last commit
Andrew Tridgell [Thu, 17 Sep 1998 06:36:08 +0000 (06:36 +0000)]
fixed a potential problem with wins_write_database() child processes.
In sig_term() we were calling wins_write_database(0) which would fork a
child. This child might then get killed by the same process killing
off the parent. That process would then fork another child etc.
The solution is to pass a "background" flag to wins_write_database(0)
and only fork if this is set.
Jeremy Allison [Tue, 15 Sep 1998 01:38:10 +0000 (01:38 +0000)]
Removed hideous inefficiencies in old trim_string code. This was making
calls to strlen() a profiling hotspot.
Jeremy.
Jeremy Allison [Mon, 14 Sep 1998 20:43:50 +0000 (20:43 +0000)]
Mapped correct open modes for READ_CONTROL access.
Jeremy.
Jeremy Allison [Mon, 14 Sep 1998 19:49:55 +0000 (19:49 +0000)]
Fixed problems people were having with creating profile
directories (NTTrans/Create with Security Descriptor for
a directory). It turns out the CIFS spec is bogus (what a
suprise) and the 'is a directory' flag is actually embedded
in the create_options field.
Jeremy.
Jeremy Allison [Fri, 11 Sep 1998 21:42:18 +0000 (21:42 +0000)]
Ok so with this bugfix 64 bit file access actually seems to work :-).
Problems were just dumb bugs like (defining sys_lseek to return 'int' DOH !).
Jeremy.
Jeremy Allison [Fri, 11 Sep 1998 19:14:27 +0000 (19:14 +0000)]
Ok - this is the 'expose 64 bit to the clients' checkin.
I have tested it by creating a 'holey' 20GB file - checking that
it shows up correctl in the NT file view (it does) and am busily
copying it to NULL: on the NT box. All good so far.... :-).
Also implemented NT 'delete on close' semantics.
Jeremy.
Jeremy Allison [Fri, 11 Sep 1998 01:24:30 +0000 (01:24 +0000)]
Added ssize_t to configure code.
Got 'religion' about using size_t and ssize_t for read/write stuff
as part of the code to expose 64 bits to the client.
This checkin does all the 'easy' stuff - such as all the read/write/lock
calls - but now comes the harder parts (open & friends) and all the
file enquiry functions.....
Jeremy.
Jeremy Allison [Thu, 10 Sep 1998 18:57:06 +0000 (18:57 +0000)]
smb.h: Removed fdnum from file_fd_struct. Not needed.
files.c: Removed fd bitmap - not needed. Added code to do use arrays rather
than linked list - disabled by default but can be enabled to check
performance.
Jeremy.
Andrew Tridgell [Thu, 10 Sep 1998 04:00:09 +0000 (04:00 +0000)]
fixed a bug in the wins database writer that caused the database to be
written continuously rather than once every 5 seconds (at most).
also changed it to 20 seconds :)
Jeremy Allison [Thu, 10 Sep 1998 00:35:10 +0000 (00:35 +0000)]
Improved stat cache code by uppercasing any search name that gets added to
it if we're in case insensitive mode, and then doing a memcmp rather
than a StrnCaseCmp (which is *horribly* slow) on every lookup.
Fixed bug with refusing NT SMB's (use *brackets* where needed :-).
Jeremy.
Christopher R. Hertel [Wed, 9 Sep 1998 16:37:54 +0000 (16:37 +0000)]
Copyright notices written to debug logs are now through 1998.
Chris -)-----
Jeremy Allison [Tue, 8 Sep 1998 19:21:04 +0000 (19:21 +0000)]
Added back groupname map stuff removed by Andrew's "slash 'n' burn"
tactics :-). Protected by #ifdef until used.
Fixed bug in fd_attempt_close() where a pointer to potentially
free'd memory was returned. I hate that.
Added "blocking locks" as a per-share option for performance testing.
Changed is_mangled() so it will return true if called with a pathname
and any component of the pathname was mangled (it was already attempting
to do this, but not checking for a '/' as end-of-mangle).
This should be a better fix for the wierd stat cache bug Andrew identified.
Jeremy.
Luke Leighton [Mon, 7 Sep 1998 17:01:52 +0000 (17:01 +0000)]
added 0x10 to the frag length in the "bind ack".
John Terpstra [Sun, 6 Sep 1998 05:50:18 +0000 (05:50 +0000)]
Adding header and footer html files for SWAT, adding samba.gif file too.
Andrew Tridgell [Sun, 6 Sep 1998 01:37:14 +0000 (01:37 +0000)]
add a "stat cache" boolean smb.conf option. (defaults to on)
I think we need this so we can rule out stat cache bugs when dealing
with bug reports. If we ask a user to disable the stat cache and the
problem persists then we know it isn't a stat cache bug. The stat
cache code is sufficiently complicated that it can be pretty hard to
tell if it is causing problems or not.
Andrew Tridgell [Sat, 5 Sep 1998 15:31:10 +0000 (15:31 +0000)]
fixed a stat cache bug (the one found by Matthew Geier).
The fix I used is a very conservative fix. I'll leave it up to Jeremy
to put in a better fix. The problem was the detection of mangled
names.
Andrew Tridgell [Sat, 5 Sep 1998 13:53:13 +0000 (13:53 +0000)]
added a configuration summary at the end of ./configure. It also
aborts if essential functions are not available.
Andrew Tridgell [Sat, 5 Sep 1998 13:35:54 +0000 (13:35 +0000)]
expand the sysv shmem test to look for semaphores as well as shared
memory. Some FreeBSD systems have sysv shared memory but no
semaphores!
Andrew Tridgell [Sat, 5 Sep 1998 13:24:20 +0000 (13:24 +0000)]
some cleanups to use ZERO_STRUCT() and friends
Andrew Tridgell [Sat, 5 Sep 1998 13:21:57 +0000 (13:21 +0000)]
some people are foolishly running ./configure from other than the
source directory! This adds a new "trivial" test that makes sure that
the autoconf tests are working. It aborts the configure run if not.
Andrew Tridgell [Sat, 5 Sep 1998 05:23:29 +0000 (05:23 +0000)]
ahh, the joy of deleting large chunks of code that someone else has
painstakingly put in :)
This gets rid of most of the #ifdef LARGE_SMB_INO_T ifdefs around
DEBUG() statements. We just use %.0f in all cases. Makes the code a
bit easier to read :)
Andrew Tridgell [Sat, 5 Sep 1998 05:07:05 +0000 (05:07 +0000)]
tridge the destroyer returns!
prompted by the interpret_security() dead code that Jean-Francois
pointed out I added a make target "finddead" that finds potentially
dead (ie. unused) code. It spat out 304 function names ...
I went through these are deleted many of them, making others static
(finddead also reports functions that are used only in the local
file).
in doing this I have almost certainly deleted some useful code. I may
have even prevented compilation with some compile options. I
apologise. I decided it was better to get rid of this code now and add
back the one or two functions that are needed than to keep all this
baggage.
So, if I have done a bit too much "destroying" then let me know. Keep
the swearing to a minimum :)
One bit I didn't do is the ubibt code. Chris, can you look at that?
Heaps of unused functions there. Can they be made static?
Jeremy Allison [Sat, 5 Sep 1998 03:38:50 +0000 (03:38 +0000)]
Fixed one more Debug problem with inode in non-64 bit case.
Jeremy.
Jeremy Allison [Sat, 5 Sep 1998 03:14:40 +0000 (03:14 +0000)]
Bugfix for leak in reference counted file struct.
Added "nt smb support" parameter to allow NT SMB's to be turned off.
Jeremy.
Andrew Tridgell [Sat, 5 Sep 1998 01:12:07 +0000 (01:12 +0000)]
got rid of interpret_security(). Thanks to Jean-Francois for pointing
out it is no longer used (replaced by enumerated types in loadparm.c)
Jeremy Allison [Fri, 4 Sep 1998 20:53:58 +0000 (20:53 +0000)]
Modified dev_t and ino_t code to be 64 bit clean (including changes
to oplock break message passing). I think that smbd/nmbd are now
inode and offset size independent (at least for 32 bit and 64 bit
systems).
Now to expose all this new functionality to NT clients.....
Jeremy.
Jeremy Allison [Fri, 4 Sep 1998 16:06:04 +0000 (16:06 +0000)]
Fixed uppercasing of share name (pointed out by Jean-Francois).
Jeremy.
Jeremy Allison [Fri, 4 Sep 1998 00:23:28 +0000 (00:23 +0000)]
More 64 bit stuff - now the fcntl locks are 64 bit clean.
Nearly at the stage where I can expose the 64-bit-ness to
the NT clients....
Jeremy.
Jeremy Allison [Thu, 3 Sep 1998 18:40:31 +0000 (18:40 +0000)]
Ok - this is the 64 bit widening check in. It changes the configure
to check for stat64 and friends, and then changes much of Samba
to use the data type SMB_OFF_T for file size information.
stat/fstat/lstat/lseek/ftruncate have now become sys_stat etc. to hide
the 64 bit calls if needed.
Note that this still does not expose 64 bit functionality to the
client, as the changes to the reply_xxx smb's are not yet done.
This code change should make these changes possible.
Still to do before full 64 bit-ness to the client:
fcntl lock code.
statfs code
widening of dev_t and ino_t (now possible due to SMB_DEV_T and SMB_OFF_T
types being in place).
Let me know if wierd things happen after this check-in and I'll
fix them :-).
Jeremy.
Andrew Tridgell [Thu, 3 Sep 1998 05:37:15 +0000 (05:37 +0000)]
changed the SMBtrans reply code to align at the same alignment as
observed from NT. We were aligning the data before but not the
parameters. This aligns both.
This change may break some other parts of ipc.c if we have relied on
the alignment somewhere, so if you think this broke something then let
me know.
Andrew Tridgell [Thu, 3 Sep 1998 05:35:13 +0000 (05:35 +0000)]
we were setting the strings 1 too long in make_srv_share_info1_str()
Andrew Tridgell [Thu, 3 Sep 1998 03:14:31 +0000 (03:14 +0000)]
fixed a bug in the name mangling code. It implicitly assumed that
mangling a name can't increase it's size which isn't true. (imagine a
file called "L B" which mangles to "LB~XX")
The symptoms were that users couldn't run batch files from short
directory names that contained non 8.3 characters (such as spaces).
Jeremy Allison [Wed, 2 Sep 1998 17:23:41 +0000 (17:23 +0000)]
Fix for PR#9497 - not waiting for child.
Jeremy.
Andrew Tridgell [Wed, 2 Sep 1998 05:00:47 +0000 (05:00 +0000)]
we are never interested in SIGPIPE so just ignore (block) it
always. Don't even install a handler.
Andrew Tridgell [Wed, 2 Sep 1998 02:12:07 +0000 (02:12 +0000)]
changed ref to samba.gif to use /swat/ prefix
Andrew Tridgell [Wed, 2 Sep 1998 02:02:30 +0000 (02:02 +0000)]
use /swat/ prefix in both inetd and cgi modes, to enable a static header.html
Jeremy Allison [Tue, 1 Sep 1998 20:17:16 +0000 (20:17 +0000)]
Missed one struct stat.
Jeremy.
Jeremy Allison [Tue, 1 Sep 1998 20:11:54 +0000 (20:11 +0000)]
More abstraction of file system data types, to move to a 64
bit file interface for the NT SMB's.
Created a new define, SMB_STRUCT_STAT that currently is
defined to be struct stat - this wil change to a user
defined type containing 64 bit info when the correct
wrappers are written for 64 bit stat(), fstat() and lstat()
calls.
Also changed all sys_xxxx() calls that were previously just
wrappers to the same call prefixed by a dos_to_unix() call
into dos_xxxx() calls. This makes it explicit when a pathname
translation is being done, and when it is not.
Now, all sys_xxx() calls are meant to be wrappers to mask
OS differences, and not silently converting filenames on
the fly.
Jeremy.
Andrew Tridgell [Tue, 1 Sep 1998 07:10:44 +0000 (07:10 +0000)]
Matthew is no longer wokring on SWAT
Andrew Tridgell [Tue, 1 Sep 1998 06:03:52 +0000 (06:03 +0000)]
need to istall new files
Andrew Tridgell [Tue, 1 Sep 1998 06:03:03 +0000 (06:03 +0000)]
spruced up SWAT a bit - it now uses the new Samba logo at the top and
a table to give it a little border
Andrew Tridgell [Tue, 1 Sep 1998 06:01:19 +0000 (06:01 +0000)]
fixed a bug in the base64 hanlding that led to auth failures for some
passwords with SWAT
Andrew Tridgell [Tue, 1 Sep 1998 01:10:01 +0000 (01:10 +0000)]
check that a valid pipe is passed before doing a pipe close.
I made this change after getting a segv in reply_pipe_close(). The
funny thing was that pipes_open was 1 and Pipes was NULL. That "can't
happen" and suggests that we have a wild pointer somewhere.
I suspect the rpc code, as I was playing with long share names (a
share called "averylongusername") at the time and the logs show lots
of srvsvc operations. I bet there is a buffer in the rpc code
somewhere that is overflowing and trashing bits of the data segment.
Jeremy Allison [Mon, 31 Aug 1998 20:20:54 +0000 (20:20 +0000)]
configure.in, configure: include/config.h.in: Added stropts and poll.
include/smb.h: Moved old typedefs of uint8 etc. into include/includes.h where
all the other defines live (changed them from typedefs to
defines).
Other changes : changed from using uint32 to SMB_DEV_T and SMB_INO_T
in preparation for moving to size independed (ie. 64 bit clean) device
and inode access. Stat call wrapper comes next :-).
Jeremy.
Christopher R. Hertel [Mon, 31 Aug 1998 14:46:19 +0000 (14:46 +0000)]
I added notes about the changes I've made to 2.0.0. I put the change to
nmbd default behavior (appending to logs instead of overwriting them) into
the "Major Changes" section, but added a "Minor Changes" section for the
things that wouldn't affect the running of Samba itself (eg., the splay
tree for WINS and the change to DEBUG output).
Chris -)-----
Andrew Tridgell [Mon, 31 Aug 1998 09:38:50 +0000 (09:38 +0000)]
I looked at the refresh issue a bit more and discovered that Samba
also doesn't switch to a registration if a refresh fails, instead the
name is removed! This makes it even more imortant that a Samba WINS
server accepts refresh requests as registration requests if the name
is not registered. I've gone ahead and implemented this.
Andrew Tridgell [Mon, 31 Aug 1998 07:23:11 +0000 (07:23 +0000)]
minor fixes to the DMB<->DMB sync code. We now get the dmb name from
the local_master name on the unicast subnet if it is unknown.
Andrew Tridgell [Mon, 31 Aug 1998 07:21:54 +0000 (07:21 +0000)]
if an address is ipzero in cli_connect() then do a name query
Andrew Tridgell [Mon, 31 Aug 1998 06:59:23 +0000 (06:59 +0000)]
I realised that my DMB<->DMB sync code has the property that the
amount of network traffic grows as the square of the number of
workgroups. It probably wouldn't have caused problems but to be safe I
changed the code to use random() to decrease the probability of a
DMB<->DMB sync in proportion to the number of known workgroups. This
keeps the nice browse connectivity while making the traffic rise only
linearly with the number of workgroups.
Samba Release Account [Mon, 31 Aug 1998 05:26:18 +0000 (05:26 +0000)]
preparing for release of 2.0.0 alpha 1
Samba Release Account [Mon, 31 Aug 1998 05:23:33 +0000 (05:23 +0000)]
preparing for release of 2.0.0 alpha
Andrew Tridgell [Mon, 31 Aug 1998 05:21:39 +0000 (05:21 +0000)]
fixed a comment
Andrew Tridgell [Mon, 31 Aug 1998 05:21:09 +0000 (05:21 +0000)]
updated the WHATSNEW in preparation for an alpha release
Andrew Tridgell [Mon, 31 Aug 1998 04:19:31 +0000 (04:19 +0000)]
set a maximum name refresh time of 20 minutes.
The previous code was strictly correct, but not very practical. self
names were only refreshed every 3 days. I hit a situation where the
Samba WINS server was restarted after deleting wins.dat and didn't
notice some remote subnets (also running Samba). I realised that the
complete database wouldn't have been rebuilt for 3 days, which is way
too long. In order to recover from WINS restarts we need a much
shorter maximum refresh time.
Andrew Tridgell [Mon, 31 Aug 1998 03:13:20 +0000 (03:13 +0000)]
cast the qsort to prevent warnings
Andrew Tridgell [Mon, 31 Aug 1998 03:11:42 +0000 (03:11 +0000)]
bounds check next_token() to prevent possible buffer overflows
Andrew Tridgell [Sun, 30 Aug 1998 17:04:24 +0000 (17:04 +0000)]
added a dest_port parameter to send_mailslot() so we send replies to
the correct port in environments like ip masq.
Andrew Tridgell [Sun, 30 Aug 1998 16:33:48 +0000 (16:33 +0000)]
a couple of debug lines
Andrew Tridgell [Sun, 30 Aug 1998 15:58:17 +0000 (15:58 +0000)]
finished the asynchronous browse synchronisation code. It even seems
to work (not a lot of testing yet though).
Now we just need to deal with people worried about having more than
two nmbd processes sometimes. (the async processes are created on
demand for browse sync, so you'll only see more than 2 occasionally)
Andrew Tridgell [Sun, 30 Aug 1998 12:32:45 +0000 (12:32 +0000)]
This should fix the zombie problem that luke noticed.
Andrew Tridgell [Sun, 30 Aug 1998 09:50:45 +0000 (09:50 +0000)]
we we have successfully done a query on *<1b> from a wins server and
then obtained a node status response we need to remember the server
name of the master browser so that other browse clients asking us for
a workgroup list will get a entry for the master of that workgroup.
Andrew Tridgell [Sun, 30 Aug 1998 08:45:23 +0000 (08:45 +0000)]
changed the way that name query records are sorted in replies. They
are now sorted by the number of common leading bits in the IP address
with the address of the querying host.
Andrew Tridgell [Sun, 30 Aug 1998 06:49:14 +0000 (06:49 +0000)]
include our netbios names list and our workgroup in the wins.dat hash
Andrew Tridgell [Sun, 30 Aug 1998 05:57:21 +0000 (05:57 +0000)]
don't put two spaces at the start of lines if logging to stdout
or not timestamping.
Andrew Tridgell [Sun, 30 Aug 1998 05:43:59 +0000 (05:43 +0000)]
changed the format of the wins.dat file slightly.
It now has a line like this:
VERSION 1 251152
the first number is a version #define in nmbd_winsserver.c and will be
used if we ever have to change the format again.
The second number is a hash of the current interfaces setting. It is
used to detect the case where nmbd is restarted on a machine after the
IP of the machine has changed (or the interfaces list has changed in
any way). When that happens we need to discard the old wins.dat cache
or you end up with chaos. This has bitten quite a few people, they
find that when they move a machine it continues using the old IP for
some things for the next week until the wins entries time out!
I've checked, and the old nmbd can handle the new format, although it
does spit out a spurious error message about the VERSION line. So
users can safely run 2.0alpha then switch back to 1.9.18 without
problems.
Andrew Tridgell [Sun, 30 Aug 1998 04:37:07 +0000 (04:37 +0000)]
allow smbclient to connect to IPC$ as an IPC service
Andrew Tridgell [Sun, 30 Aug 1998 04:35:54 +0000 (04:35 +0000)]
- zero shared memory before freeing it
- changed the hash size to 13 (much smaller than before). This should
make for more efficient shared memory usage as it will lead to less
fragmentation.
Andrew Tridgell [Sun, 30 Aug 1998 04:31:55 +0000 (04:31 +0000)]
added a function zero_free(void *, int size) that zeros an area of
memory then frees it. Useful for catching bugs.
Andrew Tridgell [Sun, 30 Aug 1998 04:30:57 +0000 (04:30 +0000)]
changed the size of a char array in the userdata_struct from 1 to 16
to account for padding/alignment issues. Eventually I'd like to find a
way to get rid of this construct altogether as it is a bit error
prone and hard to debug.
also added a new macro:
ZERO_STRUCTP() that takes a pointer to a structure and zeros the
structure. Used in nmbd to zero allocated structures before freeing
them to try to catch bugs a bit faster.
Andrew Tridgell [Sun, 30 Aug 1998 04:27:26 +0000 (04:27 +0000)]
added some defensive programming to nmbd. This mostly means zeroing
areas of memory before freeing them.
While doing this I also found a couple of real bugs. In two places we
were freeing some memory that came from the stack, which leads to
a certain core dump on many sytems.
Andrew Tridgell [Sat, 29 Aug 1998 14:08:17 +0000 (14:08 +0000)]
got rid of calls to update_protected_database(). It was causing core
dumps. It is gone until someone can tell us why its needed and what it
does. (It was only used on OSF1 and core dumped there anyway!)
Andrew Tridgell [Sat, 29 Aug 1998 03:10:39 +0000 (03:10 +0000)]
don't exit on a SIGPIPE
Jeremy Allison [Fri, 28 Aug 1998 21:46:29 +0000 (21:46 +0000)]
This checking fixes the statcache bug that stopped NetBench from running
correctly. Added new parameter "stat cache size" - set to 50 by default.
I now declare the statcache code officially "open" for business :-).
It gets a hit rate of 97% with a NetBench run and seems to make
using a case insensitive run as efficient as a case sensitive run.
Also tidied up our sys_select usage - added a maxfd parameter and
also added an implementation of select in terms of poll(), for systems
where poll() is much faster. This is disabled by default.
Jeremy.
Andrew Tridgell [Fri, 28 Aug 1998 14:35:24 +0000 (14:35 +0000)]
nmbd would core dump if a large number of netbios aliases is set. The
problem was a buffer overflow in process_node_status_request().
this really points out a general problem is allocating MAX_DGRAM_SIZE
packets on the stack in nmbd. There must be a better way.
Jeremy Allison [Thu, 27 Aug 1998 20:51:12 +0000 (20:51 +0000)]
Fixed stat cache statistics calculation. Oops.
Jeremy.
Jeremy Allison [Thu, 27 Aug 1998 20:38:53 +0000 (20:38 +0000)]
This is the stat cache code - seems to work fine (needs heavy
NetBench testing though.... :-). Attempts to efficiently reduce
the number of stat() calls Samba does.
Jeremy.
Luke Leighton [Wed, 26 Aug 1998 14:05:23 +0000 (14:05 +0000)]
oops - added /usr/include/rpc includes.
Andrew Tridgell [Wed, 26 Aug 1998 03:06:48 +0000 (03:06 +0000)]
use a separate ZERO_ARRAY() macro instead of ZERO_STRUCT() for
arrays. This prevents (harmless) warnings from some compilers
Andrew Tridgell [Wed, 26 Aug 1998 02:36:27 +0000 (02:36 +0000)]
get includes right for systems that use getpwanam()
Andrew Tridgell [Wed, 26 Aug 1998 02:02:55 +0000 (02:02 +0000)]
took all the rpc includes back out until we can work out _why_ freebsd
needs them and what should really be there.