cvs2svn Import User [Wed, 9 Aug 2000 16:50:31 +0000 (16:50 +0000)]
This commit was manufactured by cvs2svn to create tag
'release-alpha-2-6'.
Samba Release Account [Wed, 9 Aug 2000 16:50:30 +0000 (16:50 +0000)]
preparing for release of alpha-2.6
Elrond [Tue, 8 Aug 2000 18:21:15 +0000 (18:21 +0000)]
debuglevel from 0 to 3 for the race-warnings
as requested by Jens.
Someone should realy examine the code...
But I don't want to now.
Elrond [Tue, 8 Aug 2000 16:42:41 +0000 (16:42 +0000)]
merge from HEAD.
Tim Potter [Mon, 7 Aug 2000 21:27:10 +0000 (21:27 +0000)]
Check the results of cli_read_one() before calling prs_append_data() in
cli_rcv_pdu(). If the network is down it may return -1.
Elrond [Sat, 5 Aug 2000 18:30:05 +0000 (18:30 +0000)]
load.c is now in sync.
nt_printing.c: Simple merges (free -> safe_free, etc)
printing.c: simple things and the varargs run_print_cmd
Elrond [Sat, 5 Aug 2000 17:29:26 +0000 (17:29 +0000)]
more merge from HEAD.
parse_dfs.c,rpc_dfs.h are nearly completely in sync now.
parse_spoolss.c still misses some stuff (memory related)
Elrond [Sat, 5 Aug 2000 16:14:52 +0000 (16:14 +0000)]
make proto
talloc.h from HEAD
Elrond [Sat, 5 Aug 2000 16:10:57 +0000 (16:10 +0000)]
init_unistr2_from_unistr for TNG.
Elrond [Sat, 5 Aug 2000 13:37:03 +0000 (13:37 +0000)]
Trying a little merge.
- some reformatting
- some memory-leaks
- some prs_align
Elrond [Sat, 5 Aug 2000 12:08:43 +0000 (12:08 +0000)]
lookup_added_user_rids isn't used anywhere, made it static
Elrond [Sat, 5 Aug 2000 12:04:14 +0000 (12:04 +0000)]
removing unnecessary includes/externs.
Elrond [Sat, 5 Aug 2000 11:50:29 +0000 (11:50 +0000)]
The smb_passwd_ops struct got a getsamseqnum function
prepended and someone only added a function for the
smbpasswd-backend...
I added a fallback to time(NULL) for it and prepended NULL
to both LDAP-backend structs.
Hope, this fixes a bunch of ldap problems.
Tim Potter [Thu, 3 Aug 2000 01:25:40 +0000 (01:25 +0000)]
Typos.
Tim Potter [Thu, 3 Aug 2000 01:21:16 +0000 (01:21 +0000)]
Missing file.
Tim Potter [Thu, 3 Aug 2000 01:20:22 +0000 (01:20 +0000)]
Tests for passing long arguments to nsswitch functions.
Tim Potter [Thu, 3 Aug 2000 01:15:27 +0000 (01:15 +0000)]
Added proc for making executables from single C files.
Tim Potter [Thu, 3 Aug 2000 01:06:01 +0000 (01:06 +0000)]
Fixed buffer overrun bugs in calls to slprintf().
The rule is use slprintf() and sizeof(buf) - 1 or snprintf and sizeof(buf).
Elrond [Tue, 1 Aug 2000 16:01:10 +0000 (16:01 +0000)]
merge
Elrond [Mon, 31 Jul 2000 18:09:39 +0000 (18:09 +0000)]
Documentation update from Matthew Geddes
<mgeddes@mail.xavier.sa.edu.au>:
updated createuser, samuserset and samuserset2 with realy
useful info.
[-L is not completely right AFAIK.]
Tim Potter [Mon, 31 Jul 2000 05:11:56 +0000 (05:11 +0000)]
Test to check all members of a domain group contain the domain name.
Tim Potter [Mon, 31 Jul 2000 05:11:25 +0000 (05:11 +0000)]
Fix to domain aliases crash didn't prepend the domain name to group
members.
Tim Potter [Fri, 28 Jul 2000 04:34:43 +0000 (04:34 +0000)]
Test all domain users and groups rather than just default ones.
Tim Potter [Fri, 28 Jul 2000 04:31:27 +0000 (04:31 +0000)]
Test all domain users rather than just default ones.
Tim Potter [Fri, 28 Jul 2000 04:01:20 +0000 (04:01 +0000)]
Cut down version of getent for systems which don't have it. This version
only returns passwd and group database entries and seems to compile on most
systems without too much fuss:
gcc -o getent getent.c
Tim Potter [Fri, 28 Jul 2000 03:56:28 +0000 (03:56 +0000)]
Return untested for the nsswitch memory leak tests as they don't run very
well automatically. )-:
Tim Potter [Thu, 27 Jul 2000 22:31:42 +0000 (22:31 +0000)]
Fixed crash bug when enumerating domain aliases which we shouldn't have
been doing anyway. This allowed for some serious refactoring of the group
membership code. It's much simpler now. (Oops - forgot to check this in
for a day or two... )-:)
Tim Potter [Mon, 24 Jul 2000 07:03:48 +0000 (07:03 +0000)]
Undid sighup reload fixes in TNG - signal handling is too different from
HEAD here.
Tim Potter [Mon, 24 Jul 2000 06:33:27 +0000 (06:33 +0000)]
Merge from HEAD.
Elrond [Thu, 20 Jul 2000 17:34:11 +0000 (17:34 +0000)]
LSA_SID_GET_PRIVS client-side:
This shows the privileges/rights, that are assigned to a
specific SID by LSA.
Try "lsaenumsids -p" as admin on an nt-box.
xx->data_size -> prs_data_size(xx)
xx->offset -> prs_offset(xx)
Elrond [Wed, 19 Jul 2000 18:30:18 +0000 (18:30 +0000)]
lsa-server-side:
_lsa_enum_trusted_doms now works and returns the full list
of domains, that samba is trusting, now winlogon on
the clients even shows the trusted domain
_lsa_open_trusted_domain: this is used, when a trusted
domain is removed from usrmgr.exe, so I added a
complete serverside version
_lsa_delete_object: While playing more with this, found out
about this and added a complete fake implementation
on the server side (it's nearly identical with
_lsa_close), so clients believe, the delete was
successful. ;)
I've also added the opcode for LSA_DELETE, which seems to
be an older version of LSA_DELETE_OBJECT, since it is tried
by usrmgr, when LSA_DELETE_OBJECT does not exist.
Elrond [Wed, 19 Jul 2000 18:20:27 +0000 (18:20 +0000)]
Return the trusted domains in upper case
Elrond [Wed, 19 Jul 2000 18:18:02 +0000 (18:18 +0000)]
return False; -> return NULL;
Tim Potter [Wed, 19 Jul 2000 05:29:33 +0000 (05:29 +0000)]
Fixed some error messages.
Initialise some variables in winbindd_getpwent()
Fixed buffer overrun bug when enumerating large numbers of users.
Tim Potter [Wed, 19 Jul 2000 01:04:29 +0000 (01:04 +0000)]
Uninitialised variable.
Elrond [Tue, 18 Jul 2000 18:35:12 +0000 (18:35 +0000)]
I like the new lists, so I start by adding the header to
TNG. (more next)
cvs2svn Import User [Tue, 18 Jul 2000 05:16:31 +0000 (05:16 +0000)]
This commit was manufactured by cvs2svn to create branch 'SAMBA_TNG'.
Gerald Carter [Tue, 18 Jul 2000 05:16:30 +0000 (05:16 +0000)]
Fixed some more client SPOOLSS functions. The following
functions work now:
- spoolenum
- spoolopen
- spoolgetprinter
- spoolgetprinterdriver
Items todo:
- track down memory bug with spoolenumdata
- fix spoolgetprinterdriverdir
- fix spoolgetdata
- fix display_job_info_ctr in spooljobs
All part of the ongoing rpcclient work.
Also included a new generic list ADT. Cleaner and simplier
than the stuff in util_array.c i think (but then that's why I wrote it).
--jerry
Gerald Carter [Tue, 18 Jul 2000 05:13:44 +0000 (05:13 +0000)]
fixed a bug (my own) in create_ntc_from_cli_state()
--jerry
Gerald Carter [Tue, 18 Jul 2000 05:12:49 +0000 (05:12 +0000)]
I really didn't like the way generic arrays (lists) were
implemented in util_array.c so I wrote a smaller (and simplier
package).
I would like to replace the use of util_array.c functions
in the rest of the source tree if no one objects.
This will be an interface change, but not really a difference
in the functionality provided.
--jerry
Gerald Carter [Tue, 18 Jul 2000 05:10:26 +0000 (05:10 +0000)]
grab functions that return RPC_HND_NODE (declared
in include/util_list.h)
-- jerry
Gerald Carter [Tue, 18 Jul 2000 05:07:28 +0000 (05:07 +0000)]
Fixed some more client SPOOLSS functions. The following
functions work now:
- spoolenum
- spoolopen
- spoolgetprinter
- spoolgetprinterdriver
Items todo:
- track down memory bug with spoolenumdata
- fix spoolgetprinterdriverdir
- fix spoolgetdata
- fix display_job_info_ctr in spooljobs
All part of the rpcclient work.
Jeremy, this check includes emthods for associating
POLICY_HNDs and client states. See the RpcHndList_...()
function calls (implemented in lib/util_list.c)
--jerry
Gerald Carter [Tue, 18 Jul 2000 05:02:16 +0000 (05:02 +0000)]
Fixed some more SPOOLSS functions. The following
functions work now:
- spoolenum
- spoolopen
- spoolgetprinter
- spoolgetprinterdriver
Items todo:
- track down memory bug with spoolenumdata
- fix spoolgetprinterdriverdir
- fix spoolgetdata
- fix display_job_info_ctr in spooljobs
--jerry
Tim Potter [Tue, 18 Jul 2000 00:13:13 +0000 (00:13 +0000)]
Minor reformatting.
Tim Potter [Mon, 17 Jul 2000 06:04:23 +0000 (06:04 +0000)]
Missing var.
Tim Potter [Mon, 17 Jul 2000 05:40:48 +0000 (05:40 +0000)]
Reverted changes from rpcclient merge - contains memory leak!
Tim Potter [Mon, 17 Jul 2000 05:38:26 +0000 (05:38 +0000)]
Free security descriptor after access check in update_printer_sec()
Tim Potter [Mon, 17 Jul 2000 05:37:16 +0000 (05:37 +0000)]
Initialise current time to time(NULL) in add_a_printer_2()
Added get and free security old descriptor in nt_printing_setsec() after
access checking was moved up to rpc level.
Tim Potter [Mon, 17 Jul 2000 03:13:06 +0000 (03:13 +0000)]
make proto
Tim Potter [Mon, 17 Jul 2000 02:43:12 +0000 (02:43 +0000)]
make proto
Tim Potter [Mon, 17 Jul 2000 02:42:25 +0000 (02:42 +0000)]
Allow job owner to delete own print job.
Tim Potter [Mon, 17 Jul 2000 02:41:38 +0000 (02:41 +0000)]
Moved access check for nt_printing_setsec() up into rpc function.
Use sid + rid instead of lp_workgroup()/Administrator for printer owner sid
as per JF's advice.
Default printer owner is either the administrator of the pdc workgroup or
Everyone depending on whether winbindd is running. Still the subject of
some debate...
Renamed se_access_check() parameters.
Tim Potter [Mon, 17 Jul 2000 02:38:43 +0000 (02:38 +0000)]
Renamed arguments to se_access_check()
Tim Potter [Mon, 17 Jul 2000 02:37:11 +0000 (02:37 +0000)]
Renamed a parameter in init_request() function.
Initialise response structure correctly.
Tim Potter [Mon, 17 Jul 2000 02:36:19 +0000 (02:36 +0000)]
Added some debugs.
Changed interface to se_access_check to take a user struct instead of each
bit as a separate parameter.
Christopher R. Hertel [Sat, 15 Jul 2000 20:57:24 +0000 (20:57 +0000)]
I committed this change to the cliffs archive a while back and have heard
no complaints. ;)
Basically, instead of ignoring single-line C-style comments in IDL source
files this change allows token.awk to ignore both single- and multi-line
C-style comments.
Chris -)-----
Elrond [Sat, 15 Jul 2000 18:59:51 +0000 (18:59 +0000)]
Moved more functions from clientgen.c around like in HEAD.
This time moved out the stuff for clireadwrite.c and
clirap.c.
Also reordered these objects in Makefile.in to be more like
in HEAD.
Elrond [Sat, 15 Jul 2000 18:56:56 +0000 (18:56 +0000)]
merge from HEAD.
Gerald Carter [Sat, 15 Jul 2000 08:44:42 +0000 (08:44 +0000)]
Fixed some errors in ncacn_np_find() which were the result
of misordered comparse blocks.
--jerry
Gerald Carter [Sat, 15 Jul 2000 08:37:17 +0000 (08:37 +0000)]
Lots of changes but no real progress in functionality.
more changes to remove the ncarpc_l_* stuff.
Fixed some cut and paste errors from TNG
There are very subtle bugs in this code. I'll work on simplifying
them in round two or three.
--jerry
Gerald Carter [Sat, 15 Jul 2000 08:33:43 +0000 (08:33 +0000)]
reverted a some previous additions.
Removed msrpc_local struct
--jerry
Elrond [Fri, 14 Jul 2000 17:41:38 +0000 (17:41 +0000)]
Added a prefix-param to out_data, so the output can be
indented.
Used it in querysecret to show more of the secret (all of
it, the "password" itself, the owf for the pw)
While playing with setsecret, I noticed, that one may only
use "password"s which have a length, that is a multiple of
4. The problem is the encryption/decryption-function. I've
no idea, what the solution would be.
Elrond [Fri, 14 Jul 2000 17:29:17 +0000 (17:29 +0000)]
Added an unsigned in the right place, so the base64-display
routines show =FF instead of =
FFFFFFFF.
Gerald Carter [Fri, 14 Jul 2000 17:04:57 +0000 (17:04 +0000)]
a few changes to Makefile.in to clean up dependencies for rpcclient
--jerry
Gerald Carter [Fri, 14 Jul 2000 17:04:04 +0000 (17:04 +0000)]
More functions merged from TNG for rpcclient. They don't all work
currently as I have to do something about the policy handle caching
issues.
--jerry
Gerald Carter [Fri, 14 Jul 2000 17:01:49 +0000 (17:01 +0000)]
cleaned up access to prs_struct variables. Replaced all calls
prs_free_data() => prs_mem_free
prs_realloc_data => prs_grow
--jerry
Gerald Carter [Fri, 14 Jul 2000 16:59:41 +0000 (16:59 +0000)]
removed references to loopback RPC connections.
added a few more kfunctions from TNG for rpcclient
--jerry
Gerald Carter [Fri, 14 Jul 2000 16:58:03 +0000 (16:58 +0000)]
removed prs_data(), prs_free_data(), and prs_realloc_data()
as these were unneeded and replaced by the real functions
already in HEAD.
Added a few more functions to parse_spoolss.c to help with the
rpcclient merge from TNG.
Gerald Carter [Fri, 14 Jul 2000 16:54:07 +0000 (16:54 +0000)]
Fixed a bug in cmd_interp.c where if user%pass was entered on
the command line, the password would still be cached in memory
in plain text for the lifetime of the rpcclient command line session.
removed loopback connection functions from msrpc-client.c since
we don't support that in the server code now anyways. simplify,
simplify, ...
--jerry
Gerald Carter [Fri, 14 Jul 2000 16:31:06 +0000 (16:31 +0000)]
make proto
and a few changes to ntdomain for rpcclient printing functions
--jerry
Gerald Carter [Fri, 14 Jul 2000 16:29:22 +0000 (16:29 +0000)]
adding more spoolss command into rpcclient. They don't all work
currently. More to come later.
--jerry
Gerald Carter [Thu, 13 Jul 2000 20:02:57 +0000 (20:02 +0000)]
In cli_use_free(), don;t attempt to logoff if
there is no valid socket descriptor. This fix prevents
core dumps when a name cannot be resolved.
jerry
Gerald Carter [Thu, 13 Jul 2000 19:59:23 +0000 (19:59 +0000)]
when using user%password syntax form the command line, the password
clear text was remaining in memory for the life of the rpcclient
command line session. See the handling of the -U switch
for details.
jerry
Elrond [Thu, 13 Jul 2000 16:06:34 +0000 (16:06 +0000)]
include/
moved one struct from ntdomain.h to rpc_netsec.h,
which now is only needed by rpc_parse.h.
cmd_interp.c:
Replaced get_safe_nt_error_msg with
get_nt_error_msg
util_status.c:
Removed unused vars
srv_lsa_samdb.c:
#if 0'ed unused functions
msrpcd_process.c, srv_pipe_hnd.c:
removed unused externs
reformatted a little
made some function static
cmd_netlogon.c:
Next function to return uint32
Volker Lendecke [Thu, 13 Jul 2000 11:26:34 +0000 (11:26 +0000)]
Uninitialized variables.
regenum endlessly looped on unknown keys.
Tim Potter [Thu, 13 Jul 2000 07:04:07 +0000 (07:04 +0000)]
Updated test to process all groups not just default ones.
Tim Potter [Thu, 13 Jul 2000 07:01:46 +0000 (07:01 +0000)]
Updated test to test all domain users instead of just default ones.
Tim Potter [Thu, 13 Jul 2000 06:53:08 +0000 (06:53 +0000)]
Made test run against any trusted domains found.
Tim Potter [Thu, 13 Jul 2000 06:35:42 +0000 (06:35 +0000)]
Run consistency tests on all users on all trusted domains rather than just
the default NT names.
Tim Potter [Thu, 13 Jul 2000 04:35:48 +0000 (04:35 +0000)]
Implemented check trust account password function to winbindd and wbinfo.
Tim Potter [Thu, 13 Jul 2000 04:33:25 +0000 (04:33 +0000)]
Don't return winbind groups or users when responding to samr_enum_dom_users
and samr_enum_dom_aliases commands. Unfortunately the algorithm for
determining winbind groups from normal groups is simply to check for the
presence of the lp_winbind_separator() character. )-:
Tim Potter [Thu, 13 Jul 2000 01:21:21 +0000 (01:21 +0000)]
Uninitialised variables.
Jean-François Micouleau [Wed, 12 Jul 2000 16:11:33 +0000 (16:11 +0000)]
we are now sure the printer_info_2 timestamp is updated everytime
required.
J.F.
Jean-François Micouleau [Wed, 12 Jul 2000 14:10:40 +0000 (14:10 +0000)]
- The printers are indexed by the sharename in both get_a_printer() and
add_a_printer() now.
- correctly unpack the private part of a devmode and remove a memleak
- correctly retrieve the pair(value,data) for getprinterdata
- handle null devicemode in printer_info_2
I still have some bugs but I'm not crashing anymore NT4SP6 d/c build :-)
J.F.
Tim Potter [Wed, 12 Jul 2000 04:50:05 +0000 (04:50 +0000)]
The SID_NAME_DOMAIN constant is the sid returned when domain names are
looked up with lsa_lookup_names()
Christopher R. Hertel [Wed, 12 Jul 2000 04:25:12 +0000 (04:25 +0000)]
An improved version of the Negative Query Response fix. The earlier fix
only did a short-cut on an rcode of 3, which is 'name not found'. This
does a short-cut on any non-zero rcode. It also puts out a DEBUG message
(if DEBUGLEVEL is >= 3) detailing the error.
Chris -)-----
Tim Potter [Wed, 12 Jul 2000 04:13:58 +0000 (04:13 +0000)]
A tip from JF. Use sid + DOMAIN_GROUP_RID_USERS instead of "Domain Users"
for determining primary group membership.
Christopher R. Hertel [Wed, 12 Jul 2000 03:51:06 +0000 (03:51 +0000)]
Typo. It said "DEGUG" in the comments. I dunno how to degug, or gug for
that matter. crh
Tim Potter [Wed, 12 Jul 2000 01:59:43 +0000 (01:59 +0000)]
make proto
Tim Potter [Wed, 12 Jul 2000 01:51:02 +0000 (01:51 +0000)]
When clearing connections on network errors, only kill the connection that
is dead not all of them.
Spelling fixes.
Tim Potter [Wed, 12 Jul 2000 01:47:36 +0000 (01:47 +0000)]
Return success for listing users and groups if a trusted domain could not
be contacted.
Tim Potter [Wed, 12 Jul 2000 01:46:02 +0000 (01:46 +0000)]
Always return name type = SID_NAME_DOM_GRP in winbindd_gid_to_sid()
Tim Potter [Wed, 12 Jul 2000 01:44:43 +0000 (01:44 +0000)]
Check winbindd_request() return values against NSS_* instead of WINBINDD_*
Renamed list users and list groups fns.
Tim Potter [Wed, 12 Jul 2000 01:43:08 +0000 (01:43 +0000)]
Initialise return value for response structure.
Renamed param in init_request()
Tim Potter [Wed, 12 Jul 2000 01:41:32 +0000 (01:41 +0000)]
Re-use smb connections properly in ncacn_np_use_free()
Print out host as well as pipe names in debug messages.
Memory leaks in ncacn_np_initialise() and ncacn_np_use_free()
Cut & paste bug in ncacn_np_use_del()
Tim Potter [Wed, 12 Jul 2000 01:37:59 +0000 (01:37 +0000)]
Fixed memory leak in cli_con_get()
Re-use smb connections properly in cli_connection_free() instead of
shutting them down.
Tim Potter [Wed, 12 Jul 2000 01:36:01 +0000 (01:36 +0000)]
Fixed debug in cli_establish_connection() to print correct destination
hostname.
Tim Potter [Wed, 12 Jul 2000 01:34:55 +0000 (01:34 +0000)]
Ensure generate_and_add_sids() is not called twice to avoid memory leaks.
Elrond [Tue, 11 Jul 2000 18:24:53 +0000 (18:24 +0000)]
merge from HEAD
Gerald Carter [Tue, 11 Jul 2000 16:28:59 +0000 (16:28 +0000)]
#ifndef RPCCLIENT_TEST
use old prs_unistr()
#else
use new prs_unistr() which handles UNMARSHALL
#endif /* RPCCLIENT_TEST */
jerry