From ba04400d01c6ad05651672e087527391da7fdaf4 Mon Sep 17 00:00:00 2001 From: "Christopher R. Hertel" Date: Thu, 29 Aug 2013 16:58:16 -0500 Subject: [PATCH] vfs_glusterfs: Fix excessive debug output from vfs_gluster_open(). The vfs_gluster_open() function generates a debug message (at level 0) for every failed attempt to open a pathname. This includes cases in which attempts are made to open a directory as a file (those attempts are retried calling vfs_gluster_opendir()). The result is that the log file fills with messages about failed attempts to open directories, just because they are directories. This latest version, of the patch completely removes logging from the vfs_gluster_open() function. The error code returned is handled in upper layers, and the open function in the default VFS module does not log any errors. Signed-off-by: Christopher R. Hertel Reviewed-by: susant palai Reviewed-by: raghavendra talur Reviewed-by: Jose A. Rivera Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Fri Aug 30 02:43:48 CEST 2013 on sn-devel-104 --- source3/modules/vfs_glusterfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c index eac1b240c3f..237236a1df9 100644 --- a/source3/modules/vfs_glusterfs.c +++ b/source3/modules/vfs_glusterfs.c @@ -481,11 +481,8 @@ static int vfs_gluster_open(struct vfs_handle_struct *handle, } if (glfd == NULL) { - DEBUG(0, ("glfs_{open[dir],creat}(%s) failed: %s\n", - smb_fname->base_name, strerror(errno))); return -1; } - return glfd_fd_store(glfd); } -- 2.34.1