Günther Deschner [Wed, 18 Mar 2009 21:49:41 +0000 (22:49 +0100)]
s3: remove POLICY_HND.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:09:57 +0000 (15:09 +0100)]
s3-rpc_parse: remove some unused parsing code.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:54:26 +0000 (21:54 +0100)]
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:36:40 +0000 (21:36 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:22:22 +0000 (12:22 +0100)]
s3-rpc_parse: remove unused BUFFER5 and UNISTR3.
Guenther
Günther Deschner [Wed, 18 Mar 2009 17:10:01 +0000 (18:10 +0100)]
s3-rpc_client: remove unused CLI_DO_RPC_WERR macro.
Guenther
Zach Loafman [Wed, 18 Mar 2009 17:36:59 +0000 (10:36 -0700)]
s4 libcli: Add back Longhorn beta dialect as a constant
Also tweak how the dialect array and count is initialized.
Günther Deschner [Wed, 18 Mar 2009 16:45:30 +0000 (17:45 +0100)]
s3-smbcontrol: use correct PRINTER_NOTIFY flags.
Guenther
Günther Deschner [Wed, 25 Feb 2009 13:33:59 +0000 (14:33 +0100)]
spoolss: add my copyright.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:38:36 +0000 (16:38 +0100)]
s3-spoolss: remove include/rpc_spoolss.h.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:45:35 +0000 (00:45 +0100)]
s3-spoolss: remove rpc_server/srv_spoolss.c alltogether.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:43:31 +0000 (00:43 +0100)]
s3-spoolss: remove rpc_parse/parse_spoolss.c alltogether.
Good-Bye, last hand-marshalled rpc functions, rest in peace.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:41:47 +0000 (00:41 +0100)]
s3-spoolss: remove old spoolss_EnumPrinterDataEx.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:40 +0000 (00:38 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:37:33 +0000 (16:37 +0100)]
s3-spoolss: use printer and job notify enums provided by idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:16:25 +0000 (16:16 +0100)]
s3-spoolss: fix spoolss server after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:52 +0000 (16:10 +0100)]
s3-rpcclient: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:11 +0000 (16:10 +0100)]
s4-smbtorture: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:06:40 +0000 (16:06 +0100)]
spoolss: add custom ndr_print_spoolss_Field.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:48 +0000 (15:48 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:06 +0000 (15:48 +0100)]
spoolss: make spoolss_Field a nodiscriminant union of 2 sets of notify flag enums.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:05:44 +0000 (15:05 +0100)]
s3-rpc_parse: move prs_uint64 to rpc_parse/parse_prs.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 12:22:51 +0000 (13:22 +0100)]
s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:46:40 +0000 (12:46 +0100)]
s3-printing: use marshall/unmarshall_sec_desc_buf in sec_desc_upg_fn().
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:25:15 +0000 (11:25 +0100)]
s3-spoolss: add registry_value_to_printer_enum_value.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:22:11 +0000 (11:22 +0100)]
s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:11:05 +0000 (11:11 +0100)]
spoolss: add ndr_size_spoolss_EnumPrinterDataEx_info in spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:10:25 +0000 (11:10 +0100)]
spoolss: rename NDR_SPOOLSS_SIZE_ENUM macro to NDR_SPOOLSS_SIZE_ENUM_LEVEL in
spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:00:37 +0000 (03:00 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey callers in RPC-SPOOLSS-WIN test.
Kai, please check.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:11:37 +0000 (03:11 +0100)]
spoolss: fix ndr_push_spoolss_EnumPrinterDataEx.
Guenther
Stefan Metzmacher [Mon, 16 Mar 2009 16:27:30 +0000 (17:27 +0100)]
s3:winbindd: accept new connections via fd events
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:14:20 +0000 (16:14 +0100)]
s3:winbindd: move non event related code out of process_loop() in the the caller
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:06:12 +0000 (16:06 +0100)]
s3:winbindd: remove unused close_winbindd_socket() function
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:55:39 +0000 (15:55 +0100)]
s3:smbd: use tevent_loop_once() in the parent event loop
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:47:57 +0000 (15:47 +0100)]
s3:printing: use tevent_loop_wait() instead of manual looping
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:56:11 +0000 (14:56 +0100)]
s3:printing: use a fd event to monitor the pipe to the parent
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:48:40 +0000 (14:48 +0100)]
s3:smbd: don't exit the parent when we have no connections
This code path can't really happen anymore, because
launchd support was removed with commit
e5a951325a6cac8567af3a66de6d2df577508ae4.
But it's confusing to have that code there...
metze
Günther Deschner [Wed, 18 Mar 2009 01:33:18 +0000 (02:33 +0100)]
s3-spoolss: use rpccli_spoolss_enumprinterdataex in ldap_printer.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:39:49 +0000 (01:39 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterDataEx tests.
sorry, I could swear this did compile...
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:01 +0000 (00:38 +0100)]
s3-spoolss: remove old rpccli_spoolss_enumprinterdataex.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:06:22 +0000 (01:06 +0100)]
s3-net: use rpccli_spoolss_enumprinterdataex.
Guenther
Günther Deschner [Tue, 17 Mar 2009 22:45:16 +0000 (23:45 +0100)]
s3-rpcclient: use rpccli_spoolss_enumprinterdataex wrapper.
Guenther
Günther Deschner [Tue, 17 Mar 2009 22:39:00 +0000 (23:39 +0100)]
s3-spoolss: add rpccli_spoolss_enumprinterdataex convenience wrapper.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:35:44 +0000 (00:35 +0100)]
spoolss: add ndr_push/pull_spoolss_EnumPrinterDataEx helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:08:38 +0000 (01:08 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:36:31 +0000 (00:36 +0100)]
spoolss: add spoolss_EnumPrinterDataEx triple call.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:07:49 +0000 (01:07 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:36:54 +0000 (00:36 +0100)]
spoolss: fix spoolss_PrinterEnumValues w.r.t. size calculation of PrinterData.
Guenther
Alexander Zagrebin [Tue, 17 Mar 2009 22:38:33 +0000 (15:38 -0700)]
Missing break in conversion function prevents tdb password database update.
Timur [Tue, 17 Mar 2009 21:46:53 +0000 (22:46 +0100)]
build: fix detection of netinet/ip.h on FreeBSD
Signed-off-by: Michael Adam <obnox@samba.org>
Timur [Tue, 17 Mar 2009 21:45:28 +0000 (22:45 +0100)]
build: format the header check for netinet/ip.h more nicely
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Tue, 17 Mar 2009 21:53:06 +0000 (14:53 -0700)]
Remove the global "struct cm_cred_struct" and associated calls, make
callers pass in a struct user_auth_info * instead. This commit causes
smbc_set_credentials() to print out a message telling callers to use
smbc_set_credentials_with_fallback() instead, as smbc_set_credentials()
has a broken API (no SMBCCTX * pointer). No more global variables used
in the connection manager API for client dfs calls.
Jeremy.
Günther Deschner [Tue, 17 Mar 2009 19:50:59 +0000 (20:50 +0100)]
s3-rpcclient: say that we are displaying a REG_MULTI_SZ in display_reg_value().
Guenther
Günther Deschner [Tue, 17 Mar 2009 19:52:58 +0000 (20:52 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 16 Mar 2009 20:09:36 +0000 (21:09 +0100)]
spoolss: add spoolss_PrinterEnumValues.
Guenther
Steve Langasek [Tue, 17 Mar 2009 21:08:28 +0000 (22:08 +0100)]
s3: Fix bugs in the detection of the GNU ld version (Bug #6147)
This bug results in a failure to use linker scripts to limit the set of symbols
exported by our shared libraries.
Signed-off-by: Michael Adam <obnox@samba.org>
Zach Loafman [Mon, 16 Mar 2009 16:24:06 +0000 (09:24 -0700)]
s4 torture: Win7 has a slightly different allowed access mask
Still investigating.
Zach Loafman [Fri, 13 Mar 2009 16:04:33 +0000 (09:04 -0700)]
s4 torture: Add a string version for NT_STATUS_WIN7_INVALID_RANGE
Also submitted a request to cifs-protocol for a real name for this
thing. Use win7 target logic in smb2 lock test, SMB2-LOCK now passes
against Win7.
Zach Loafman [Thu, 12 Mar 2009 15:32:58 +0000 (08:32 -0700)]
s4 libcli: Add SMB2.1 dialect to libcli
Negotiate 2.1 if possible, leave negotiate results in
transport->negotiate.dialect_revision.
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
Stefan Metzmacher [Tue, 17 Mar 2009 19:18:31 +0000 (20:18 +0100)]
s4:build: require tevent 0.9.5
metze
Stefan Metzmacher [Tue, 17 Mar 2009 19:18:01 +0000 (20:18 +0100)]
tevent: change version to 0.9.5 after the ABI has changed
metze
Stefan Metzmacher [Tue, 17 Mar 2009 19:13:34 +0000 (20:13 +0100)]
tevent: store the location where a request was finished
This is very useful to find bugs.
You can use 'p *req' in gdb to show where
tevent_req_done(), tevent_req_error() or tevent_req_nomem()
was called.
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:42:55 +0000 (10:42 +0100)]
tevent: use an immediate event as trigger for tevent_queue
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:18:34 +0000 (10:18 +0100)]
tevent: use an immediate event fot tevent_req_post()
Now tevent_req_post() never fails
metze
Stefan Metzmacher [Tue, 17 Mar 2009 09:17:50 +0000 (10:17 +0100)]
tevent: use TALLOC_FREE() in tevent_req.c
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:06:52 +0000 (15:06 +0100)]
s3:events: add support for immediate events
metze
Stefan Metzmacher [Fri, 13 Mar 2009 14:47:33 +0000 (15:47 +0100)]
tevent: add support for immediate events
They're like directly triggered timed events,
but you can preallocated them and scheduling them
will not fail.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:45:42 +0000 (14:45 +0100)]
s3:events: make use of tevent_common_loop_wait()
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:15:07 +0000 (14:15 +0100)]
tevent: add tevent_common_loop_wait() helper function and use it
tevent_loop_wait should do the same for all backends.
It should loop as long as we have pending events.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 11:45:48 +0000 (12:45 +0100)]
tevent: check signal events first in event_loop_once
We also check for signal events directly before and after
the select/epoll calls.
metze
Stefan Metzmacher [Mon, 16 Mar 2009 11:34:23 +0000 (12:34 +0100)]
tevent: let tevent_loop_once() just run one fd event
This makes the logic much simpler for the callers,
and matches the samba3 behavior.
If needed we can add performance tunning for tevent_loop_wait()
later.
metze
Günther Deschner [Tue, 17 Mar 2009 17:36:43 +0000 (18:36 +0100)]
s3-spoolss: remove unused RPC_BUFFER definition.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:34:45 +0000 (18:34 +0100)]
s3-spoolss: remove (disabled) enum_all_printers_info_1_remote.
Jerry, please check. I do not understand how this could work and in
it's current form, we cannot make this even compile anymore, I'm afraid :)
I think it is safe to remove.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:03:36 +0000 (18:03 +0100)]
s4-smbtorture: fix spoolss notify test for notify type changes.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:03:10 +0000 (18:03 +0100)]
s3-spoolss: remove PRINTER_NOTIFY_TYPE and JOB_NOTIFY_TYPE now defined in IDL.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:31:18 +0000 (17:31 +0100)]
s3-spoolss: remove SPL Port definitions now in IDL.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:25:07 +0000 (17:25 +0100)]
s3-spoolss: remove PRIORITY defines, that were never used.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:24:47 +0000 (17:24 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 17 Mar 2009 17:01:11 +0000 (18:01 +0100)]
spoolss: use PRINTER_NOTIFY_TYPE and JOB_NOTIFY_TYPE in favor of "old" s4 defines.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:30:07 +0000 (17:30 +0100)]
spoolss: add SPL Port definitions to IDL.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:24:01 +0000 (17:24 +0100)]
spoolss: add range checks for priority element in spoolss_JobInfo structs.
Guenther
Günther Deschner [Tue, 17 Mar 2009 16:17:18 +0000 (17:17 +0100)]
s3-spoolss: move DRIVER_X_VERSION flags into the backend, where they belong to.
Guenther
Günther Deschner [Tue, 17 Mar 2009 15:41:16 +0000 (16:41 +0100)]
s3-spoolss: remove unused DEVICEMODE parsing and header.
Guenther
Günther Deschner [Tue, 17 Mar 2009 14:26:38 +0000 (15:26 +0100)]
s3-spoolss: rename convert_printer_info_new to convert_printer_info.
Guenther
Günther Deschner [Tue, 17 Mar 2009 14:25:07 +0000 (15:25 +0100)]
s3-spoolss: rename convert_nt_devicemode_new to convert_nt_devicemode.
Guenther
Günther Deschner [Tue, 17 Mar 2009 14:23:30 +0000 (15:23 +0100)]
s3-spoolss: rename construct_dev_mode_new to construct_dev_mode.
Guenther
Günther Deschner [Tue, 17 Mar 2009 14:22:22 +0000 (15:22 +0100)]
s3-spoolss/registry: use libndr to push a spoolss_DeviceMode in fill_in_printer_values().
Guenther
Günther Deschner [Tue, 17 Mar 2009 14:21:06 +0000 (15:21 +0100)]
s3-spoolss/registry: use marshall_sec_desc in fill_in_printer_values().
Guenther
Günther Deschner [Tue, 17 Mar 2009 13:45:24 +0000 (14:45 +0100)]
s3-spoolss: move SYSTEMTIME parsing to a more generic place, as suggested.
Guenther
Günther Deschner [Tue, 17 Mar 2009 13:43:50 +0000 (14:43 +0100)]
s3-spoolss: rename temporary convert_devicemode_new function.
Guenther
Günther Deschner [Tue, 17 Mar 2009 11:48:46 +0000 (12:48 +0100)]
s3-spoolss: move PRINTER_ATTRIBUTE_SAMBA to printing backend, where they belong.
Guenther
Günther Deschner [Tue, 17 Mar 2009 11:48:10 +0000 (12:48 +0100)]
s3-spoolss: remove PRINTER_MESSAGE flags and struct, this was never used.
Guenther
Volker Lendecke [Tue, 17 Mar 2009 08:38:14 +0000 (09:38 +0100)]
Remove some transitional code in writev_send
Volker Lendecke [Tue, 17 Mar 2009 08:34:17 +0000 (09:34 +0100)]
Convert np_read to tevent_req
Volker Lendecke [Tue, 17 Mar 2009 08:17:16 +0000 (09:17 +0100)]
Convert np_write to tevent_req
Björn Jacke [Wed, 11 Mar 2009 14:44:45 +0000 (15:44 +0100)]
remove needless rpath stuff for default paths as early as possible
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Jacke [Wed, 11 Mar 2009 14:32:49 +0000 (15:32 +0100)]
clean up lib64 linking paths the same way as lib
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Jacke [Sun, 8 Mar 2009 11:54:04 +0000 (12:54 +0100)]
to be portable, use options first, arguments last
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Tue, 17 Mar 2009 14:51:13 +0000 (15:51 +0100)]
.gitignore source4/torture/ldb/proto.h
Michael