git.samba.org
/
abartlet
/
samba.git
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
43182fd
)
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
author
Günther Deschner
<gd@samba.org>
Wed, 18 Mar 2009 20:54:26 +0000
(21:54 +0100)
committer
Günther Deschner
<gd@samba.org>
Wed, 18 Mar 2009 20:57:07 +0000
(21:57 +0100)
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
source3/rpc_server/srv_spoolss_nt.c
patch
|
blob
|
history
diff --git
a/source3/rpc_server/srv_spoolss_nt.c
b/source3/rpc_server/srv_spoolss_nt.c
index 5e1c53905a0a025d6e98c2ef43506e460b0a89f0..b825cefa395e0204fab01f0393a6d39e9820cbd0 100644
(file)
--- a/
source3/rpc_server/srv_spoolss_nt.c
+++ b/
source3/rpc_server/srv_spoolss_nt.c
@@
-2482,7
+2482,7
@@
static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx,
return WERR_OK;
}
- return WERR_
BADFILE
;
+ return WERR_
INVALID_PARAM
;
}
/****************************************************************