samba.git
16 years agoFix case where we have no dns domain name. Return a talloc of "".
Jeremy Allison [Fri, 9 Nov 2007 01:58:55 +0000 (17:58 -0800)]
Fix case where we have no dns domain name. Return a talloc of "".
Jeremy.

16 years agoRemove more fstring/pstring bad useage. Go talloc !
Jeremy Allison [Fri, 9 Nov 2007 01:25:45 +0000 (17:25 -0800)]
Remove more fstring/pstring bad useage. Go talloc !
Jeremy.

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 8 Nov 2007 23:13:41 +0000 (15:13 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agosync the most parts of librpc/ndr with samba4
Stefan Metzmacher [Thu, 8 Nov 2007 13:36:13 +0000 (14:36 +0100)]
sync the most parts of librpc/ndr with samba4

metze

16 years agoadd '_PUBLIC_' prototypes into proto.h
Stefan Metzmacher [Thu, 8 Nov 2007 13:34:02 +0000 (14:34 +0100)]
add '_PUBLIC_' prototypes into proto.h

this makes merging samba4 code easier...

metze

16 years agoadd win_errstr() as wrapper of dos_errstr().
Stefan Metzmacher [Thu, 8 Nov 2007 13:33:04 +0000 (14:33 +0100)]
add win_errstr() as wrapper of dos_errstr().

this makes merging stuff from samba4 easier

metze

16 years agowe should not ignore convert_string_talloc() failures.
Stefan Metzmacher [Thu, 8 Nov 2007 12:52:56 +0000 (13:52 +0100)]
we should not ignore convert_string_talloc() failures.

In all other places in ndr_string.c we already use False...

metze

16 years agolibreplace: we need to link to make sure the functions are available
Stefan Metzmacher [Thu, 8 Nov 2007 11:18:28 +0000 (12:18 +0100)]
libreplace: we need to link to make sure the functions are available

metze

16 years agoTry to fix the build on systems without struct sockaddr_storage type
Michael Adam [Thu, 8 Nov 2007 10:46:13 +0000 (11:46 +0100)]
Try to fix the build on systems without struct sockaddr_storage type
(like hape - HPUX 11.00).

Michael

16 years agoConstrain "min receivefile size" to max of BUFFER_SIZE
Jeremy Allison [Thu, 8 Nov 2007 05:47:00 +0000 (21:47 -0800)]
Constrain "min receivefile size" to max of BUFFER_SIZE
(128k). Add debug error messages so we can see why
writeX large is denied. Ensure we don't allow recvfile
writes on IPC$.
Jeremy.

16 years agoTry to fix the build on irix.
Michael Adam [Wed, 7 Nov 2007 21:28:26 +0000 (22:28 +0100)]
Try to fix the build on irix.
There were two callers of set_smb_read_error() in irix_oplocks.c
not converted to the new prototype.

Michael

16 years agoUnify the name and addr cache for client_name to
Jeremy Allison [Wed, 7 Nov 2007 20:48:58 +0000 (12:48 -0800)]
Unify the name and addr cache for client_name to
make threading easier ultimately.
Jeremy.

16 years ago- check return value of ndr_push_set_switch_value()
metze [Fri, 2 Nov 2007 11:01:18 +0000 (11:01 +0000)]
- check return value of ndr_push_set_switch_value()
- fix memory leaks in error pathes

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25798 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agouse error and out logic
metze [Fri, 2 Nov 2007 10:59:43 +0000 (10:59 +0000)]
use error and out logic

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25797 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agouse NT_STATUS_HAVE_NO_MEMORY()
metze [Fri, 2 Nov 2007 10:49:51 +0000 (10:49 +0000)]
use NT_STATUS_HAVE_NO_MEMORY()

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25796 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agouse NDR_CHECK()
metze [Fri, 2 Nov 2007 10:32:47 +0000 (10:32 +0000)]
use NDR_CHECK()

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25794 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agocheck the return value of ndr_push_set_switch_value()
metze [Fri, 2 Nov 2007 10:29:19 +0000 (10:29 +0000)]
check the return value of ndr_push_set_switch_value()

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25793 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agouse NT_STATUS_HAVE_NO_MEMORY() and NDR_CHECK()
metze [Fri, 2 Nov 2007 10:26:49 +0000 (10:26 +0000)]
use NT_STATUS_HAVE_NO_MEMORY() and NDR_CHECK()

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25792 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agothe return value of ndr_pull_set_switch_value() should be checked
metze [Thu, 1 Nov 2007 10:15:13 +0000 (10:15 +0000)]
the return value of ndr_pull_set_switch_value() should be checked

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25779 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agouse NT_STATUS_HAVE_NO_MEMORY() and NDR_CHECK() macros
metze [Thu, 1 Nov 2007 10:13:36 +0000 (10:13 +0000)]
use NT_STATUS_HAVE_NO_MEMORY() and NDR_CHECK() macros

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25778 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoadd NDR_ERR_UNREAD_BYTES and don't use NTSTATUS directly
metze [Thu, 1 Nov 2007 09:50:24 +0000 (09:50 +0000)]
add NDR_ERR_UNREAD_BYTES and don't use NTSTATUS directly

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25777 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agocreate ndr_pull_union_blob_all() and match the logic of the struct fns
metze [Thu, 1 Nov 2007 08:10:54 +0000 (08:10 +0000)]
create ndr_pull_union_blob_all() and match the logic of the struct fns

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25774 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix tdbtorture build.
Jeremy Allison [Wed, 7 Nov 2007 07:13:11 +0000 (23:13 -0800)]
Fix tdbtorture build.
Jeremy.

16 years agoFix const warning.
Jeremy Allison [Wed, 7 Nov 2007 07:09:31 +0000 (23:09 -0800)]
Fix const warning.
Jeremy.

16 years agoKeep the tdb code in sync with Samba4.
Jeremy Allison [Wed, 7 Nov 2007 06:57:35 +0000 (22:57 -0800)]
Keep the tdb code in sync with Samba4.

Mainly this is the svn changes :

------------------------------------------------------------------------
r23238 | tridge | 2007-05-30 01:15:49 -0700 (Wed, 30 May 2007) | 6 lines

merged transaction lock changes from ctdb

this ensures that having the global lock also implies the transaction
lock

------------------------------------------------------------------------
r22832 | tridge | 2007-05-13 18:00:06 -0700 (Sun, 13 May 2007) | 3 lines

merged the latest tdb changes from ctdb to Samba4

Jeremy.

16 years agoFix bug where tdb lock call interrupted with
Jeremy Allison [Wed, 7 Nov 2007 05:47:57 +0000 (21:47 -0800)]
Fix bug where tdb lock call interrupted with
an alarm sig would not terminate and could lead
to runaway smbd processes.
Thanks to Dave Daugherty @ Centrify for pointing
this out to us.
Jeremy.

16 years agoEnsure we don't use massive writes in pipe mode.
Jeremy Allison [Tue, 6 Nov 2007 22:12:38 +0000 (14:12 -0800)]
Ensure we don't use massive writes in pipe mode.
Jeremy.

16 years agoMove some access check functions that are not posix-acl specific
Michael Adam [Fri, 26 Oct 2007 17:50:55 +0000 (19:50 +0200)]
Move some access check functions that are not posix-acl specific
to a new source file of their own.

Michael

16 years agoDon't repeat fast-pathing...
Michael Adam [Thu, 25 Oct 2007 11:32:56 +0000 (13:32 +0200)]
Don't repeat fast-pathing...

Michael

16 years agoThis is a proposed patch for Bug #5023.
Michael Adam [Sat, 20 Oct 2007 00:17:07 +0000 (02:17 +0200)]
This is a proposed patch for Bug #5023.

The three can_* access check functions in smbd/posix_acls.c that are used in
smbd/open.c and smbd/nttrans.c explicitly called check_posix_acl_group_access()

This lead to errors with nfsv4 acls (ZFS and GPFS).

This changes the can_* functions to get the nt_acl via VFS layer and call
se_access_check on that. It also removes check_posix_acl_group_access()
which has no more callers.

NOTE: The can_* functions should really not be in smbd/posix_acls.c but
in a separate file (I propose smbd/access.c).

Michael

16 years agoAdd a const.
Michael Adam [Tue, 6 Nov 2007 05:31:24 +0000 (06:31 +0100)]
Add a const.

Michael

16 years agolibreplace: we should only have one location where we check for required functions
metze [Tue, 6 Nov 2007 07:01:17 +0000 (07:01 +0000)]
libreplace: we should only have one location where we check for required functions

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25864 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agolibreplace: we need include <unistd.h> before nss_wrapper.h
metze [Tue, 6 Nov 2007 06:54:49 +0000 (06:54 +0000)]
libreplace: we need include <unistd.h> before nss_wrapper.h

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25863 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix export dynamic for HPUX.
jelmer [Tue, 6 Nov 2007 04:59:50 +0000 (04:59 +0000)]
Fix export dynamic for HPUX.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25861 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRemove flag that causes problems on some hosts.
jelmer [Tue, 6 Nov 2007 04:26:57 +0000 (04:26 +0000)]
Remove flag that causes problems on some hosts.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25860 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoWrap native HPUX functions in dl implementation.
jelmer [Tue, 6 Nov 2007 04:26:52 +0000 (04:26 +0000)]
Wrap native HPUX functions in dl implementation.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25859 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoCheck for HPUX dl functions.
jelmer [Tue, 6 Nov 2007 03:43:50 +0000 (03:43 +0000)]
Check for HPUX dl functions.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25855 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMove SHLIBEXT determination into a test as well.
jelmer [Tue, 6 Nov 2007 02:35:46 +0000 (02:35 +0000)]
Move SHLIBEXT determination into a test as well.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25852 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMove system-specific ldflags checks to libreplace so they can be used by ldb.
jelmer [Tue, 6 Nov 2007 02:17:05 +0000 (02:17 +0000)]
Move system-specific ldflags checks to libreplace so they can be used by ldb.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25851 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd macro for picflag.
jelmer [Tue, 6 Nov 2007 02:16:55 +0000 (02:16 +0000)]
Add macro for picflag.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25850 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd configure test for -Wl,--export-dynamic.
jelmer [Tue, 6 Nov 2007 01:05:19 +0000 (01:05 +0000)]
Add configure test for -Wl,--export-dynamic.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25846 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agolibreplace: include nss_wrapper.h if NSS_WRAPPER is defined
metze [Mon, 5 Nov 2007 15:45:08 +0000 (15:45 +0000)]
libreplace: include nss_wrapper.h if NSS_WRAPPER is defined

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25838 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoEnsure we null out the address correctly.
Jeremy Allison [Tue, 6 Nov 2007 07:17:19 +0000 (23:17 -0800)]
Ensure we null out the address correctly.
Jeremy.

16 years agoFix another segfault and make smbfilter run again.
Michael Adam [Tue, 6 Nov 2007 00:09:24 +0000 (01:09 +0100)]
Fix another segfault and make smbfilter run again.
This fix is not complete yet (loop after "client closed connection")
but at least it starts again...

Micheal

16 years agoFix a segfault.
Michael Adam [Tue, 6 Nov 2007 00:07:12 +0000 (01:07 +0100)]
Fix a segfault.

Michael

16 years agoTry to fix the build. There was one forgotten caller
Michael Adam [Tue, 6 Nov 2007 00:06:06 +0000 (01:06 +0100)]
Try to fix the build. There was one forgotten caller
of receive_smb. Jeremy: please check!

Michael

16 years agoWhen deleting a key from the registry make sure the non-default
Günther Deschner [Mon, 5 Nov 2007 23:50:47 +0000 (00:50 +0100)]
When deleting a key from the registry make sure the non-default
security descriptor gets deleted as well.

Guenther

16 years agoAdd two const's.
Michael Adam [Mon, 5 Nov 2007 22:23:05 +0000 (23:23 +0100)]
Add two const's.

Michael

16 years agoRemove the horror that was the global smb_rw_error.
Jeremy Allison [Mon, 5 Nov 2007 19:12:56 +0000 (11:12 -0800)]
Remove the horror that was the global smb_rw_error.
Each cli struct has it's own local copy of this variable,
so use that in client code. In the smbd server, add one
static to smbd/proccess.c and use that inside smbd. Fix
a bunch of places where smb_rw_error could be set by
calling read_data() in places where we weren't reading
from the SMB client socket (ie. winbindd).
Jeremy.

16 years agoFix a typo.
Michael Adam [Mon, 5 Nov 2007 14:16:11 +0000 (15:16 +0100)]
Fix a typo.

Michael

16 years agoIgnore testing tdb.
Günther Deschner [Mon, 5 Nov 2007 01:35:04 +0000 (02:35 +0100)]
Ignore testing tdb.

Guenther

16 years agoDon't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
Jeremy Allison [Mon, 5 Nov 2007 06:20:04 +0000 (22:20 -0800)]
Don't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
on the stack - use talloc.
Jeremy

16 years agoThis should really be a cond_set_smb_read_error().
Jeremy Allison [Mon, 5 Nov 2007 06:14:19 +0000 (22:14 -0800)]
This should really be a cond_set_smb_read_error().
Jeremy.

16 years agoDon't use 0 when we mean SMB_READ_OK.
Jeremy Allison [Mon, 5 Nov 2007 06:12:31 +0000 (22:12 -0800)]
Don't use 0 when we mean SMB_READ_OK.
Jeremy.

16 years agoMerge commit 'origin/v3-2-test' into branches/upstream
Günther Deschner [Mon, 5 Nov 2007 02:39:18 +0000 (03:39 +0100)]
Merge commit 'origin/v3-2-test' into branches/upstream

16 years agoRemove unnecessary code
Volker Lendecke [Thu, 1 Nov 2007 16:42:35 +0000 (17:42 +0100)]
Remove unnecessary code

SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure

16 years agoFix a debug message
Volker Lendecke [Tue, 30 Oct 2007 21:58:09 +0000 (22:58 +0100)]
Fix a debug message

16 years agoDisplay sec ace flags.
Günther Deschner [Fri, 26 Oct 2007 10:58:01 +0000 (12:58 +0200)]
Display sec ace flags.

Guenther

16 years agoMake sure we can read SACLs from the registry.
Günther Deschner [Mon, 5 Nov 2007 01:33:58 +0000 (02:33 +0100)]
Make sure we can read SACLs from the registry.

Guenther

16 years agoFix the smbmount build
Volker Lendecke [Mon, 5 Nov 2007 02:14:16 +0000 (03:14 +0100)]
Fix the smbmount build

16 years agostatic pstring removal
Volker Lendecke [Sun, 4 Nov 2007 17:15:37 +0000 (18:15 +0100)]
static pstring removal

16 years agopstring removal
Volker Lendecke [Thu, 1 Nov 2007 16:49:31 +0000 (17:49 +0100)]
pstring removal

16 years agoMake load_registry_service return the share number
Volker Lendecke [Sat, 3 Nov 2007 14:03:26 +0000 (15:03 +0100)]
Make load_registry_service return the share number

16 years agoForgot arg type.
Jeremy Allison [Mon, 5 Nov 2007 01:15:35 +0000 (17:15 -0800)]
Forgot arg type.
Jeremy.

16 years agoDon't believe len returned from read_smb_length_return_keepalive(),
Jeremy Allison [Sun, 4 Nov 2007 23:38:43 +0000 (15:38 -0800)]
Don't believe len returned from read_smb_length_return_keepalive(),
it may be a UNIX large writeX (which wraps len in that case).
Stevef this should fix your 128k write bug.
Jeremy.

16 years agoRemove most of the remaining globals out of lib/util_sock.c.
Jeremy Allison [Sun, 4 Nov 2007 06:20:10 +0000 (23:20 -0700)]
Remove most of the remaining globals out of lib/util_sock.c.
I have a plan for dealing with the remaining..... Watch
this space.
Jeremy.

16 years agoRemove more static data from lib/util_sock.c and
Jeremy Allison [Sun, 4 Nov 2007 05:34:46 +0000 (22:34 -0700)]
Remove more static data from lib/util_sock.c and
callers.
Jeremy.

16 years agoMissed one case where I need to pass down addrlen.
Jeremy Allison [Sun, 4 Nov 2007 03:27:59 +0000 (20:27 -0700)]
Missed one case where I need to pass down addrlen.
Jeremy

16 years agoI can't get away without a 'length' arg. :-).
Jeremy Allison [Sun, 4 Nov 2007 01:41:26 +0000 (18:41 -0700)]
I can't get away without a 'length' arg. :-).
Jeremy.

16 years agoStop get_peer_addr() and client_addr() from using global
Jeremy Allison [Sun, 4 Nov 2007 01:15:45 +0000 (18:15 -0700)]
Stop get_peer_addr() and client_addr() from using global
statics. Part of my library cleanups.
Jeremy.

16 years agoRemove the smb_read_error global variable and replace
Jeremy Allison [Sat, 3 Nov 2007 22:12:42 +0000 (15:12 -0700)]
Remove the smb_read_error global variable and replace
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.

16 years agoRemove unused var noticed by metze.
Jeremy Allison [Sat, 3 Nov 2007 17:25:51 +0000 (10:25 -0700)]
Remove unused var noticed by metze.
Jeremy.

16 years agoFix the snprintf checks, and fix a typo in pointer indirection.
Jeremy Allison [Fri, 2 Nov 2007 21:23:10 +0000 (14:23 -0700)]
Fix the snprintf checks, and fix a typo in pointer indirection.
These fixes are needed for a working getaddrinfo etc. replacement.
Fixes from Wayne Davison <wayned@samba.org> from rsync.
Jeremy.

16 years agoEnsure we use the correct socklen_t values for bind() for
Jeremy Allison [Fri, 2 Nov 2007 21:22:19 +0000 (14:22 -0700)]
Ensure we use the correct socklen_t values for bind() for
Solaris.
Jeremy.

16 years agoFix typos in calc_sa_size, noticed by jim.brown@miami.edu
Jeremy Allison [Fri, 2 Nov 2007 19:56:21 +0000 (12:56 -0700)]
Fix typos in calc_sa_size, noticed by jim.brown@miami.edu
Jeremy.

16 years agoChange the client library to write directly out of
Jeremy Allison [Fri, 2 Nov 2007 19:21:34 +0000 (12:21 -0700)]
Change the client library to write directly out of
the incoming buffer in the non-signed case. Speeds
up writes by over 10% or so. Complete the server
recvfile implementation.
Jeremy.

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 2 Nov 2007 19:06:15 +0000 (12:06 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoForgot one more getnameinfo.
Jeremy Allison [Fri, 2 Nov 2007 19:05:17 +0000 (12:05 -0700)]
Forgot one more getnameinfo.
Jeremy.

16 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:40 +0000 (14:16 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

16 years agoFix build breakage when not specifying --with-fhs.
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:06 +0000 (14:16 -0400)]
Fix build breakage when not specifying --with-fhs.
Ensure that CODEPAGEDIR, STATEDIR, and CACHEDIR have values.

16 years agoArgggh. smblen doesn't include the +4, so my smb_doff calculations
Jeremy Allison [Fri, 2 Nov 2007 17:35:10 +0000 (10:35 -0700)]
Argggh. smblen doesn't include the +4, so my smb_doff calculations
shouldn't either :-).
Jeremy.

16 years agoFix Solaris by ensuring we use the IPv4 or IPv6 length
Jeremy Allison [Fri, 2 Nov 2007 17:25:34 +0000 (10:25 -0700)]
Fix Solaris by ensuring we use the IPv4 or IPv6 length
in any getnameinfo calls.
Jeremy

16 years agoFix state_path to take a const string, not use pstring.
Jeremy Allison [Fri, 2 Nov 2007 16:27:04 +0000 (09:27 -0700)]
Fix state_path to take a const string, not use pstring.
Jeremy.

16 years agoEnsure we can't accidently do a pipe write with
Jeremy Allison [Fri, 2 Nov 2007 05:42:21 +0000 (22:42 -0700)]
Ensure we can't accidently do a pipe write with
unread bytes in the socket buffer.
Jeremy

16 years agoBe careful and take care of the correct lengths in large
Jeremy Allison [Fri, 2 Nov 2007 05:24:39 +0000 (22:24 -0700)]
Be careful and take care of the correct lengths in large
writeX calls.
Jeremy.

16 years agoEnsure we detect a large writeX when using recvfile.
Jeremy Allison [Fri, 2 Nov 2007 04:51:45 +0000 (21:51 -0700)]
Ensure we detect a large writeX when using recvfile.
More changes needed to make the UNIX_LARGE_WRITEX_CAP
writes work (I'll add these tomorrow).
Jeremy.

16 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Gerald (Jerry) Carter [Fri, 2 Nov 2007 01:30:43 +0000 (21:30 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

16 years agoAdd brackets so as not to break the POSIX caps return.
Jeremy Allison [Fri, 2 Nov 2007 01:30:02 +0000 (18:30 -0700)]
Add brackets so as not to break the POSIX caps return.
Jeremy.

16 years agoFix for bug 5021
Volker Lendecke [Sat, 20 Oct 2007 09:12:11 +0000 (11:12 +0200)]
Fix for bug 5021

This is a different fix than the bug reporter (Evgeniy Dushistov
<dushistov at mail.ru>, thanks!) created, but it lives without the boolean
status variable. Untested so far, but I can not add attachments to bugs right
now. But to me this looks really obvious.

16 years agoPatch 2 of 3 from Debian Samba packagers:
Gerald (Jerry) Carter [Thu, 1 Nov 2007 19:53:44 +0000 (15:53 -0400)]
Patch 2 of 3 from Debian Samba packagers:

The point is doing the following associations:

- non discardable state data (all TDB files that may need to be backed
  up) go to statedir
- shared data (codepage stuff) go to codepagedir

The patch *does not change* the default location for these
directories. So, there is no behaviour change when applying it.

The main change is for samba developers who have to think when dealing
with files that previously pertained to libdir whether they:
- go in statedir
- go in codepagedir
- stay in libdir

16 years agosave memory
Volker Lendecke [Wed, 31 Oct 2007 14:06:22 +0000 (15:06 +0100)]
save memory

Hi!

Attached find a patch that I've wanted to check in for ages.
The whole area probably needs a major rewrite, but this is a
minimal patch that on a 32-bit box saves 1.5k per smbd per
defined share, twice as much on a 64-bit box.

Volker

From ebb80e664ecc49eb597a45cb57e1067fbae49e62 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Wed, 31 Oct 2007 15:04:34 +0100
Subject: [PATCH] Change global->copymap from bool* to a bitmap

We right now have 401 parameters, so with bool being represented as a 64-bit
integer this saves about 3k of memory per smbd per share that is defined in
smb.conf.

16 years agoAdd missing recvfile_bytes element - noticed by Kukks.
Jeremy Allison [Thu, 1 Nov 2007 17:21:27 +0000 (10:21 -0700)]
Add missing recvfile_bytes element - noticed by Kukks.
Jeremy.

16 years agoPatch from Debian Samba package maintainers:
Gerald (Jerry) Carter [Thu, 1 Nov 2007 17:00:10 +0000 (13:00 -0400)]
Patch from Debian Samba package maintainers:

Patch 1 of 3:

- Patch 1 adds the new variables
- Patch 2 makes uses of them for files belonging to the "state" path
  and the "code pages" path
  This patch seemed more easily acceptable, which explains why we
  separated it from patch 3
- Patch 3 reassigns files to the "cache" path. Indeed all "debatable"
  changes have been moved to that one

The point is adding:

- a path for non discardable state data: basically all TDB files
  that may need to be backed up
- a path for shared data: mostly codepage stuff
- a path for cache data to host files such as
  browse.dat, printers.tbd, <printer>.tdb

All these are currently mixed in "libdir" (${prefix}/lib/samba by default).
The patch keeps these new paths to point to ${prefix}/lib/samba by default
and does therefore not change the software behaviour.  Used alone, it just
adds unused variables...so it can safely be used in sources without any
behaviour change and no impact on Samba developers work.

16 years agoEnable building the zfsacl VFS module by specifying
Michael Adam [Thu, 1 Nov 2007 13:24:27 +0000 (14:24 +0100)]
Enable building the zfsacl VFS module by specifying
"--with-shared-modules=vfs_zfsacl" on the configure command line.

Michael

16 years agoNote when we're setting change time, not write time, and send
Jeremy Allison [Wed, 31 Oct 2007 23:32:48 +0000 (16:32 -0700)]
Note when we're setting change time, not write time, and send
message accordingly. Apart from not supporting create time we
now pass the S4 RAW-NOTIFY torture.
Jeremy.

16 years agoFix some cases where file_set_dosmode was being passed
Jeremy Allison [Wed, 31 Oct 2007 22:45:45 +0000 (15:45 -0700)]
Fix some cases where file_set_dosmode was being passed
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.

16 years agoFix vfstest link - move socket calls into smbd/process.c
Jeremy Allison [Wed, 31 Oct 2007 21:24:52 +0000 (14:24 -0700)]
Fix vfstest link - move socket calls into smbd/process.c
not smbd/server.c
Jeremy

16 years agoAdd printout of large read/write caps if detected.
Jeremy Allison [Wed, 31 Oct 2007 21:12:50 +0000 (14:12 -0700)]
Add printout of large read/write caps if detected.
Jeremy.

16 years agoMake explicit draining the socket on RECVFILE. Add
Jeremy Allison [Wed, 31 Oct 2007 21:01:35 +0000 (14:01 -0700)]
Make explicit draining the socket on RECVFILE. Add
capability for large UNIX write if not signing and
recvfile set. Cope with large UNIX write length on
incoming processing. Stevef - we can now test 1-16Mb
writes from CIFFS.
Jeremy.

16 years agoHandle the disk full error case correctly.
Jeremy Allison [Wed, 31 Oct 2007 01:18:40 +0000 (18:18 -0700)]
Handle the disk full error case correctly.
Jeremy.