we should not ignore convert_string_talloc() failures.

In all other places in ndr_string.c we already use False...

metze

diff --git a/source/librpc/ndr/ndr_string.c b/source/librpc/ndr/ndr_string.c
index bc4582cca7666613d7fc4f1124afc00a39dafc8d..8c0b7231d6d0ef626c68ca11cfee44ec7783db8c 100644 (file)
--- a/source/librpc/ndr/ndr_string.c
+++ b/source/librpc/ndr/ndr_string.c
@@ -84,7 +84,7 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
                                                    chset, CH_UNIX, 
                                                    ndr->data+ndr->offset, 
                                                    (len2 + c_len_term)*byte_mul,
-                                                   &as, True);
+                                                   &as, False);
                        if (ret == -1) {
                                return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
                                                      "Bad character conversion");