Simo Sorce [Sat, 29 May 2010 13:48:20 +0000 (09:48 -0400)]
s3:passdb Fix memory leak
We were allocating this passwd structure on sampass, but never freeing
it nor assigning it to unix_pw where it could be reused.
Andrew Bartlett [Fri, 28 May 2010 18:14:27 +0000 (04:14 +1000)]
s3:auth Fix segfault when the user cannot be found by getpwnam()
Add comment to notify when getpwnam() fails.
Reviewed-by: Simo Sorce <idra@samba.org>
Günther Deschner [Fri, 28 May 2010 22:38:21 +0000 (00:38 +0200)]
s3-selftest: fix chmod commands in provisioning.
Guenther
Günther Deschner [Fri, 28 May 2010 22:09:14 +0000 (00:09 +0200)]
s3-selftest: make sure provisioned s3 looks the same in make selftest as in make test.
This fixes some tests that were previously failing.
Guenther
Kamen Mazdrashki [Fri, 28 May 2010 19:14:39 +0000 (22:14 +0300)]
s4/test-libnet: Remove multiple test_samr_close() impelementations
We now have a nice common test_samr_close_handle() function to use
Kamen Mazdrashki [Fri, 28 May 2010 18:20:03 +0000 (21:20 +0300)]
s4/test-libnet-user: Remove test_createuser()
We have same functionality already implemented by
test_user_create() in libnet/utils.c
Kamen Mazdrashki [Fri, 28 May 2010 14:59:25 +0000 (17:59 +0300)]
s4/test-libnet-utils: refactor test_user_create()
- param names made more clear what they stand for
- user RID out param is now optional, so that this function may
be used in cases where we don't need user RID
- SAMR connection handle is closed as it is not used further
(we should play nice with servers)
Kamen Mazdrashki [Fri, 28 May 2010 02:20:18 +0000 (05:20 +0300)]
s4/test: remove local impl for open_domain and use common one
Kamen Mazdrashki [Fri, 28 May 2010 02:14:47 +0000 (05:14 +0300)]
s4/test: remove torture/libnet/utils.h as we are using proto.h now
Kamen Mazdrashki [Fri, 28 May 2010 02:06:55 +0000 (05:06 +0300)]
s4/test: change prototype for test_opendomain()
- name changed to test_domain_open to be more alike athore functions
in utils.c file
- output parameters moved to the end param list definition just
after mem_ctx so it is somehow more clear those params are OUT
Kamen Mazdrashki [Fri, 28 May 2010 02:04:56 +0000 (05:04 +0300)]
s4/test: Refactor test_opendomain to address following
- param names made more clear what they stand for
- dom_sid out param is now optional, so that this function may
be used in cases where we don't need dom_sid
- SAMR connection handle is closed as it is not used further
Kamen Mazdrashki [Fri, 28 May 2010 01:45:40 +0000 (04:45 +0300)]
s4/test: make samr_close handle functio public
It is to be used further for closing opened handles when testing
using SAMR interface
Kamen Mazdrashki [Thu, 27 May 2010 14:24:10 +0000 (17:24 +0300)]
s4/test: refactor NET-USERINFO test to be more 'torture' friendly
Test may be further refactored to be converted as a test case
(what it is actually)
Kamen Mazdrashki [Thu, 27 May 2010 14:10:31 +0000 (17:10 +0300)]
s4/test: test_userinfo/_async tests should use passed user_name param value
Matthias Dieter Wallnöfer [Fri, 28 May 2010 16:58:45 +0000 (18:58 +0200)]
s4:web_server/wsgi.c - provide a better out-of-memory handling for an "asprintf" call
Andrew Bartlett [Thu, 13 May 2010 07:41:33 +0000 (17:41 +1000)]
s3:winbind Kill amusing but un-used winbindd_kill_all_clients
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 26 May 2010 01:11:08 +0000 (11:11 +1000)]
s3:lib s3:lib move get_global_sam_name to util_names.c
This doesn't really belong in util_sid.c, and has much more in common
with the other functions in util_names.c
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 17 May 2010 06:25:26 +0000 (16:25 +1000)]
s3:lib split out global workgroup and netbios name functions.
Having these in their own file allows easier selective inclusion.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 26 May 2010 00:48:15 +0000 (10:48 +1000)]
s3:smbd move messaging_context and memcache into globals.c
This helps vfstest, which previously had duplicate copies of these functions.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 27 May 2010 05:18:58 +0000 (07:18 +0200)]
s3:smbd split reload services/printers functions from server.c
This helps vfstest, as it previously had duplicate copies of these
functions.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 12 May 2010 21:48:04 +0000 (07:48 +1000)]
s3:smbd split smbd/server.c into smbd/server.c and smbd/server_exit.c
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Kai Blin [Fri, 28 May 2010 13:17:35 +0000 (15:17 +0200)]
s3-waf: Support builds with utmp accounting
Kai Blin [Fri, 28 May 2010 12:35:01 +0000 (14:35 +0200)]
s3-waf: Match the defines from the autotools build on PACKAGE_*
Andreas Schneider [Wed, 14 Apr 2010 13:15:32 +0000 (15:15 +0200)]
s3-auth: Added a function to get the server_info from the system user.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 28 May 2010 12:11:53 +0000 (14:11 +0200)]
s3-samr: Fix crash bug in _samr_QueryUserInfo{2} level 18.
Guenther
Andrew Bartlett [Fri, 28 May 2010 10:34:08 +0000 (20:34 +1000)]
s4:build Don't automatically mark as 'not a git snapshot'.
If we generate a tarball, it may well be a git snapshot - we will
change the VERSION file if it really is a release.
Andrew Bartlett
Andrew Bartlett [Fri, 28 May 2010 10:33:28 +0000 (20:33 +1000)]
s4:build use autotools for mkrelease.sh
The mkrelease.sh script only works with the autotools build. However,
it isn't recommended.
Andrew Bartlett
Andrew Bartlett [Fri, 28 May 2010 10:24:47 +0000 (20:24 +1000)]
waf Provide release signing capability in 'waf dist'
This helps ensure the release is signed correctly - the .tar file, not
the .tar.gz must be signed, and it's easy to forget this.
Andrew Bartlett
Andrew Bartlett [Fri, 28 May 2010 08:54:57 +0000 (18:54 +1000)]
s4:waf Exclude the autotools based build environment from a Samba4 release
Andrew Bartlett [Fri, 28 May 2010 08:50:25 +0000 (18:50 +1000)]
waf Add DIST_BLACKLIST to list files that we cannot include in a release
This currently includes the source3 directory for Samba4 releases (per
past practice in mkrelease.sh), but also could include things like
DFSG-unfree RFC files in the future.
Andrew Barltett
Andrew Bartlett [Tue, 25 May 2010 09:54:24 +0000 (19:54 +1000)]
s4:kdc Remove special talloc_free of the ldb context
I can see no reason not to just let this go with the talloc tree that
created it, and avoid a talloc_free with references.
Andrew Bartlett
Kai Blin [Fri, 28 May 2010 11:20:10 +0000 (13:20 +0200)]
s3-waf: Fix the smbclient build with libcap
Kai Blin [Fri, 28 May 2010 10:59:04 +0000 (12:59 +0200)]
s3-waf: Detect which version of krb5_enctype_to_string is used
Pair-Programmed-With: Günther Deschner <gd@samba.org>
Kai Blin [Fri, 28 May 2010 10:58:23 +0000 (12:58 +0200)]
s3-waf: Fix the build of swat with --enable-cups
Matthias Dieter Wallnöfer [Fri, 28 May 2010 08:39:54 +0000 (10:39 +0200)]
s4:client/client.c - we don't need "&ctx" for talloc calls
Simply use "ctx".
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:45:19 +0000 (17:45 +0200)]
s4:web_server/wsgi.c - fix "asprintf" call
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:41:39 +0000 (17:41 +0200)]
s4:utils/ntlm_auth.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:37:15 +0000 (17:37 +0200)]
s4:smbd/pidfile.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:36:33 +0000 (17:36 +0200)]
s4:scripting/python/modules.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:28:52 +0000 (17:28 +0200)]
s4:param/loadparm.c - fix "asprintf" call
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:18:03 +0000 (17:18 +0200)]
s4:ntvfs/simple/svfs_util.c - change an "asprintf" into a "talloc_asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:11:00 +0000 (17:11 +0200)]
s4:ntvfs/nbench/vfs_bench.c - change a "asprintf" into a "talloc_asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:06:12 +0000 (17:06 +0200)]
s4:libcli/clideltree.c - fix "asprintf"s
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:02:02 +0000 (17:02 +0200)]
s4:regshell - fix an "asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:00:50 +0000 (17:00 +0200)]
s4:regshell - don't use negative exit codes
Matthias Dieter Wallnöfer [Thu, 27 May 2010 14:59:14 +0000 (16:59 +0200)]
s4:client/client.c - fix "asprintf"s
Fix the result values or change them into "talloc_asprintf"s where possible
see bug #6404
Andrew Bartlett [Fri, 28 May 2010 05:20:03 +0000 (15:20 +1000)]
waf Read VERSION file inside WAF to set package version
This replaces the call to mkversion.sh in both the Samba3 and Samba4
WAF builds.
Andrew Bartlett
Günther Deschner [Thu, 27 May 2010 22:02:15 +0000 (00:02 +0200)]
s3-lanman: Fix api_RNetUserGetInfo level 2 marshalling offset calculation.
54 + 4 = 58 (and not 60).
Found by torture test.
Guenther
Günther Deschner [Fri, 28 May 2010 00:47:12 +0000 (02:47 +0200)]
s3-auth: fix c++ buildwarnings.
Guenther
Günther Deschner [Fri, 28 May 2010 00:20:21 +0000 (02:20 +0200)]
s3-build: remove duplicate ndr_krb5pac.h inclusion.
Guenther
Günther Deschner [Fri, 28 May 2010 00:20:02 +0000 (02:20 +0200)]
s3-build: use ndr_misc.h where needed.
Guenther
Günther Deschner [Fri, 28 May 2010 00:18:21 +0000 (02:18 +0200)]
s3-build: only use ndr_samr.h where needed.
Guenther
Günther Deschner [Fri, 28 May 2010 00:16:38 +0000 (02:16 +0200)]
s3-idl: fix some missing dependencies to other IDL files.
Guenther
Günther Deschner [Thu, 27 May 2010 23:19:25 +0000 (01:19 +0200)]
s3-rpc_client: move protos to init_netlogon.h
Guenther
Simo Sorce [Fri, 28 May 2010 00:40:22 +0000 (20:40 -0400)]
s3:auth Add comment to clarify usage of session keys.
Explain why we have what looks like a duplicate of session keys.
It is in fact not a duplicate.
Simo Sorce [Thu, 27 May 2010 23:41:07 +0000 (19:41 -0400)]
s3:auth remove login_server from server info
It is not used anymore, we have that information in
info3->base.logon_server already
Simo Sorce [Thu, 27 May 2010 23:22:02 +0000 (19:22 -0400)]
Fix Out of memory checks
Günther pushed an older version of the patch "s3:auth add function to copy a
netr_SamInfo3 structure" that was missing these fixes.
Simo Sorce [Thu, 27 May 2010 07:21:35 +0000 (03:21 -0400)]
s3:auth add function to convert wbcAuthUserInfo to netr_SamInfo3
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 09:31:45 +0000 (05:31 -0400)]
s3:auth Free sampass as soon as we have server_info
We don't keep sampass in server_info anymore
So it makes no sense to keep it around.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 07:41:56 +0000 (03:41 -0400)]
s3:auth use info3 in auth_serversupplied_info
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 06:40:59 +0000 (02:40 -0400)]
s3:auth add function to copy a netr_SamInfo3 structure
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 06:07:33 +0000 (02:07 -0400)]
s3:auth: add function to convert samu to netr_SamInfo3
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 27 May 2010 14:10:10 +0000 (16:10 +0200)]
s4-smbtorture: finally test all levels in rap_NetUserGetInfo RAP-SAM test.
Guenther
Günther Deschner [Thu, 29 Apr 2010 21:34:27 +0000 (23:34 +0200)]
s4-smbtorture: remove obsolete handmarshalled rap code.
Guenther
Günther Deschner [Thu, 29 Apr 2010 23:09:46 +0000 (01:09 +0200)]
s4-smbtorture: we can fully use autogenerated code to pull info unions now.
Guenther
Günther Deschner [Thu, 29 Apr 2010 23:08:07 +0000 (01:08 +0200)]
libndr: add support for relative_rap_convert.
Will not harm anyone, is only used for rare short (2byte) relative pointers, and
relative_rap_convert is always 0 so far (as all init functions using struct
ndr_pull will zero the struct).
Guenther
Kai Blin [Thu, 27 May 2010 20:45:13 +0000 (22:45 +0200)]
s3-waf: Fix typo
Sorry for the noise
Kai Blin [Thu, 27 May 2010 20:42:23 +0000 (22:42 +0200)]
s3-waf: Also set "developer" env when building in developer mode
Volker Lendecke [Thu, 27 May 2010 16:12:30 +0000 (18:12 +0200)]
s3: Fix a bad memleak in the async echo responder
Günther Deschner [Thu, 27 May 2010 15:09:39 +0000 (17:09 +0200)]
s3-waf: fix the build after tstream changes.
Guenther
Volker Lendecke [Thu, 27 May 2010 12:27:58 +0000 (14:27 +0200)]
s3: Remove an unused variable
Günther Deschner [Wed, 26 May 2010 21:36:33 +0000 (23:36 +0200)]
s3-lanman: use samr for api_RNetUserGetInfo.
Following MS-RAP 3.2.5.13 NetUserGetInfo Command.
Guenther
Günther Deschner [Thu, 27 May 2010 11:25:31 +0000 (13:25 +0200)]
s4-smbtorture: create the user to test in test_usergetinfo() in RAP-SAM.
Guenther
Holger Hetterich [Sun, 23 May 2010 21:18:58 +0000 (23:18 +0200)]
vfs_smb_traffic_analyzer.c: set the len variable when running protocol v1.
Signed-off-by: Andreas Schneider <asn@samba.org>
Stefan Metzmacher [Tue, 27 Apr 2010 13:15:09 +0000 (15:15 +0200)]
s3:rpc_server: make use of the npa_tstream code to connect to named pipes
This way we use the newest protocol, which is able to pass
the local and remote address of the SMB connection.
And we correctly support message mode named pipes
without the hack that analyzes the content for DCERPC pdus.
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:08:02 +0000 (15:08 +0200)]
s3:Makefile.in: add npa_tstream.o to the build of smbd
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:12:32 +0000 (15:12 +0200)]
s3:rpc_server: pass down local and remote tsocket_address to np_open()
metze
Stefan Metzmacher [Wed, 28 Apr 2010 13:15:23 +0000 (15:15 +0200)]
s3:smbd: add PIPE_BUSY handling for SMBtrans calls on named pipes
metze
Stefan Metzmacher [Wed, 28 Apr 2010 13:05:30 +0000 (15:05 +0200)]
s3:rpc_server: add np_read_in_progress() function
metze
Stefan Metzmacher [Wed, 26 May 2010 08:43:19 +0000 (10:43 +0200)]
s3:rpc_server: make sure we don't send uninitialized memory for the named_pipe_auth handshake
metze
Günther Deschner [Wed, 26 May 2010 21:17:35 +0000 (23:17 +0200)]
s3-net: fix the build.
Guenther
Günther Deschner [Wed, 26 May 2010 19:22:13 +0000 (21:22 +0200)]
s4-smbtorture: add usergetinfo to RAP-SAM.
Guenther
Günther Deschner [Wed, 26 May 2010 20:55:45 +0000 (22:55 +0200)]
rap: use rap_LogonHours in rap_NetUserInfo11 as well.
Guenther
Günther Deschner [Wed, 26 May 2010 11:29:35 +0000 (13:29 +0200)]
s3-waf: more work on krb5 build.
Guenther
Kai Blin [Tue, 25 May 2010 15:53:16 +0000 (17:53 +0200)]
s3-waf: Allow to build with kerberos support
Günther Deschner [Wed, 26 May 2010 20:49:01 +0000 (22:49 +0200)]
s3-lanman: remove defines now provided by IDL.
Guenther
Günther Deschner [Wed, 26 May 2010 20:48:32 +0000 (22:48 +0200)]
rap: fix typo in IDL.
Guenther
Günther Deschner [Wed, 26 May 2010 20:32:32 +0000 (22:32 +0200)]
s3-waf: fix the build after chgpasswd.c changes.
Guenther
Günther Deschner [Wed, 26 May 2010 18:59:40 +0000 (20:59 +0200)]
s4-smbtorture: add smbcli_rap_netusergetinfo().
Guenther
Günther Deschner [Wed, 26 May 2010 18:54:50 +0000 (20:54 +0200)]
rap: add rap_NetUserGetInfo IDL.
Guenther
Günther Deschner [Tue, 18 May 2010 10:06:23 +0000 (12:06 +0200)]
s3-samr: move chgpasswd.c out of smbd and into the samr server.
Guenther
Günther Deschner [Fri, 7 May 2010 17:26:06 +0000 (19:26 +0200)]
s3-smbd: remove unused change/check_lanman_password.
Guenther
Günther Deschner [Tue, 11 May 2010 00:24:43 +0000 (02:24 +0200)]
s3-lanman: parse encrypted and min_pwd_length in api_SetUserPassword().
Guenther
Günther Deschner [Fri, 7 May 2010 12:37:25 +0000 (14:37 +0200)]
s3-lanman: use samr for api_SetUserPassword().
Guenther
Matthias Dieter Wallnöfer [Wed, 26 May 2010 15:41:50 +0000 (17:41 +0200)]
flags.h - fix comment for "GTYPE_SECURITY_UNIVERSAL_GROUP" constant
Björn Jacke [Wed, 26 May 2010 15:22:24 +0000 (17:22 +0200)]
s3:Makefile: add missing linker flags for smbfilter
this should fix the AIX build
Björn Jacke [Wed, 26 May 2010 15:18:59 +0000 (17:18 +0200)]
s3:Makefile: fix a typo in flag variable name
Günther Deschner [Wed, 26 May 2010 13:14:20 +0000 (15:14 +0200)]
s3-printing: fix buildwarning in publishing code after registry changes.
Guenther
Simo Sorce [Wed, 28 Apr 2010 14:23:48 +0000 (10:23 -0400)]
s3-lanman: Migrated to rpc_connect_spoolss_pipe().
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 28 Apr 2010 13:51:12 +0000 (09:51 -0400)]
s3-rpc_server: Created a per connection spoolss pipe.
This way all code can reuse the same connection to spoolss
and not have to deal with the creation of a new pipe all over the
code every time we need to ask a service off spoolss.
Signed-off-by: Günther Deschner <gd@samba.org>