Revert "TESTING ONLY: tevent: Force the poll backend"

This reverts commit 81485d356d19a97adb84d8db981c679a8afa3c54.

TESTING ONLY: tevent: Force the poll backend

Revert "HACK epoll TEST_PANIC_FALLBACK"

This reverts commit 0b9c1ee06465ba0edd0753a3b6b526fa045288a3.

HACK epoll TEST_PANIC_FALLBACK

Revert "HACK tevent_standard no epoll"

This reverts commit db830ce72e82372fcd5b40a126eaade9d31cdbf8.

HACK tevent_standard no epoll

Revert "HACK force pthreadpool_sync.c"

This reverts commit 8db6a9eb2dda868d7aad7f9151ebc5d78481a9bb.

HACK force pthreadpool_sync.c

SQ??? event vs. event_perf ??? tevent: Test tevent_immediate performance

SQ??? event vs. event_perf ??? tevent: Test tevent_immediate performance

SQ?? tevent: Test tevent_immediate performance

tevent: Test tevent_immediate performance

I found no way to add this to "skip" as a subtest of local.event, so I created
a separate suite.

Signed-off-by: Volker Lendecke <vl@samba.org>

Revert "TODO s4:libcli/raw: don't schedule idle handlers on a dead connection"

This reverts commit 625f14f4b6aad030aa88fb5df02d50c642854b6b.

Revert "TODO s4:libcli/smb2: don't schedule idle handlers on a dead connection"

This reverts commit d33f9ef8275959b506fe5aae99e301fe9d996fee.

Revert "TODO s4:torture/raw: test_notify_tcp_dis trigger idle event every 0.25s"

This reverts commit 0d8ac37c81a7f845bfc5235c628330b2c35346e9.

Revert "TODO s4:torture/smb2: test_notify_tcp_dis trigger idle event every 0.25s"

This reverts commit 4efe85a486c33c4ce9e84496ba86f6cef925d7ff.

TODO s4:torture/smb2: test_notify_tcp_dis trigger idle event every 0.25s

This is 1000 times longer than before and is less likely to
change the timing behavior whe n running under valgrind.

TODO s4:torture/raw: test_notify_tcp_dis trigger idle event every 0.25s

This is 1000 times longer than before and is less likely to
change the timing behavior whe n running under valgrind.

TODO s4:libcli/smb2: don't schedule idle handlers on a dead connection

TODO s4:libcli/raw: don't schedule idle handlers on a dead connection

Revert "HACK blackbox subunit print ok"

This reverts commit 3c8f2cda9ff4db117b9fba5006052d52f235dcaa.

HACK blackbox subunit print ok

TDB_NO_FSYNC=1 buildnice make -j test TESTS=LOCAL-WBCLIENT
...
less st/subunit

s3:lib/recvfile: make use of F_SETPIPE_SZ and reduce the splice syscalls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

more...

more

remove metze_thread_fn

lib/tevent/testsuite.c

more

more

bla

next

sq lib/tevent/tevent_threadpool.c

WIP tevent: API update tevent_threadpool_send()

WIP: job API

WIP: metzes attempt

WIP: add a test for tevent_threadpool_send/recv()

Signed-off-by: Ralph Boehme <slow@samba.org>

WIP: add pthreadpool and fncall_send to tevent

The idea is to use a pair of tevent_threadpool_send() and
tevent_threadpool_recv() to run a thread-safe function in a worker
thread.

Signed-off-by: Ralph Boehme <slow@samba.org>

Revert "feature"

This reverts commit d8e50a901e1ebbe99fe5c586b98646dee91fded1.

feature

Revert "eventfd-aio ..."

This reverts commit e669001b5b45a9d5ec36c48dd906d3de8504fa07.

eventfd-aio ...

TODO: tevent: version 0.9.37

* add tevent_common_invoke_*_handler() functions
* add tevent_context_same_loop() function
* add tevent_context_wrapper_create() infrastructure

tevent: add tevent_context_wrapper_create() infrastructure

This allows to specify wrapper tevent_contexts which adds the ability
to run functions before and after the event handler functions.

This can be used to implement impersonation hooks
or advanced debugging/profiling hooks.

tevent: split out tevent_common_invoke_fd_handler()

We'll remove _PRIVATE_ with the next release.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: split out tevent_common_invoke_immediate_handler()

We'll remove _PRIVATE_ with the next release.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: split out tevent_common_invoke_timer_handler()

As side effect this avoids tricks with an extra
tevent_common_timed_deny_destructor().

We'll remove the _PRIVATE_ with the next release.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: split out tevent_common_invoke_signal_handler()

As side effect this avoids tricks with tevent_se_exists_destructor() to
figure out if the event handler removed itself.

We'll remove _PRIVATE_ with the next release.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: simplify tevent_signal_destructor()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: use talloc_zero() in tevent_signal.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: simplify tevent_cleanup_pending_signal_handlers()

Calling tevent_signal_destructor() does the same as se->event_ctx is already
NULL.

This also makes sure we correctly cleanup the SA_SIGINFO array.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: add tevent_common_check_double_free() helper function

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: add tevent_threaded_schedule_immediate_destructor that just aborts

tevent: use _tevent_schedule_immediate() to move events from a thread to the main_ev

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: use struct initializers for tevent_immediate

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: use struct initializers for tevent_signal

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: use struct initializers for tevent_timer

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: use struct initializers for tevent_fd

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: make tevent_abort() available for backends

We'll remove the _PRIVATE_ with the next release.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent: allow tevent_abort() to cope with ev == NULL

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent/testsuite: return after torture_fail()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tevent.h: improve tevent_req documentation

Document tevent_req naming conventions.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

HACK drsuapi less debug

HACK!!!! _FAIL_IMMEDIATELY=1

TODO first check_user_ok admin_user

ctdb: Drop configuration file ctdbd.conf

Drop function loadconfig(), replacing uses with "load_system_config
ctdb".  Drop translation of old-style configuration to new
configuration file.  Drop export of debugging variables.  Drop
documentation and configuration examples.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu May 17 07:03:04 CEST 2018 on sn-devel-144

ctdb-tests: Switch local daemons to use new style configuration file

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-config: Add default ctdb.conf file

Install it in RPM.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-docs: Add example configuration files

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-docs: Add ctdb.conf(5) cross references and documentation tweaks

Minor updates to other manual pages for compatibility.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-docs: Add ctdb.conf(5)

This documents the new Samba-style configuration file.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Clean up tests to not expose script options

The tests still use the script options but the event scripts no longer
see them exported from the test infrastructure.  Testing now depends
on the event scripts successfully fetching the options from the
configuration file.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-scripts: Fetch recovery lock option from config file in 01.reclock

Put it in a function so it is easy to move to common code just in case
it is needed somewhere else.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-scripts: Fetch database options from config file in scripts

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-scripts: Add function ctdb_get_db_options()

This pulls database options from the configuration file, caches then
and makes the values available in scripts.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Add ctdb-config wrapper stub for event script tests

Create a shim helper around that simply invokes ctdb-config via its
real location.

This is needed because the event script tests set CTDB_HELPER_BINDIR
to the stubs directory because all other helpers used by event script
testing are currently stubs.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Add setup of ctdb.conf recovery lock setting

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Add setup of ctdb.conf database directory settings

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Add new variable CTDB_SCRIPTS_HELPER_BINDIR

This will always find a binary helper, as opposed to a script helper,
which currently lives under tools/ in the source tree.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-daemon: Drop most ctdbd command-line options

All except -i/--interactive.  This remaining popt option is now neatly
wrapped to fit in 80 columns.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-scripts: Translate old style options into new configuration file

This allows the relevant command-line options to be removed from the
daemon while still leaving the old ctdbd.conf options file in place.
It is a temporary measure to enable testing in an old testing
environment.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-daemon: Integrate configuration file handling

Testing is now broken because command-line options are no longer
respected.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-daemon: Implement ctdb configuration file loading

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tools: Add legacy config options to config tool

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-daemon: Define ctdbd legacy configuration file options

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tools: Add database config options to config tool

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-database: Define database configuration file options

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tools: Add cluster config options to config tool

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-cluster: Define cluster configuration file options

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tools: Add event daemon config options to config tool

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

ctdb-event: Add event daemon config file options

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

ctdb-daemon: Drop ctdbd --max-persistent-check-errors option

Leave the code with an internal default of 0.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-scripts: Drop CTDB_MAX_PERSISTENT_CHECK_ERRORS option

This must harken back to the days of yore when corrupt persistent
databases were an issue.  We haven't seen this used.  If CTDB fails to
start due to a corrupt persistent database then this database can be
removed by hand.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-daemon: Do not create database directories

These should be created at installation or, if non-standard, by the
administrator.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-tests: Create database directories for local daemons

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

ctdb-build: Create database directories during installation

Create and package.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

s4:torture: Do not leak file descriptor in smb2 oplock test

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu May 17 04:03:21 CEST 2018 on sn-devel-144

s4:torture: Do not leak memory in libsmbclient test

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

s3:libsmbclient: cleanup smbc_setWorkgroup() usage

It now takes a const char *. There's no need to use heap memory here.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

s3:libsmbclient: Use const for setting and getting strings

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

ctdb: Check return values of tevent_req_set_endtime()

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 17 01:09:46 CEST 2018 on sn-devel-144