ctdb: Check return values of tevent_req_set_endtime()

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 17 01:09:46 CEST 2018 on sn-devel-144

diff --git a/ctdb/client/client_control.c b/ctdb/client/client_control.c
index 1755eccf65d31ba91a7e380582fa2e8c2197fe9d..ab0aac8baf583a689e70dfb60f7e8fa03d2b9552 100644 (file)
--- a/ctdb/client/client_control.c
+++ b/ctdb/client/client_control.c
@@ -112,7 +112,9 @@ struct tevent_req *ctdb_client_control_send(TALLOC_CTX *mem_ctx,
        }
 
        if (!tevent_timeval_is_zero(&timeout)) {
-               tevent_req_set_endtime(req, ev, timeout);
+               if (!tevent_req_set_endtime(req, ev, timeout)) {
+                       return tevent_req_post(req, ev);
+               }
        }
 
        subreq = comm_write_send(state, ev, client->comm, buf, buflen);

diff --git a/ctdb/client/client_tunnel.c b/ctdb/client/client_tunnel.c
index 17b65469ae9cc15921ea05cd6d633474d674f0c0..0bd7a3aff8c371a61c0300c93072d340def43518 100644 (file)
--- a/ctdb/client/client_tunnel.c
+++ b/ctdb/client/client_tunnel.c
@@ -457,7 +457,9 @@ struct tevent_req *ctdb_tunnel_request_send(TALLOC_CTX *mem_ctx,
        }
 
        if (!tevent_timeval_is_zero(&timeout)) {
-               tevent_req_set_endtime(req, ev, timeout);
+               if (!tevent_req_set_endtime(req, ev, timeout)) {
+                       return tevent_req_post(req, ev);
+               }
        }
 
        subreq = comm_write_send(state, ev, tctx->client->comm,
@@ -619,7 +621,9 @@ struct tevent_req *ctdb_tunnel_reply_send(TALLOC_CTX *mem_ctx,
        }
 
        if (!tevent_timeval_is_zero(&timeout)) {
-               tevent_req_set_endtime(req, ev, timeout);
+               if (!tevent_req_set_endtime(req, ev, timeout)) {
+                       return tevent_req_post(req, ev);
+               }
        }
 
        subreq = comm_write_send(state, ev, tctx->client->comm, pkt, pkt_len);

diff --git a/ctdb/common/sock_client.c b/ctdb/common/sock_client.c
index ced705042a40cb4dcebe34e9102eb3fb84b18b3c..75f471fc5de7d9d493dfa264a3932478fd6d742d 100644 (file)
--- a/ctdb/common/sock_client.c
+++ b/ctdb/common/sock_client.c
@@ -247,7 +247,9 @@ struct tevent_req *sock_client_msg_send(TALLOC_CTX *mem_ctx,
        tevent_req_set_callback(subreq, sock_client_msg_done, req);
 
        if (! timeval_is_zero(&timeout)) {
-               tevent_req_set_endtime(req, ev, timeout);
+               if (!tevent_req_set_endtime(req, ev, timeout)) {
+                       return tevent_req_post(req, ev);
+               }
        }
 
        return req;