s3:smbd: Fix really ugly bool vs. int bug!!!
authorStefan Metzmacher <metze@samba.org>
Tue, 9 Feb 2010 17:54:41 +0000 (18:54 +0100)
committerStefan Metzmacher <metze@samba.org>
Tue, 9 Feb 2010 17:59:15 +0000 (18:59 +0100)
A comparison function for qsort needs to return an 'int'!
Otherwise you'll get random results depending on the compiler
and the architecture...

metze

source3/smbd/lanman.c

index 721883f775bd1634da7aedcb9c56b46bc6148e87..f673970ceca49308d2bf46023d9f0f5b7a39ec29 100644 (file)
@@ -1351,7 +1351,7 @@ static int fill_srv_info(struct srv_info_struct *service,
 }
 
 
-static bool srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
+static int srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
 {
 #undef strcasecmp
        return strcasecmp(s1->name,s2->name);
@@ -1515,7 +1515,7 @@ static bool api_RNetServerEnum2(connection_struct *conn, uint16 vuid,
        return True;
 }
 
-static bool srv_name_match(const char *n1, const char *n2)
+static int srv_name_match(const char *n1, const char *n2)
 {
        /*
         * [MS-RAP] footnote <88> for Section 3.2.5.15 says: