s3-selftest: fix return code for modprinter.pl -a.
authorGünther Deschner <gd@samba.org>
Thu, 18 Feb 2010 10:20:49 +0000 (11:20 +0100)
committerGünther Deschner <gd@samba.org>
Thu, 18 Feb 2010 10:23:59 +0000 (11:23 +0100)
Background is: the SetPrinter level 2 calls "addprinter command" an fails if a
share already existed (and the addprinter command returned a non-0 return code).
Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to
see if a share already exists before calling out the addprinter command.

Maybe one day, we need to have a "changeprinter command"...

Guenther

source3/script/tests/printing/modprinter.pl

index 406484188daf0283e69bc4fd185204959e1272dd..9e5e3292c6cad6ceba3041f1160b507773962bb9 100755 (executable)
@@ -95,7 +95,8 @@ while (<CONFIGFILE>) {
                if ($section eq $share_name) {
                        $found_section = 1;
                        if ($opt_add) {
-                               die("share $share_name already exists\n");
+                               exit 0;
+#                              die("share $share_name already exists\n");
                        }
                        if ($opt_delete) {
                                $within_section = 1;