s3: Remove string_sid_talloc

All but one call were pointless, so I think this API should go

diff --git a/source3/include/proto.h b/source3/include/proto.h
index c3f0dff46948fe712a1087297f0e8a1c47ab98c7..01372c258762ca60bc216376041c1e25307d4991 100644 (file)
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -1317,7 +1317,6 @@ char *sid_string_talloc(TALLOC_CTX *mem_ctx, const DOM_SID *sid);
 char *sid_string_dbg(const DOM_SID *sid);
 char *sid_string_tos(const DOM_SID *sid);
 bool string_to_sid(DOM_SID *sidout, const char *sidstr);
-DOM_SID *string_sid_talloc(TALLOC_CTX *mem_ctx, const char *sidstr);
 bool sid_append_rid(DOM_SID *sid, uint32 rid);
 bool sid_compose(DOM_SID *dst, const DOM_SID *domain_sid, uint32 rid);
 bool sid_split_rid(DOM_SID *sid, uint32 *rid);

diff --git a/source3/lib/util_sid.c b/source3/lib/util_sid.c
index a181502a89d1a254c36aface8eda0e9c16a91971..20c2663de95cff2701e55b5a79b92b1dedd40229 100644 (file)
--- a/source3/lib/util_sid.c
+++ b/source3/lib/util_sid.c
@@ -271,19 +271,6 @@ bool string_to_sid(DOM_SID *sidout, const char *sidstr)
        return True;
 }
 
-DOM_SID *string_sid_talloc(TALLOC_CTX *mem_ctx, const char *sidstr)
-{
-       DOM_SID *result = TALLOC_P(mem_ctx, DOM_SID);
-
-       if (result == NULL)
-               return NULL;
-
-       if (!string_to_sid(result, sidstr))
-               return NULL;
-
-       return result;
-}
-
 /*****************************************************************
  Add a rid to the end of a sid
 *****************************************************************/