librpc/idr Use the Samba3 notify.idl in common.

The extra fields in the structure that Samba4 does not use should not
bother it.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>

diff --git a/source3/librpc/idl/notify.idl b/librpc/idl/notify.idl
similarity index 98%
rename from source3/librpc/idl/notify.idl
rename to librpc/idl/notify.idl
index 0776ed107ccbe0012ef8448517598c3a577ebacd..845010601ea6b982a3717b2f756767c4505ef320 100644 (file)
--- a/source3/librpc/idl/notify.idl
+++ b/librpc/idl/notify.idl
@@ -41,7 +41,7 @@ interface notify
          The max_mask and max_mask_subdir at each depth is the
          bitwise or of the filters and subdir filters for all entries
          at that depth. This allows a depth to be quickly skipped if
-         no entries will match the target filter         
+         no entries will match the target filter
        */
        typedef struct {
                uint32 max_mask;

diff --git a/librpc/idl/wscript_build b/librpc/idl/wscript_build
index 1c5d6ec74606af0ec6e04797b0c9de2e2f02a94b..ffb7a9c808836d046fa2afe10424437c77652fce 100644 (file)
--- a/librpc/idl/wscript_build
+++ b/librpc/idl/wscript_build
@@ -10,6 +10,7 @@ bld.SAMBA_PIDL_LIST('PIDL',
                        dbgidl.idl dnsserver.idl echo.idl frsrpc.idl lsa.idl nbt.idl dns.idl
                        oxidresolver.idl samr.idl server_id.idl srvsvc.idl winreg.idl dcerpc.idl
                        drsblobs.idl efs.idl frstrans.idl mgmt.idl netlogon.idl
+                       notify.idl
                        policyagent.idl scerpc.idl svcctl.idl wkssvc.idl eventlog6.idl backupkey.idl
                        printcap.idl''',
                     options='--header --ndr-parser --samba3-ndr-server --server --client --python',

diff --git a/librpc/wscript_build b/librpc/wscript_build
index 56959062f21801dc469742628b98c5f94ed96fba..a68ce477dd2f93b61adb448ddb3528bef0313efd 100644 (file)
--- a/librpc/wscript_build
+++ b/librpc/wscript_build
@@ -202,6 +202,11 @@ bld.SAMBA_SUBSYSTEM('NDR_IDMAP',
        public_deps='ndr ndr-standard'
        )
 
+bld.SAMBA_SUBSYSTEM('NDR_NOTIFY',
+       source='gen_ndr/ndr_notify.c',
+       public_deps='ndr ndr-standard NDR_SERVER_ID NDR_FILE_ID'
+       )
+
 bld.SAMBA_SUBSYSTEM('NDR_NTLMSSP',
        source='ndr/ndr_ntlmssp.c gen_ndr/ndr_ntlmssp.c',
        public_deps='ndr ndr-standard'
@@ -312,7 +317,8 @@ bld.SAMBA_LIBRARY('ndr-standard',
        pc_files='ndr_standard.pc',
        deps='''NDR_SECURITY NDR_LSA NDR_SAMR NDR_NETLOGON NDR_EVENTLOG NDR_DFS
        NDR_NTSVCS NDR_SVCCTL NDR_INITSHUTDOWN NDR_WKSSVC NDR_SRVSVC NDR_WINREG
-       NDR_ECHO security NDR_DNS NDR_ATSVC NDR_SPOOLSS NDR_DSSETUP''',
+       NDR_ECHO security NDR_DNS NDR_ATSVC NDR_SPOOLSS NDR_DSSETUP
+        NDR_SERVER_ID NDR_NOTIFY''',
        public_deps='ndr',
        public_headers='gen_ndr/samr.h gen_ndr/ndr_samr.h gen_ndr/lsa.h gen_ndr/netlogon.h gen_ndr/atsvc.h gen_ndr/ndr_atsvc.h gen_ndr/ndr_svcctl.h gen_ndr/svcctl.h',
        header_path='gen_ndr'

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 311678d6bb90dbb83527adbc6c25a85332ba15dd..8165d2585c06c0d0daa9c18bb6f2bb52e3c875bb 100644 (file)
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -1604,7 +1604,6 @@ modules:: SHOWFLAGS $(MODULES)
 
 IDL_FILES = librpc/idl/messaging.idl \
            librpc/idl/libnetapi.idl \
-           librpc/idl/notify.idl \
            librpc/idl/wbint.idl \
            librpc/idl/perfcount.idl \
            librpc/idl/secrets.idl \

diff --git a/source3/librpc/idl/wscript_build b/source3/librpc/idl/wscript_build
index 97b14659d15447f848850d60e701f925fe343705..3e07542320db2d952db0b14e5c2727804352dc26 100644 (file)
--- a/source3/librpc/idl/wscript_build
+++ b/source3/librpc/idl/wscript_build
@@ -5,7 +5,7 @@ import os
 topinclude=os.path.join(bld.srcnode.abspath(), 'librpc/idl')
 
 bld.SAMBA_PIDL_LIST('PIDL',
-                    '''messaging.idl libnetapi.idl notify.idl
+                    '''messaging.idl libnetapi.idl
                        perfcount.idl secrets.idl libnet_join.idl''',
                     options='--includedir=%s --header --ndr-parser' % topinclude,
                     output_dir='../gen_ndr')

diff --git a/source3/librpc/wscript_build b/source3/librpc/wscript_build
index 7f18f032588bced4e66a090b3f9048b1b20a192f..a4af551e7f25859e38d9f716034442cb32c06a49 100644 (file)
--- a/source3/librpc/wscript_build
+++ b/source3/librpc/wscript_build
@@ -15,11 +15,6 @@ bld.SAMBA3_SUBSYSTEM('NDR_MESSAGING',
        public_deps='ndr NDR_SERVER_ID'
        )
 
-bld.SAMBA3_SUBSYSTEM('NDR_NOTIFY3',
-       source='gen_ndr/ndr_notify.c',
-       public_deps='ndr NDR_FILE_ID NDR_SERVER_ID'
-       )
-
 bld.SAMBA3_SUBSYSTEM('NDR_SECRETS',
        source='gen_ndr/ndr_secrets.c',
        public_deps='ndr'

diff --git a/source3/wscript_build b/source3/wscript_build
index b30c204ab3ef994163932740df44dee8a9a073e2..f09b8707f143bf4096bde4053e486a873885d3fd 100755 (executable)
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -888,7 +888,7 @@ bld.SAMBA3_LIBRARY('smbd_base',
                     PARAM_WITHOUT_REG samba3core LIBSMB POPT_SAMBA3 KRBCLIENT AVAHI
                     LIBMSRPC_GEN msrpc3 ads LIBADS_SERVER LIBADS_PRINTER
                     vfs vfs_default vfs_posixacl auth rpc LOCKING LIBAFS LIBAFS_SETTOKEN PROFILE
-                    PRINTING PRINTBACKEND NDR_XATTR NDR_NOTIFY3 REGFIO
+                    PRINTING PRINTBACKEND NDR_XATTR NDR_NOTIFY REGFIO
                     smbconf REG_FULL FNAME_UTIL
                     LIBCLI_SAMR LIBCLI_LSA3 LIBRPCCLI_NETLOGON LIBCLI_SPOOLSS
                     RPC_NDR_SRVSVC npa_tstream INIT_NETLOGON INIT_SAMR

diff --git a/source4/librpc/idl/s4_notify.idl b/source4/librpc/idl/s4_notify.idl
deleted file mode 100644 (file)
index 1d4c334..0000000
--- a/source4/librpc/idl/s4_notify.idl
+++ /dev/null
@@ -1,58 +0,0 @@
-#include "idl_types.h"
-
-/*
-   IDL structures for notify change code
-
-   this defines the structures used in the notify database code, and
-   the change notify buffers
-*/
-
-import "server_id.idl";
-
-[
-  pointer_default(unique)
-]
-interface notify
-{
-
-       /* structure used in the notify database */
-       typedef [public] struct {
-               server_id server;
-               uint32 filter; /* filter to apply in this directory */
-               uint32 subdir_filter; /* filter to apply in child directories */
-               utf8string path;
-               uint32 path_len; /* saves some computation on search */
-               pointer private_data;
-       } notify_entry;
-
-       /*
-         to allow for efficient search for matching entries, we
-         divide them by the directory depth, with a separate array
-         per depth. The entries within each depth are sorted by path,
-         allowing for a bisection search.
-
-         The max_mask and max_mask_subdir at each depth is the
-         bitwise or of the filters and subdir filters for all entries
-         at that depth. This allows a depth to be quickly skipped if
-         no entries will match the target filter
-       */
-       typedef struct {
-               uint32 max_mask;
-               uint32 max_mask_subdir;
-               uint32 num_entries;
-               notify_entry entries[num_entries];
-       } notify_depth;
-
-       typedef [public] struct {
-               uint32 num_depths;
-               notify_depth depth[num_depths];
-       } notify_array;
-
-       /* structure sent between servers in notify messages */
-       typedef [public] struct {
-               uint32 action;
-               utf8string path;
-               pointer private_data;
-       } notify_event;
-
-}

diff --git a/source4/librpc/idl/wscript_build b/source4/librpc/idl/wscript_build
index a35dc79768837f3f30eeb4d1df8daa2baa9ee042..59b16766ea5021140f6931bfbc6309aed9a87dcd 100644 (file)
--- a/source4/librpc/idl/wscript_build
+++ b/source4/librpc/idl/wscript_build
@@ -5,7 +5,7 @@ import os
 topinclude=os.path.join(bld.srcnode.abspath(), 'librpc/idl')
 
 bld.SAMBA_PIDL_LIST('PIDL',
-                    source='''irpc.idl nfs4acl.idl s4_notify.idl ntp_signd.idl
+                    source='''irpc.idl nfs4acl.idl ntp_signd.idl
                               opendb.idl sasl_helpers.idl winbind.idl
                               winsif.idl winsrepl.idl winstation.idl''',
                     options="--includedir=%s --header --ndr-parser --client --python --server" % topinclude,

diff --git a/source4/librpc/wscript_build b/source4/librpc/wscript_build
index efde567bf8b96ce726c3e6011875e8a6a69a4662..39541b6a33b5bf9fb1ecdc84f4bd59163a6ffa13 100755 (executable)
--- a/source4/librpc/wscript_build
+++ b/source4/librpc/wscript_build
@@ -43,12 +43,6 @@ bld.SAMBA_SUBSYSTEM('NDR_OPENDB',
        )
 
 
-bld.SAMBA_SUBSYSTEM('NDR_NOTIFY',
-       source='gen_ndr/ndr_s4_notify.c',
-       public_deps='ndr NDR_SERVER_ID'
-       )
-
-
 bld.SAMBA_SUBSYSTEM('NDR_NTP_SIGND',
        source='gen_ndr/ndr_ntp_signd.c',
        public_deps='ndr'
@@ -69,7 +63,7 @@ bld.SAMBA_SUBSYSTEM('NDR_WINBIND',
 # create a grouping library to consolidate our samba4 specific NDR code
 bld.SAMBA_LIBRARY('ndr-samba4',
        source=[],
-       deps='NDR_WINBIND NDR_IRPC NDR_NFS4ACL NDR_OPENDB NDR_NOTIFY ndr-table',
+       deps='NDR_WINBIND NDR_IRPC NDR_NFS4ACL NDR_OPENDB ndr-table',
        private_library=True,
        grouping_library=True
        )

diff --git a/source4/ntvfs/common/notify.c b/source4/ntvfs/common/notify.c
index 7260759341c5b2b6fc6566634187d93c53cc5150..e3335feb9112d0d7fe530e02c8f2451720fb8ae2 100644 (file)
--- a/source4/ntvfs/common/notify.c
+++ b/source4/ntvfs/common/notify.c
@@ -30,7 +30,7 @@
 #include "messaging/messaging.h"
 #include "lib/util/tdb_wrap.h"
 #include "lib/messaging/irpc.h"
-#include "librpc/gen_ndr/ndr_s4_notify.h"
+#include "librpc/gen_ndr/ndr_notify.h"
 #include "../lib/util/dlinklist.h"
 #include "ntvfs/common/ntvfs_common.h"
 #include "ntvfs/sysdep/sys_notify.h"

diff --git a/source4/ntvfs/ntvfs.h b/source4/ntvfs/ntvfs.h
index 1716687e5fbde8a9e13f9a73b00919d7c1d4e8d7..463acc3c80103f0d2b21df2d4add8f73af8edb1b 100644 (file)
--- a/source4/ntvfs/ntvfs.h
+++ b/source4/ntvfs/ntvfs.h
@@ -332,7 +332,7 @@ struct ntvfs_critical_sizes {
 
 struct imessaging_context;
 #include "librpc/gen_ndr/security.h"
-#include "librpc/gen_ndr/s4_notify.h"
+#include "librpc/gen_ndr/notify.h"
 #include "ntvfs/ntvfs_proto.h"
 
 #endif /* _NTVFS_H_ */

diff --git a/source4/ntvfs/sysdep/sys_notify.h b/source4/ntvfs/sysdep/sys_notify.h
index c474d4e6a023c66adf1fe92c6bbca2ce4bf6d9c3..d912a9bdaf63c6aab370044e469020a693576769 100644 (file)
--- a/source4/ntvfs/sysdep/sys_notify.h
+++ b/source4/ntvfs/sysdep/sys_notify.h
@@ -17,7 +17,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#include "librpc/gen_ndr/s4_notify.h"
+#include "librpc/gen_ndr/notify.h"
 #include "param/share.h"
 
 struct sys_notify_context;