s4/auth/pygensec: don't segfault when reporting bad types
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sun, 7 Jul 2019 05:23:23 +0000 (17:23 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 22 Jul 2019 22:20:26 +0000 (22:20 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/auth/gensec/pygensec.c

index b2c1e9c279a8d85a613e97bcbfa1f41ad94998c2..11a1c7bca31ec12a4d04699aea3dc6e8e848fc7c 100644 (file)
@@ -281,9 +281,10 @@ static PyObject *py_gensec_set_credentials(PyObject *self, PyObject *args)
 
        creds = PyCredentials_AsCliCredentials(py_creds);
        if (!creds) {
-               PyErr_Format(PyExc_TypeError,
-                            "Expected samba.credentaials for credentials argument got  %s",
-                            talloc_get_name(pytalloc_get_ptr(py_creds)));
+               PyErr_Format(
+                       PyExc_TypeError,
+                       "Expected samba.credentials for credentials argument, "
+                       "got %s", pytalloc_get_name(py_creds));
                return NULL;
        }