Fix 1125553 Buffer not null terminated
authorVolker Lendecke <vl@samba.org>
Sat, 7 Mar 2015 10:29:21 +0000 (10:29 +0000)
committerMartin Schwenke <martin@meltin.net>
Wed, 24 Feb 2016 05:59:35 +0000 (16:59 +1100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
(Imported from commit 621bd0784290f24e229caf0590206805f6f2e75c)

common/system_linux.c

index 8848b55eac4a23955020d2995894898b3bd34103..79d1a83ff1023880b6f23fd9667210252d473082 100644 (file)
@@ -100,7 +100,7 @@ int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
                }
 
                DEBUG(DEBUG_DEBUG, (__location__ " Created SOCKET FD:%d for sending arp\n", s));
-               strncpy(ifr.ifr_name, iface, sizeof(ifr.ifr_name)-1);
+               strlcpy(ifr.ifr_name, iface, sizeof(ifr.ifr_name));
                if (ioctl(s, SIOCGIFINDEX, &ifr) < 0) {
                        DEBUG(DEBUG_CRIT,(__location__ " interface '%s' not found\n", iface));
                        close(s);