s3:registry: don't leak the old contents when updating the value cache (cherry picked...

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 6bdd18be7ce48668f5f9d51f7997f35196b87102..c6e6d8e27e644289413be7ba27a0b079f7ff6997 100644 (file)
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -89,6 +89,7 @@ static WERROR fill_value_cache(struct registry_key *key)
                }
        }
 
+       TALLOC_FREE(key->values);
        werr = regval_ctr_init(key, &(key->values));
        W_ERROR_NOT_OK_RETURN(werr);