s3:smbd: don't call smbd_terminate_connection in smb2_validate_message_id() (bug...

Only return false and the caller will terminate the connection.

metze
(cherry picked from commit 02d83d8fd4d21825110fd7da1ccb570a26e66ca6)

Part of a fix for bug #8476 (Samba asserts when SMB2 client breaks the crediting
rules.)

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 4de4ef5fe2f1a0fb82ac24bd2c78d6c79fe1c633..aa9f22b9a8f0e3d23e6287f0bfec43e7da877854 100644 (file)
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -320,8 +320,9 @@ static bool smb2_validate_message_id(struct smbd_server_connection *sconn,
        }
 
        if (sconn->smb2.credits_granted == 0) {
-               smbd_server_connection_terminate(sconn, "smb2_validate_message_id: "
-                       "terminating connection: client used more credits than granted\n");
+               DEBUG(0,("smb2_validate_message_id: client used more "
+                        "credits than granted message_id (%llu)\n",
+                        (unsigned long long)message_id));
                return false;
        }