build: change compile flags on mac os x if we face pb with common symbols

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat Nov 27 18:02:41 CET 2010 on sn-devel-104

diff --git a/source4/wscript b/source4/wscript
index 80916f5579ddc88a5617349934fab650242317a2..48f340cf09bf82163c6ead046429796b8c308771 100644 (file)
--- a/source4/wscript
+++ b/source4/wscript
@@ -87,8 +87,10 @@ def configure(conf):
     conf.check_python_headers(mandatory=True)
 
     if sys.platform == 'darwin' and not conf.env['HAVE_ENVIRON_DECL']:
-        if not conf.CHECK_SHLIB_W_PYTHON("Checking if -single_module is not needed"):
-            conf.env.append_value('shlib_LINKFLAGS', ['-single_module'])
+        # Mac OSX needs to have this and it's also needed that the python is compiled with this
+        # otherwise you face errors about common symbols
+        if not conf.CHECK_SHLIB_W_PYTHON("Checking if -fno-common is needed"):
+            conf.ADD_CFLAGS('-fno-common')
         if not conf.CHECK_SHLIB_W_PYTHON("Checking if -undefined dynamic_lookup is not need"):
             conf.env.append_value('shlib_LINKFLAGS', ['-undefined', 'dynamic_lookup'])
     if int(conf.env['PYTHON_VERSION'][0]) >= 3: