s4:libcli/rap: use talloc_zero() and initialize everything
authorStefan Metzmacher <metze@samba.org>
Fri, 16 Dec 2011 10:18:04 +0000 (11:18 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 16 Dec 2011 10:31:48 +0000 (11:31 +0100)
metze

source4/libcli/rap/rap.c

index 007c52037f446075560ad188da550f592cafe672..bebe9fb1dd14ce1149d70c8a355a3147ad89a846 100644 (file)
@@ -30,18 +30,13 @@ struct rap_call *new_rap_cli_call(TALLOC_CTX *mem_ctx, uint16_t callno)
 {
        struct rap_call *call;
 
-       call = talloc(mem_ctx, struct rap_call);
-
-       if (call == NULL)
+       call = talloc_zero(mem_ctx, struct rap_call);
+       if (call == NULL) {
                return NULL;
+       }
 
        call->callno = callno;
        call->rcv_paramlen = 4;
-       call->rcv_datalen = 0;
-
-       call->paramdesc = NULL;
-       call->datadesc = NULL;
-       call->auxdatadesc = NULL;
 
        call->ndr_push_param = ndr_push_init_ctx(mem_ctx);
        call->ndr_push_param->flags = RAPNDR_FLAGS;