small optimizations for shadowcopy2 module

- remove a compiler warning
- replace strlen usage

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>

diff --git a/source3/modules/vfs_shadow_copy2.c b/source3/modules/vfs_shadow_copy2.c
index 34792de97b4d60fa7e53a317d084d9b46cf3bd98..502f815235cd74aa0176aec17dcd64a4e624af6d 100644 (file)
--- a/source3/modules/vfs_shadow_copy2.c
+++ b/source3/modules/vfs_shadow_copy2.c
@@ -436,7 +436,7 @@ static char *convert_shadow2_name(vfs_handle_struct *handle, const char *fname,
        }
 
        prefix = talloc_asprintf(tmp_ctx, "%s/@GMT-", snapdir);
-       if (strncmp(fname, prefix, strlen(prefix)) == 0) {
+       if (strncmp(fname, prefix, (talloc_get_size(prefix)-1)) == 0) {
                /* this looks like as we have already normalized it, leave it untouched*/
                talloc_free(tmp_ctx);
                return talloc_strdup(handle->data, fname);
@@ -659,7 +659,7 @@ static char *shadow_copy2_realpath(vfs_handle_struct *handle,
 
        if (shadow_copy2_match_name(fname, &gmt)
            && (gmt[GMT_NAME_LEN] == '\0')) {
-               char *copy, *result;
+               char *copy;
 
                copy = talloc_strdup(talloc_tos(), fname);
                if (copy == NULL) {