s4:drepl_notify: hide some bugs from the make test output
authorStefan Metzmacher <metze@samba.org>
Fri, 9 Jul 2010 14:27:34 +0000 (16:27 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 9 Jul 2010 14:43:17 +0000 (16:43 +0200)
It's useless to get messages like this every few seconds:

dreplsrv_notify: Failed to send DsReplicaSync to
edbf4745-2966-49a7-8653-99200f1c9430._msdcs.samba2003.example.com for
CN=Configuration,DC=samba2003,DC=example,DC=com -
NT_STATUS_OBJECT_NAME_NOT_FOUND : WERR_BADFILE

We have a non bug regarding non-linked DN attributes
and changes of the target DN.

metze

source4/dsdb/repl/drepl_notify.c

index 8a39745a4e3fce8a2678aeaedb0875b0a6aa15e0..6b8190173e24c1d7cc3e89a301d1201ca5c01187 100644 (file)
@@ -197,7 +197,18 @@ static void dreplsrv_notify_op_callback(struct tevent_req *subreq)
                unsigned int msg_debug_level = 0;
                werr = ntstatus_to_werror(status);
                if (W_ERROR_EQUAL(werr, WERR_BADFILE)) {
-                       msg_debug_level = 1;
+                       /*
+                        * TODO:
+                        *
+                        * we should better fix the bug regarding
+                        * non-linked attribute handling, instead
+                        * of just hiding the failures.
+                        *
+                        * we should also remove the dc from our repsTo
+                        * if it failed to often, instead of retrying
+                        * every few seconds
+                        */
+                       msg_debug_level = 2;
                }
 
                DEBUG(msg_debug_level,