s4: Add comments about setup_secrets

Comments are to inform people that this function should not handle
transaction within the function as it is mainly used in provision and
that we want to commit secrets only if all the action on secrets have
worked.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>

diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py
index c46c290ae10ecfe7cd9947f59cfbc163ba92f7a0..5aaa833030d69cdfe43bdb5bacfab9a1d6fd4a9d 100644 (file)
--- a/source4/scripting/python/samba/provision.py
+++ b/source4/scripting/python/samba/provision.py
@@ -743,6 +743,8 @@ def secretsdb_setup_dns(secretsdb, setup_path, private_dir,
 
 def setup_secretsdb(path, setup_path, session_info, backend_credentials, lp):
     """Setup the secrets database.
+       This function does not handle exceptions and transaction on purpose,
+       it's up to the caller to do this job.
 
     :param path: Path to the secrets database.
     :param setup_path: Get the path to a setup file.