Add a comment regarding strwicmp only being an ASCII string compare

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/lib/util/util_str_common.c b/lib/util/util_str_common.c
index 20682f9935549e9313d8551a32803fda66b2a8ff..0933e183c8063681127e3ce8a389b631b22ed3a7 100644 (file)
--- a/lib/util/util_str_common.c
+++ b/lib/util/util_str_common.c
@@ -24,7 +24,7 @@
 #include "includes.h"
 
 /**
-Do a case-insensitive, whitespace-ignoring string compare.
+Do a case-insensitive, whitespace-ignoring ASCII string compare.
 **/
 _PUBLIC_ int strwicmp(const char *psz1, const char *psz2)
 {
@@ -43,6 +43,12 @@ _PUBLIC_ int strwicmp(const char *psz1, const char *psz2)
                        psz1++;
                while (isspace((int)*psz2))
                        psz2++;
+
+               /*
+                * This does not do a genuine multi-byte comparison,
+                * instead it just uses the fast-path for ASCII in
+                * these common routines
+                */
                if (toupper_m((unsigned char)*psz1) != toupper_m((unsigned char)*psz2)
                    || *psz1 == '\0'
                    || *psz2 == '\0')