ntlm_auth: Remove two uses of hex_encode()
authorVolker Lendecke <vl@samba.org>
Fri, 8 May 2015 10:12:21 +0000 (10:12 +0000)
committerJeremy Allison <jra@samba.org>
Tue, 12 May 2015 23:44:20 +0000 (01:44 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/utils/ntlm_auth.c

index f44e782f66473dc9166b3e2989686a61bebee2f5..f7c95ebff7029d34523db45d8a7a6dbe85c24554 100644 (file)
@@ -796,8 +796,6 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                                SAFE_FREE(error_string);
                        } else {
                                static char zeros[16];
-                               char *hex_lm_key;
-                               char *hex_user_session_key;
 
                                mux_printf(mux_id, "Authenticated: Yes\n");
 
@@ -805,22 +803,22 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                                    && lm_key.length 
                                    && (memcmp(zeros, lm_key.data, 
                                                                lm_key.length) != 0)) {
-                                       hex_encode(lm_key.data,
-                                                  lm_key.length,
-                                                  &hex_lm_key);
+                                       char hex_lm_key[lm_key.length*2+1];
+                                       hex_encode_buf(hex_lm_key, lm_key.data,
+                                                      lm_key.length);
                                        mux_printf(mux_id, "LANMAN-Session-Key: %s\n", hex_lm_key);
-                                       SAFE_FREE(hex_lm_key);
                                }
 
                                if (ntlm_server_1_user_session_key 
                                    && user_session_key.length 
                                    && (memcmp(zeros, user_session_key.data, 
                                               user_session_key.length) != 0)) {
-                                       hex_encode(user_session_key.data, 
-                                                  user_session_key.length, 
-                                                  &hex_user_session_key);
+                                       char hex_user_session_key[
+                                               user_session_key.length*2+1];
+                                       hex_encode_buf(hex_user_session_key,
+                                                      user_session_key.data,
+                                                      user_session_key.length);
                                        mux_printf(mux_id, "User-Session-Key: %s\n", hex_user_session_key);
-                                       SAFE_FREE(hex_user_session_key);
                                }
                        }
                }