gensec: recv_handler can't be NULL at that point.
authorAndreas Schneider <asn@samba.org>
Mon, 25 Feb 2013 14:41:23 +0000 (15:41 +0100)
committerDavid Disseldorp <ddiss@suse.de>
Tue, 5 Mar 2013 22:30:05 +0000 (23:30 +0100)
We probably want to segfault here if it is NULL.

Reviewed-by: David Disseldorp <ddiss@samba.org>
source4/auth/gensec/socket.c

index 99b4108a398128ff014d8d747d49936ba0aa6449..c89e080232331ac247696fe2bb68e8fbc777e21c 100644 (file)
@@ -111,7 +111,7 @@ static void gensec_socket_trigger_read(struct tevent_context *ev,
        /* It may well be that, having run the recv handler, we still
         * have even more data waiting for us! 
         */
-       if (gensec_socket->read_buffer.length && gensec_socket->recv_handler) {
+       if (gensec_socket->read_buffer.length > 0) {
                /* Schedule this funcion to run again */
                tevent_add_timer(gensec_socket->ev, gensec_socket, timeval_zero(), 
                                gensec_socket_trigger_read, gensec_socket);