selftest: Output error when samba_tool user command fails
authorMatthieu Patou <mat@matws.net>
Sun, 5 May 2013 22:37:00 +0000 (15:37 -0700)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 6 May 2013 09:05:29 +0000 (21:05 +1200)
It should help to debug why is it failing on some hosts in the build
farm (ie. sn-devel)
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/samba_tool/user.py

index 33344cd3d318b6c7f03dad0b23e83187bf48b637..89fa22b812413147d4f81cdebaca4c97a38dbab3 100644 (file)
@@ -232,7 +232,8 @@ class UserCmdTestCase(SambaToolCmdTest):
                                                 "-H", "ldap://%s" % os.environ["DC_SERVER"],
                                                 "-U%s%%%s" % (os.environ["DC_USERNAME"], os.environ["DC_PASSWORD"]))
 
-        self.assertCmdSuccess(result)
+        msg = "command should return %s" % err
+        self.assertCmdSuccess(result, msg)
         self.assertEquals(err,"","Shouldn't be any error messages")
         self.assertIn("User '%s' created successfully" % user["name"], out)
 
@@ -261,7 +262,8 @@ class UserCmdTestCase(SambaToolCmdTest):
                                                 "-H", "ldap://%s" % os.environ["DC_SERVER"],
                                                 "-U%s%%%s" % (os.environ["DC_USERNAME"], os.environ["DC_PASSWORD"]))
 
-        self.assertCmdSuccess(result)
+        msg = "command should return %s" % err
+        self.assertCmdSuccess(result, msg)
         self.assertEquals(err,"","Shouldn't be any error messages")
         self.assertIn("User '%s' created successfully" % user["name"], out)