pidl/Samba4::Header: we don't need to check if (defined($enum->{ELEMENTS})) twice
authorStefan Metzmacher <metze@samba.org>
Thu, 24 Jan 2008 13:57:30 +0000 (14:57 +0100)
committerStefan Metzmacher <metze@samba.org>
Thu, 24 Jan 2008 13:57:30 +0000 (14:57 +0100)
metze

source/pidl/lib/Parse/Pidl/Samba4/Header.pm

index 2b3a9df80f3b128a4701143a67c3c631aa290022..b2d5126d1d9826fcac409f2942e6d3a501d589e8 100644 (file)
@@ -131,27 +131,25 @@ sub HeaderEnum($$)
                my $count = 0;
                my $with_val = 0;
                my $without_val = 0;
-               if (defined($enum->{ELEMENTS})) {
-                       pidl " { __donnot_use_enum_$name=0x7FFFFFFF}\n";
-                       foreach my $e (@{$enum->{ELEMENTS}}) {
-                               my $t = "$e";
-                               my $name;
-                               my $value;
-                               if ($t =~ /(.*)=(.*)/) {
-                                       $name = $1;
-                                       $value = $2;
-                                       $with_val = 1;
-                                       fatal($e->{ORIGINAL}, "you can't mix enum member with values and without values!")
-                                               unless ($without_val == 0);
-                               } else {
-                                       $name = $t;
-                                       $value = $count++;
-                                       $without_val = 1;
-                                       fatal($e->{ORIGINAL}, "you can't mix enum member with values and without values!")
-                                               unless ($with_val == 0);
-                               }
-                               pidl "#define $name ( $value )\n";
+               pidl " { __donnot_use_enum_$name=0x7FFFFFFF}\n";
+               foreach my $e (@{$enum->{ELEMENTS}}) {
+                       my $t = "$e";
+                       my $name;
+                       my $value;
+                       if ($t =~ /(.*)=(.*)/) {
+                               $name = $1;
+                               $value = $2;
+                               $with_val = 1;
+                               fatal($e->{ORIGINAL}, "you can't mix enum member with values and without values!")
+                                       unless ($without_val == 0);
+                       } else {
+                               $name = $t;
+                               $value = $count++;
+                               $without_val = 1;
+                               fatal($e->{ORIGINAL}, "you can't mix enum member with values and without values!")
+                                       unless ($with_val == 0);
                        }
+                       pidl "#define $name ( $value )\n";
                }
                pidl "#endif\n";
        }