Apply same logic fix for #4308 Excel save operation corrupts file ACLs
[metze/samba/wip.git] / source / modules / nfs4_acls.c
1 /*
2  * NFS4 ACL handling
3  *
4  * Copyright (C) Jim McDonough, 2006
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
19  */
20
21 #include "includes.h"
22 #include "nfs4_acls.h"
23
24 #define SMBACL4_PARAM_TYPE_NAME "nfs4"
25
26 #define SMB_ACE4_INT_MAGIC 0x76F8A967
27 typedef struct _SMB_ACE4_INT_T
28 {
29         uint32  magic;
30         SMB_ACE4PROP_T  prop;
31         void    *next;
32 } SMB_ACE4_INT_T;
33
34 #define SMB_ACL4_INT_MAGIC 0x29A3E792
35 typedef struct _SMB_ACL4_INT_T
36 {
37         uint32  magic;
38         uint32  naces;
39         SMB_ACE4_INT_T  *first;
40         SMB_ACE4_INT_T  *last;
41 } SMB_ACL4_INT_T;
42
43 extern struct current_user current_user;
44 extern int try_chown(connection_struct *conn, const char *fname, uid_t uid, gid_t gid);
45 extern BOOL unpack_nt_owners(int snum, uid_t *puser, gid_t *pgrp,
46         uint32 security_info_sent, SEC_DESC *psd);
47
48 static SMB_ACL4_INT_T *get_validated_aclint(SMB4ACL_T *acl)
49 {
50         SMB_ACL4_INT_T *aclint = (SMB_ACL4_INT_T *)acl;
51         if (acl==NULL)
52         {
53                 DEBUG(2, ("acl is NULL\n"));
54                 errno = EINVAL;
55                 return NULL;
56         }
57         if (aclint->magic!=SMB_ACL4_INT_MAGIC)
58         {
59                 DEBUG(2, ("aclint bad magic 0x%x\n", aclint->magic));
60                 errno = EINVAL;
61                 return NULL;
62         }
63         return aclint;
64 }
65
66 static SMB_ACE4_INT_T *get_validated_aceint(SMB4ACE_T *ace)
67 {
68         SMB_ACE4_INT_T *aceint = (SMB_ACE4_INT_T *)ace;
69         if (ace==NULL)
70         {
71                 DEBUG(2, ("ace is NULL\n"));
72                 errno = EINVAL;
73                 return NULL;
74         }
75         if (aceint->magic!=SMB_ACE4_INT_MAGIC)
76         {
77                 DEBUG(2, ("aceint bad magic 0x%x\n", aceint->magic));
78                 errno = EINVAL;
79                 return NULL;
80         }
81         return aceint;
82 }
83
84 SMB4ACL_T *smb_create_smb4acl(void)
85 {
86         TALLOC_CTX *mem_ctx = main_loop_talloc_get();
87         SMB_ACL4_INT_T  *acl = (SMB_ACL4_INT_T *)TALLOC_SIZE(mem_ctx, sizeof(SMB_ACL4_INT_T));
88         if (acl==NULL)
89         {
90                 DEBUG(0, ("TALLOC_SIZE failed\n"));
91                 errno = ENOMEM;
92                 return NULL;
93         }
94         memset(acl, 0, sizeof(SMB_ACL4_INT_T));
95         acl->magic = SMB_ACL4_INT_MAGIC;
96         /* acl->first, last = NULL not needed */
97         return (SMB4ACL_T *)acl;
98 }
99
100 SMB4ACE_T *smb_add_ace4(SMB4ACL_T *acl, SMB_ACE4PROP_T *prop)
101 {
102         SMB_ACL4_INT_T *aclint = get_validated_aclint(acl);
103         TALLOC_CTX *mem_ctx = main_loop_talloc_get();
104         SMB_ACE4_INT_T *ace;
105
106         ace = (SMB_ACE4_INT_T *)TALLOC_SIZE(mem_ctx, sizeof(SMB_ACE4_INT_T));
107         if (ace==NULL)
108         {
109                 DEBUG(0, ("TALLOC_SIZE failed\n"));
110                 errno = ENOMEM;
111                 return NULL;
112         }
113         memset(ace, 0, sizeof(SMB_ACE4_INT_T));
114         ace->magic = SMB_ACE4_INT_MAGIC;
115         /* ace->next = NULL not needed */
116         memcpy(&ace->prop, prop, sizeof(SMB_ACE4PROP_T));
117
118         if (aclint->first==NULL)
119         {
120                 aclint->first = ace;
121                 aclint->last = ace;
122         } else {
123                 aclint->last->next = (void *)ace;
124                 aclint->last = ace;
125         }
126         aclint->naces++;
127
128         return (SMB4ACE_T *)ace;
129 }
130
131 SMB_ACE4PROP_T *smb_get_ace4(SMB4ACE_T *ace)
132 {
133         SMB_ACE4_INT_T *aceint = get_validated_aceint(ace);
134         if (aceint==NULL)
135                 return NULL;
136
137         return &aceint->prop;
138 }
139
140 SMB4ACE_T *smb_next_ace4(SMB4ACE_T *ace)
141 {
142         SMB_ACE4_INT_T *aceint = get_validated_aceint(ace);
143         if (aceint==NULL)
144                 return NULL;
145
146         return (SMB4ACE_T *)aceint->next;
147 }
148
149 SMB4ACE_T *smb_first_ace4(SMB4ACL_T *acl)
150 {
151         SMB_ACL4_INT_T *aclint = get_validated_aclint(acl);
152         if (aclint==NULL)
153                 return NULL;
154
155         return (SMB4ACE_T *)aclint->first;
156 }
157
158 uint32 smb_get_naces(SMB4ACL_T *acl)
159 {
160         SMB_ACL4_INT_T *aclint = get_validated_aclint(acl);
161         if (aclint==NULL)
162                 return 0;
163
164         return aclint->naces;
165 }
166
167 static int smbacl4_GetFileOwner(files_struct *fsp, SMB_STRUCT_STAT *psbuf)
168 {
169         memset(psbuf, 0, sizeof(SMB_STRUCT_STAT));
170         if (fsp->is_directory || fsp->fh->fd == -1) {
171                 /* Get the stat struct for the owner info. */
172                 if (SMB_VFS_STAT(fsp->conn,fsp->fsp_name, psbuf) != 0)
173                 {
174                         DEBUG(8, ("SMB_VFS_STAT failed with error %s\n",
175                                 strerror(errno)));
176                         return -1;
177                 }
178         } else {
179                 if (SMB_VFS_FSTAT(fsp,fsp->fh->fd, psbuf) != 0)
180                 {
181                         DEBUG(8, ("SMB_VFS_FSTAT failed with error %s\n",
182                                 strerror(errno)));
183                         return -1;
184                 }
185         }
186
187         return 0;
188 }
189
190 static BOOL smbacl4_nfs42win(SMB4ACL_T *acl, /* in */
191         DOM_SID *psid_owner, /* in */
192         DOM_SID *psid_group, /* in */
193         SEC_ACE **ppnt_ace_list, /* out */
194         int *pgood_aces /* out */
195 )
196 {
197         SMB_ACL4_INT_T *aclint = (SMB_ACL4_INT_T *)acl;
198         SMB_ACE4_INT_T *aceint;
199         SEC_ACE *nt_ace_list = NULL;
200         int good_aces = 0;
201         TALLOC_CTX *mem_ctx = main_loop_talloc_get();
202
203         DEBUG(10, ("smbacl_nfs42win entered"));
204
205         aclint = get_validated_aclint(acl);
206         if (aclint==NULL)
207                 return False;
208
209         if (aclint->naces) {
210                 nt_ace_list = (SEC_ACE *)TALLOC_SIZE(mem_ctx, aclint->naces * sizeof(SEC_ACE));
211                 if (nt_ace_list==NULL)
212                 {
213                         DEBUG(10, ("talloc error"));
214                         errno = ENOMEM;
215                         return False;
216                 }
217                 memset(nt_ace_list, 0, aclint->naces * sizeof(SEC_ACE));
218         } else {
219                 nt_ace_list = NULL;
220         }
221
222         for (aceint=aclint->first; aceint!=NULL; aceint=(SMB_ACE4_INT_T *)aceint->next) {
223                 SEC_ACCESS mask;
224                 DOM_SID sid;
225                 SMB_ACE4PROP_T  *ace = &aceint->prop;
226
227                 DEBUG(10, ("magic: 0x%x, type: %d, iflags: %x, flags: %x, mask: %x, "
228                         "who: %d\n", aceint->magic, ace->aceType, ace->flags,
229                         ace->aceFlags, ace->aceMask, ace->who.id));
230
231                 SMB_ASSERT(aceint->magic==SMB_ACE4_INT_MAGIC);
232
233                 if (ace->flags & SMB_ACE4_ID_SPECIAL) {
234                         switch (ace->who.special_id) {
235                         case SMB_ACE4_WHO_OWNER:
236                                 sid_copy(&sid, psid_owner);
237                                 break;
238                         case SMB_ACE4_WHO_GROUP:
239                                 sid_copy(&sid, psid_group);
240                                 break;
241                         case SMB_ACE4_WHO_EVERYONE:
242                                 sid_copy(&sid, &global_sid_World);
243                                 break;
244                         default:
245                                 DEBUG(8, ("invalid special who id %d "
246                                         "ignored\n", ace->who.special_id));
247                         }
248                 } else {
249                         if (ace->aceFlags & SMB_ACE4_IDENTIFIER_GROUP) {
250                                 gid_to_sid(&sid, ace->who.gid);
251                         } else {
252                                 uid_to_sid(&sid, ace->who.uid);
253                         }
254                 }
255                 DEBUG(10, ("mapped %d to %s\n", ace->who.id,
256                         sid_string_static(&sid)));
257
258                 init_sec_access(&mask, ace->aceMask);
259                 init_sec_ace(&nt_ace_list[good_aces++], &sid,
260                         ace->aceType, mask,
261                         ace->aceFlags & 0xf);
262         }
263
264         *ppnt_ace_list = nt_ace_list;
265         *pgood_aces = good_aces;
266
267         return True;
268 }
269
270 size_t smb_get_nt_acl_nfs4(files_struct *fsp,
271         uint32 security_info,
272         SEC_DESC **ppdesc, SMB4ACL_T *acl)
273 {
274         int     good_aces = 0;
275         SMB_STRUCT_STAT sbuf;
276         DOM_SID sid_owner, sid_group;
277         size_t sd_size = 0;
278         SEC_ACE *nt_ace_list = NULL;
279         SEC_ACL *psa = NULL;
280         TALLOC_CTX *mem_ctx = main_loop_talloc_get();
281
282         DEBUG(10, ("smb_get_nt_acl_nfs4 invoked for %s\n", fsp->fsp_name));
283
284         if (acl==NULL || smb_get_naces(acl)==0)
285                 return 0; /* special because we shouldn't alloc 0 for win */
286
287         if (smbacl4_GetFileOwner(fsp, &sbuf))
288                 return 0;
289
290         uid_to_sid(&sid_owner, sbuf.st_uid);
291         gid_to_sid(&sid_group, sbuf.st_gid);
292
293         if (smbacl4_nfs42win(acl,
294                 &sid_owner,
295                 &sid_group,
296                 &nt_ace_list,
297                 &good_aces
298                 )==False) {
299                 DEBUG(8,("smbacl4_nfs42win failed\n"));
300                 return 0;
301         }
302
303         psa = make_sec_acl(mem_ctx, NT4_ACL_REVISION,
304                 good_aces, nt_ace_list);
305         if (psa == NULL) {
306                 DEBUG(2,("make_sec_acl failed\n"));
307                 return 0;
308         }
309
310         DEBUG(10,("after make sec_acl\n"));
311         *ppdesc = make_sec_desc(mem_ctx, SEC_DESC_REVISION,
312                 SEC_DESC_SELF_RELATIVE,
313                 (security_info & OWNER_SECURITY_INFORMATION)
314                 ? &sid_owner : NULL,
315                 (security_info & GROUP_SECURITY_INFORMATION)
316                 ? &sid_group : NULL,
317                 NULL, psa, &sd_size);
318         if (*ppdesc==NULL) {
319                 DEBUG(2,("make_sec_desc failed\n"));
320                 return 0;
321         }
322
323         DEBUG(10, ("smb_get_nt_acl_nfs4 successfully exited with sd_size %d\n", sd_size));
324         return sd_size;
325 }
326
327 enum smbacl4_mode_enum {e_simple=0, e_special=1};
328 enum smbacl4_acedup_enum {e_dontcare=0, e_reject=1, e_ignore=2, e_merge=3};
329
330 typedef struct _smbacl4_vfs_params {
331         enum smbacl4_mode_enum mode;
332         BOOL do_chown;
333         enum smbacl4_acedup_enum acedup;
334 } smbacl4_vfs_params;
335
336 /*
337  * Gather special parameters for NFS4 ACL handling
338  */
339 static int smbacl4_get_vfs_params(
340         const char *type_name,
341         files_struct *fsp,
342         smbacl4_vfs_params *params
343 )
344 {
345         static const struct enum_list enum_smbacl4_modes[] = {
346                 { e_simple, "simple" },
347                 { e_special, "special" }
348         };
349         static const struct enum_list enum_smbacl4_acedups[] = {
350                 { e_dontcare, "dontcare" },
351                 { e_reject, "reject" },
352                 { e_ignore, "ignore" },
353                 { e_merge, "merge" },
354         };
355
356         memset(params, 0, sizeof(smbacl4_vfs_params));
357         params->mode = (enum smbacl4_mode_enum)lp_parm_enum(
358                 SNUM(fsp->conn), type_name,
359                 "mode", enum_smbacl4_modes, e_simple);
360         params->do_chown = lp_parm_bool(SNUM(fsp->conn), type_name,
361                 "chown", True);
362         params->acedup = (enum smbacl4_acedup_enum)lp_parm_enum(
363                 SNUM(fsp->conn), type_name,
364                 "acedup", enum_smbacl4_acedups, e_dontcare);
365
366         DEBUG(10, ("mode:%s, do_chown:%s, acedup: %s\n",
367                 enum_smbacl4_modes[params->mode].name,
368                 params->do_chown ? "true" : "false",
369                 enum_smbacl4_acedups[params->acedup].name));
370
371         return 0;
372 }
373
374 static void smbacl4_dump_nfs4acl(int level, SMB4ACL_T *acl)
375 {
376         SMB_ACL4_INT_T *aclint = get_validated_aclint(acl);
377         SMB_ACE4_INT_T *aceint;
378
379         DEBUG(level, ("NFS4ACL: size=%d\n", aclint->naces));
380
381         for(aceint = aclint->first; aceint!=NULL; aceint=(SMB_ACE4_INT_T *)aceint->next) {
382                 SMB_ACE4PROP_T *ace = &aceint->prop;
383
384                 DEBUG(level, ("\tACE: type=%d, flags=0x%x, fflags=0x%x, mask=0x%x, id=%d\n",
385                         ace->aceType,
386                         ace->aceFlags, ace->flags,
387                         ace->aceMask,
388                         ace->who.id));
389         }
390 }
391
392 /* 
393  * Find 2 NFS4 who-special ACE property (non-copy!!!)
394  * match nonzero if "special" and who is equal
395  * return ace if found matching; otherwise NULL
396  */
397 static SMB_ACE4PROP_T *smbacl4_find_equal_special(
398         SMB4ACL_T *acl,
399         SMB_ACE4PROP_T *aceNew)
400 {
401         SMB_ACL4_INT_T *aclint = get_validated_aclint(acl);
402         SMB_ACE4_INT_T *aceint;
403
404         for(aceint = aclint->first; aceint!=NULL; aceint=(SMB_ACE4_INT_T *)aceint->next) {
405                 SMB_ACE4PROP_T *ace = &aceint->prop;
406
407                 if (ace->flags == aceNew->flags &&
408                         ace->aceType==aceNew->aceType &&
409                         (ace->aceFlags&SMB_ACE4_IDENTIFIER_GROUP)==
410                         (aceNew->aceFlags&SMB_ACE4_IDENTIFIER_GROUP)
411                 ) {
412                         /* keep type safety; e.g. gid is an u.short */
413                         if (ace->flags & SMB_ACE4_ID_SPECIAL)
414                         {
415                                 if (ace->who.special_id==aceNew->who.special_id)
416                                         return ace;
417                         } else {
418                                 if (ace->aceFlags & SMB_ACE4_IDENTIFIER_GROUP)
419                                 {
420                                         if (ace->who.gid==aceNew->who.gid)
421                                                 return ace;
422                                 } else {
423                                         if (ace->who.uid==aceNew->who.uid)
424                                                 return ace;
425                                 }
426                         }
427                 }
428         }
429
430         return NULL;
431 }
432
433 static int smbacl4_fill_ace4(
434         TALLOC_CTX *mem_ctx,
435         smbacl4_vfs_params *params,
436         uid_t ownerUID,
437         gid_t ownerGID,
438         SEC_ACE *ace_nt, /* input */
439         SMB_ACE4PROP_T *ace_v4 /* output */
440 )
441 {
442         const char *dom, *name;
443         enum lsa_SidType type;
444         uid_t uid;
445         gid_t gid;
446
447         DEBUG(10, ("got ace for %s\n",
448                 sid_string_static(&ace_nt->trustee)));
449
450         memset(ace_v4, 0, sizeof(SMB_ACE4PROP_T));
451         ace_v4->aceType = ace_nt->type; /* only ACCES|DENY supported right now */
452         ace_v4->aceFlags = ace_nt->flags & SEC_ACE_FLAG_VALID_INHERIT;
453         ace_v4->aceMask = ace_nt->access_mask &
454                 (STD_RIGHT_ALL_ACCESS | SA_RIGHT_FILE_ALL_ACCESS);
455
456         if (ace_v4->aceFlags!=ace_nt->flags)
457                 DEBUG(9, ("ace_v4->aceFlags(0x%x)!=ace_nt->flags(0x%x)\n",
458                         ace_v4->aceFlags, ace_nt->flags));
459
460         if (ace_v4->aceMask!=ace_nt->access_mask)
461                 DEBUG(9, ("ace_v4->aceMask(0x%x)!=ace_nt->access_mask(0x%x)\n",
462                         ace_v4->aceMask, ace_nt->access_mask));
463
464         if (sid_equal(&ace_nt->trustee, &global_sid_World)) {
465                 ace_v4->who.special_id = SMB_ACE4_WHO_EVERYONE;
466                 ace_v4->flags |= SMB_ACE4_ID_SPECIAL;
467         } else {
468                 if (!lookup_sid(mem_ctx, &ace_nt->trustee, &dom, &name, &type)) {
469                         DEBUG(8, ("Could not find %s' type\n",
470                                 sid_string_static(&ace_nt->trustee)));
471                         errno = EINVAL;
472                         return -1;
473                 }
474
475                 if (type == SID_NAME_USER) {
476                         if (!sid_to_uid(&ace_nt->trustee, &uid)) {
477                                 DEBUG(2, ("Could not convert %s to uid\n",
478                                         sid_string_static(&ace_nt->trustee)));
479                                 return -1;
480                         }
481
482                         if (params->mode==e_special && uid==ownerUID) {
483                                 ace_v4->flags |= SMB_ACE4_ID_SPECIAL;
484                                 ace_v4->who.special_id = SMB_ACE4_WHO_OWNER;
485                         } else {
486                                 ace_v4->who.uid = uid;
487                         }
488                 } else { /* else group? - TODO check it... */
489                         if (!sid_to_gid(&ace_nt->trustee, &gid)) {
490                                 DEBUG(2, ("Could not convert %s to gid\n",
491                                         sid_string_static(&ace_nt->trustee)));
492                                 return -1;
493                         }
494                         ace_v4->aceFlags |= SMB_ACE4_IDENTIFIER_GROUP;
495
496                         if (params->mode==e_special && gid==ownerGID) {
497                                 ace_v4->flags |= SMB_ACE4_ID_SPECIAL;
498                                 ace_v4->who.special_id = SMB_ACE4_WHO_GROUP;
499                         } else {
500                                 ace_v4->who.gid = gid;
501                         }
502                 }
503         }
504
505         return 0; /* OK */
506 }
507
508 static int smbacl4_MergeIgnoreReject(
509         enum smbacl4_acedup_enum acedup,
510         SMB4ACL_T *acl, /* may modify it */
511         SMB_ACE4PROP_T *ace, /* the "new" ACE */
512         BOOL    *paddNewACE,
513         int     i
514 )
515 {
516         int     result = 0;
517         SMB_ACE4PROP_T *ace4found = smbacl4_find_equal_special(acl, ace);
518         if (ace4found)
519         {
520                 switch(acedup)
521                 {
522                 case e_merge: /* "merge" flags */
523                         *paddNewACE = False;
524                         ace4found->aceFlags |= ace->aceFlags;
525                         ace4found->aceMask |= ace->aceMask;
526                         break;
527                 case e_ignore: /* leave out this record */
528                         *paddNewACE = False;
529                         break;
530                 case e_reject: /* do an error */
531                         DEBUG(8, ("ACL rejected by duplicate nt ace#%d\n", i));
532                         errno = EINVAL; /* SHOULD be set on any _real_ error */
533                         result = -1;
534                         break;
535                 default:
536                         break;
537                 }
538         }
539         return result;
540 }
541
542 static SMB4ACL_T *smbacl4_win2nfs4(
543         SEC_ACL *dacl,
544         smbacl4_vfs_params *pparams,
545         uid_t ownerUID,
546         gid_t ownerGID
547 )
548 {
549         SMB4ACL_T *acl;
550         uint32  i;
551         TALLOC_CTX *mem_ctx = main_loop_talloc_get();
552
553         DEBUG(10, ("smbacl4_win2nfs4 invoked\n"));
554
555         acl = smb_create_smb4acl();
556         if (acl==NULL)
557                 return NULL;
558
559         for(i=0; i<dacl->num_aces; i++) {
560                 SMB_ACE4PROP_T  ace_v4;
561                 BOOL    addNewACE = True;
562
563                 if (smbacl4_fill_ace4(mem_ctx, pparams, ownerUID, ownerGID,
564                         dacl->aces + i, &ace_v4))
565                         return NULL;
566
567                 if (pparams->acedup!=e_dontcare) {
568                         if (smbacl4_MergeIgnoreReject(pparams->acedup, acl,
569                                 &ace_v4, &addNewACE, i))
570                                 return NULL;
571                 }
572
573                 if (addNewACE)
574                         smb_add_ace4(acl, &ace_v4);
575         }
576
577         return acl;
578 }
579
580 BOOL smb_set_nt_acl_nfs4(files_struct *fsp,
581         uint32 security_info_sent,
582         SEC_DESC *psd,
583         set_nfs4acl_native_fn_t set_nfs4_native)
584 {
585         smbacl4_vfs_params params;
586         SMB4ACL_T *acl = NULL;
587         BOOL    result;
588
589         SMB_STRUCT_STAT sbuf;
590         BOOL set_acl_as_root = False;
591         uid_t newUID = (uid_t)-1;
592         gid_t newGID = (gid_t)-1;
593         int saved_errno;
594
595         DEBUG(10, ("smb_set_nt_acl_nfs4 invoked for %s\n", fsp->fsp_name));
596
597         if ((security_info_sent & (DACL_SECURITY_INFORMATION |
598                 GROUP_SECURITY_INFORMATION | OWNER_SECURITY_INFORMATION)) == 0)
599         {
600                 DEBUG(9, ("security_info_sent (0x%x) ignored\n",
601                         security_info_sent));
602                 return True; /* won't show error - later to be refined... */
603         }
604
605         /* Special behaviours */
606         if (smbacl4_get_vfs_params(SMBACL4_PARAM_TYPE_NAME, fsp, &params))
607                 return False;
608
609         if (smbacl4_GetFileOwner(fsp, &sbuf))
610                 return False;
611
612         if (params.do_chown) {
613                 /* chown logic is a copy/paste from posix_acl.c:set_nt_acl */
614                 if (!unpack_nt_owners(SNUM(fsp->conn), &newUID, &newGID, security_info_sent, psd))
615                 {
616                         DEBUG(8, ("unpack_nt_owners failed"));
617                         return False;
618                 }
619                 if (((newUID != (uid_t)-1) && (sbuf.st_uid != newUID)) ||
620                         ((newGID != (gid_t)-1) && (sbuf.st_gid != newGID))) {
621                         if(try_chown(fsp->conn, fsp->fsp_name, newUID, newGID)) {
622                                 DEBUG(3,("chown %s, %u, %u failed. Error = %s.\n",
623                                         fsp->fsp_name, (unsigned int)newUID, (unsigned int)newGID, strerror(errno) ));
624                                 return False;
625                         }
626                         DEBUG(10,("chown %s, %u, %u succeeded.\n",
627                                 fsp->fsp_name, (unsigned int)newUID, (unsigned int)newGID));
628                         if (smbacl4_GetFileOwner(fsp, &sbuf))
629                                 return False;
630                         /* If we successfully chowned, we know we must
631                          * be able to set the acl, so do it as root.
632                          */
633                         set_acl_as_root = True;
634                 }
635         }
636
637         if (!(security_info_sent & DACL_SECURITY_INFORMATION) || psd->dacl ==NULL) {
638                 DEBUG(10, ("no dacl found; security_info_sent = 0x%x\n", security_info_sent));
639                 return True;
640         }
641         acl = smbacl4_win2nfs4(psd->dacl, &params, sbuf.st_uid, sbuf.st_gid);
642         if (!acl)
643                 return False;
644
645         smbacl4_dump_nfs4acl(10, acl);
646
647         if (set_acl_as_root) {
648                 become_root();
649         }
650         result = set_nfs4_native(fsp, acl);
651         saved_errno = errno;
652         if (set_acl_as_root) {
653                 unbecome_root();
654         }
655         if (result!=True) {
656                 errno = saved_errno;
657                 DEBUG(10, ("set_nfs4_native failed with %s\n", strerror(errno)));
658                 return False;
659         }
660
661         DEBUG(10, ("smb_set_nt_acl_nfs4 succeeded\n"));
662         return True;
663 }