r14408: More on fix for coverity #36. The previous fix would cause us to
authorJim McDonough <jmcd@samba.org>
Wed, 15 Mar 2006 02:31:11 +0000 (02:31 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:15:29 +0000 (11:15 -0500)
marshall a buffer based on an unknown size.  Zero out the sec_desc
buffer to prevent this.  This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28ce361628df137c9aef02739aca062db)

source3/libmsrpc/cac_winreg.c

index aa847602cc32d8d115ceabaaca5b039dbb2e6b4d..acd83f40760ded09bec8980497026149a6c49766 100644 (file)
@@ -831,6 +831,8 @@ int cac_RegGetKeySecurity(CacServerHandle *hnd, TALLOC_CTX *mem_ctx, struct RegG
    uint32 buf_size;
    SEC_DESC_BUF buf;
 
+   ZERO_STRUCT(buf);
+
    if(!hnd) 
       return CAC_FAILURE;