Fix a valgrind error in _samr_DeleteUser
authorVolker Lendecke <vl@samba.org>
Sun, 26 Jul 2009 13:38:10 +0000 (15:38 +0200)
committerVolker Lendecke <vl@samba.org>
Sun, 26 Jul 2009 13:47:31 +0000 (15:47 +0200)
The close_handle invalidates uinfo

source3/rpc_server/srv_samr_nt.c

index b27603f261590921da446f3f2f0f64b32b91f2d0..2dcf360daf7f9960bb57a628bfef043ab711f019 100644 (file)
@@ -5694,13 +5694,13 @@ NTSTATUS _samr_DeleteUser(pipes_struct *p,
 
        TALLOC_FREE(sam_pass);
 
+       force_flush_samr_cache(&uinfo->sid);
+
        if (!close_policy_hnd(p, r->in.user_handle))
                return NT_STATUS_OBJECT_NAME_INVALID;
 
        ZERO_STRUCTP(r->out.user_handle);
 
-       force_flush_samr_cache(&uinfo->sid);
-
        return NT_STATUS_OK;
 }