TODO: talloc: talloc_free() should remove the reference to the current owner

The parent of the first reference becomes the owner...

metze

diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index 4c00b23aaf899940882df0e64a7ad4cd7d6f3c2b..7e48cf1bbf1246404f0033eaae26b06039795bf6 100644 (file)
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -1103,9 +1103,13 @@ static inline int _tc_free_internal(struct talloc_chunk *tc,
                 * pointer.
                 */
                is_child = talloc_is_parent(tc->refs, ptr);
-               _talloc_free_internal(tc->refs, location);
                if (is_child) {
+                       _talloc_free_internal(tc->refs, location);
                        return _talloc_free_internal(ptr, location);
+               } else {
+                       /* the first reference becomes the owner */
+                       _talloc_steal(talloc_parent(tc->refs), ptr);
+                       _talloc_free_internal(tc->refs, location);
                }
                return -1;
        }