ctdb-common: Avoid using void ** argument
authorAmitay Isaacs <amitay@gmail.com>
Thu, 9 Nov 2017 05:37:15 +0000 (16:37 +1100)
committerMartin Schwenke <martins@samba.org>
Wed, 13 Dec 2017 07:48:18 +0000 (08:48 +0100)
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
ctdb/common/sock_client.c
ctdb/common/sock_client.h

index e5f993e085ca83c192cf2339d566b6b84a0e7c27..ced705042a40cb4dcebe34e9102eb3fb84b18b3c 100644 (file)
@@ -311,7 +311,7 @@ static void sock_client_msg_reply(struct sock_client_context *sockc,
 }
 
 bool sock_client_msg_recv(struct tevent_req *req, int *perr,
-                         TALLOC_CTX *mem_ctx, void **reply)
+                         TALLOC_CTX *mem_ctx, void *reply)
 {
        struct sock_client_msg_state *state = tevent_req_data(
                req, struct sock_client_msg_state);
@@ -325,7 +325,7 @@ bool sock_client_msg_recv(struct tevent_req *req, int *perr,
        }
 
        if (reply != NULL) {
-               *reply = talloc_steal(mem_ctx, state->reply);
+               *(void **)reply = talloc_steal(mem_ctx, state->reply);
        }
 
        return true;
index c640767c3a72100e85e48bbac96b64de3edc5512..c5822a0ac0140843ed15640013b866e216f61549 100644 (file)
@@ -124,6 +124,6 @@ struct tevent_req *sock_client_msg_send(TALLOC_CTX *mem_ctx,
  * @return true on success, false on failure
  */
 bool sock_client_msg_recv(struct tevent_req *req, int *perr,
-                         TALLOC_CTX *mem_ctx, void **reply);
+                         TALLOC_CTX *mem_ctx, void *reply);
 
 #endif /* __CTDB_SOCK_CLIENT_H__ */