s4:samdb_server_site_dn - free unused DNs in the right way
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Sun, 11 Apr 2010 10:56:50 +0000 (12:56 +0200)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Sun, 11 Apr 2010 11:20:44 +0000 (13:20 +0200)
source4/dsdb/common/util.c

index b469b062326e02b076d3b57aba169fe8dc2fbd31..c6870da234b2cbe449beebed1032ce5aad7de317 100644 (file)
@@ -1469,16 +1469,16 @@ struct ldb_dn *samdb_server_site_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx
        struct ldb_dn *server_site_dn;
 
        /* TODO: there must be a saner way to do this!! */
-
        server_dn = samdb_server_dn(ldb, mem_ctx);
        if (!server_dn) return NULL;
 
        servers_dn = ldb_dn_get_parent(mem_ctx, server_dn);
+       talloc_free(server_dn);
        if (!servers_dn) return NULL;
 
        server_site_dn = ldb_dn_get_parent(mem_ctx, servers_dn);
+       talloc_free(servers_dn);
 
-       talloc_free(server_dn);
        return server_site_dn;
 }