s3/lib: clang: Fix 'Value stored to 'b' is never read'

Fixes:

source3/lib/substitute.c:516:7: warning: Value stored to 'b' is never read <--[clang]
        for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
             ^   ~~~~~~~~~~~~
source3/lib/substitute.c:709:7: warning: Value stored to 'b' is never read <--[clang]
        for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
             ^   ~~~~~~~~~~~~
source3/lib/substitute.c:811:7: warning: Value stored to 'b' is never read <--[clang]
        for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
             ^   ~~~~~~~~~~~~
3 warnings generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source3/lib/substitute.c b/source3/lib/substitute.c
index ea227c5ab68d3d4c5f9cdbb7608b6e0e0944c8e8..f8ca6f41cc1aa42b4a5e67d811ef09575c4b632b 100644 (file)
--- a/source3/lib/substitute.c
+++ b/source3/lib/substitute.c
@@ -513,7 +513,7 @@ char *talloc_sub_basic(TALLOC_CTX *mem_ctx,
 
        tmp_ctx = talloc_stackframe();
 
-       for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
+       for (s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
 
                r = NULL;
                b = a_string;
@@ -706,7 +706,7 @@ char *talloc_sub_specified(TALLOC_CTX *mem_ctx,
                goto done;
        }
 
-       for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
+       for (s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
 
                b = a_string;
 
@@ -808,7 +808,7 @@ char *talloc_sub_advanced(TALLOC_CTX *ctx,
                return NULL;
        }
 
-       for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
+       for (s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
 
                b = a_string;