s4-kdc: Do not leak memory on error in kpasswd_make_error_reply()

CID 1372874

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 13 22:13:31 CEST 2016 on sn-devel-144

diff --git a/source4/kdc/kpasswd-helper.c b/source4/kdc/kpasswd-helper.c
index 996b318bd4015fa4a1f9c711ff2f104bb07e595b..6de28375cba0aada986aa06a547b9bb3279cbcc9 100644 (file)
--- a/source4/kdc/kpasswd-helper.c
+++ b/source4/kdc/kpasswd-helper.c
@@ -54,11 +54,13 @@ bool kpasswd_make_error_reply(TALLOC_CTX *mem_ctx,
         */
 #ifndef SAMBA4_USES_HEIMDAL
        if (slen < 2) {
+               talloc_free(s);
                return false;
        }
        slen -= 2;
 #endif
        if (2 + slen < slen) {
+               talloc_free(s);
                return false;
        }
        error_data->length = 2 + slen;