s4-dsdb/netlogon: allow missing ntver in cldap ping

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11392

Signed-off-by: Arvid Requate <requate@univention.de>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/knownfail.d/huawei b/selftest/knownfail.d/huawei
deleted file mode 100644 (file)
index cbeaf68..0000000
--- a/selftest/knownfail.d/huawei
+++ /dev/null
@@ -1 +0,0 @@
-samba4.ldap.netlogon-udp.netlogon-udp\(ad_dc_ntvfs\)

diff --git a/source4/dsdb/samdb/ldb_modules/netlogon.c b/source4/dsdb/samdb/ldb_modules/netlogon.c
index c5f194dc4dc7f50cb041ceb0f1e58d45369b33e4..f7ba2ac041cc519bce77228e3409dee74d18f996 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/netlogon.c
+++ b/source4/dsdb/samdb/ldb_modules/netlogon.c
@@ -425,7 +425,7 @@ NTSTATUS parse_netlogon_request(struct ldb_parse_tree *tree,
        *domain_guid = NULL;
        *domain_sid = NULL;
        *acct_control = -1;
-       *version = -1;
+       *version = 0;
 
        if (tree->operation != LDB_OP_AND) goto failed;
 
@@ -486,10 +486,6 @@ NTSTATUS parse_netlogon_request(struct ldb_parse_tree *tree,
                *domain = lpcfg_dnsdomain(lp_ctx);
        }
 
-       if (*version == -1) {
-               goto failed;
-       }
-
        return NT_STATUS_OK;
 
 failed: