s4-dsdb: use dn_format shortcut to find DN format
authorAndrew Tridgell <tridge@samba.org>
Fri, 5 Aug 2011 01:28:12 +0000 (11:28 +1000)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 9 Aug 2011 09:56:23 +0000 (11:56 +0200)
this saves some string comparisons

source4/dsdb/samdb/ldb_modules/extended_dn_out.c
source4/dsdb/samdb/ldb_modules/extended_dn_store.c

index 3333a376441b50d6b1c902d29681ca322090cbff..0f37bbebd434ad7e1262cf2e576960962296d481 100644 (file)
@@ -76,7 +76,7 @@ static int extended_dn_out_dereference_setup_control(struct ldb_context *ldb, st
        }
 
        for (cur = schema->attributes; cur; cur = cur->next) {
-               if (dsdb_dn_oid_to_format(cur->syntax->ldap_oid) != DSDB_NORMAL_DN) {
+               if (cur->dn_format != DSDB_NORMAL_DN) {
                        continue;
                }
                dereference_control->dereference
@@ -508,7 +508,7 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares,
                }
 
                /* Look to see if this attributeSyntax is a DN */
-               if (dsdb_dn_oid_to_format(attribute->syntax->ldap_oid) == DSDB_INVALID_DN) {
+               if (attribute->dn_format == DSDB_INVALID_DN) {
                        continue;
                }
 
index c4235201d9bb0d5b2de046cfd28959b25a6ddb1e..57dc88330d61f0a5e744f04ba12f6ec1b9a9cdc2 100644 (file)
@@ -325,7 +325,7 @@ static int extended_dn_add(struct ldb_module *module, struct ldb_request *req)
                }
 
                /* We only setup an extended DN GUID on DN elements */
-               if (dsdb_dn_oid_to_format(schema_attr->syntax->ldap_oid) == DSDB_INVALID_DN) {
+               if (schema_attr->dn_format == DSDB_INVALID_DN) {
                        continue;
                }
 
@@ -400,7 +400,7 @@ static int extended_dn_modify(struct ldb_module *module, struct ldb_request *req
                }
 
                /* We only setup an extended DN GUID on these particular DN objects */
-               if (dsdb_dn_oid_to_format(schema_attr->syntax->ldap_oid) == DSDB_INVALID_DN) {
+               if (schema_attr->dn_format == DSDB_INVALID_DN) {
                        continue;
                }