Fix bug #5713 by correcting the generated schema.
authorAndrew Bartlett <abartlet@samba.org>
Tue, 9 Sep 2008 06:18:27 +0000 (16:18 +1000)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 9 Sep 2008 06:21:22 +0000 (16:21 +1000)
This bug is entitled 'Schema patch breaks interoperability with
Microsoft MMC consoles.', and it does so very spectacularly.

The issue is that we would include an entry:
objectClasses: ( 2.5.6.0 NAME 'top' SUP top ABSTRACT..

The MMC Active Directory Users and Computers snap in presumably
objected to the 'loop' this would present. The fixed entry is:

objectClasses: ( 2.5.6.0 NAME 'top' ABSTRACT

Thanks to Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> for his
persistance in getting me to look at this.

Andrew Bartlett

source/dsdb/schema/schema_description.c

index 9d93af9260a87ccfbfe5b4bb0257441cec35fe62..d780fcf34f864bec9dd3b6004b05079f2f68cef1 100644 (file)
@@ -182,7 +182,7 @@ char *schema_class_description(TALLOC_CTX *mem_ctx,
                IF_NULL_FAIL_RET(schema_entry);
        }
 
-       if (subClassOf) {
+       if (subClassOf && strcasecmp(subClassOf, name) == 0) {
                schema_entry = talloc_asprintf_append(schema_entry, 
                                                      "SUP %s%s", subClassOf, seperator);
                IF_NULL_FAIL_RET(schema_entry);