A fix in the ACL code used by both SAMBA 3 and 4
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Thu, 18 Jun 2009 09:18:05 +0000 (11:18 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 19 Jun 2009 01:32:01 +0000 (11:32 +1000)
This fixes an uninitialised structure. It has been found through valgrind
in the RAW-ACLs test suite (Bug #6397).

libcli/security/security_descriptor.c

index 59d82b821e225d5b3a8097f3e79f544326c070a5..f18a326e9973d6a09e3bc93c1ae7ec76157a3633 100644 (file)
@@ -373,7 +373,7 @@ static struct security_descriptor *security_descriptor_appendv(struct security_d
 
        while ((sidstr = va_arg(ap, const char *))) {
                struct dom_sid *sid;
-               struct security_ace *ace = talloc(sd, struct security_ace);
+               struct security_ace *ace = talloc_zero(sd, struct security_ace);
                NTSTATUS status;
 
                if (ace == NULL) {