selftest: apply NSS_WRAPPER_HOSTNAME to child processes
authorJamie McClymont <jamiemcclymont@catalyst.net.nz>
Fri, 8 Dec 2017 01:47:09 +0000 (14:47 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 20 Dec 2017 03:22:10 +0000 (04:22 +0100)
Currently, Samba3.pm returns a value for NSS_WRAPPER_HOSTNAME in provision, but
selftest.pl does not apply it, so Samba3.pm /also/ sets it in its own
environment. This breaks a command like this:

make test TESTS="samba3.blackbox.smbclient_ntlm.plain samba3.rpc.samba3.netlogon"

... since samba3.blackbox.smbclient_ntlm.plain runs in an nt4_member env,
thereby setting ENV{NSS_WRAPPER_HOSTNAME} to the value for a member, and
samba3.rpc.samba3.netlogon depended on NSS_WRAPPER_HOSTNAME as a username (until
previous commit).

Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
selftest/selftest.pl

index 8c41459e1e684419b43ccb7c5a368fa3c76c5303..2316f9f58806f5a0d83315f113865aa0bab4e7a7 100755 (executable)
@@ -883,6 +883,7 @@ my @exported_envvars = (
        "NSS_WRAPPER_PASSWD",
        "NSS_WRAPPER_GROUP",
        "NSS_WRAPPER_HOSTS",
+       "NSS_WRAPPER_HOSTNAME",
        "NSS_WRAPPER_MODULE_SO_PATH",
        "NSS_WRAPPER_MODULE_FN_PREFIX",