s4-upgradeprovision: Fix an error, so that cursddl and refsddl are not the same
authorMatthieu Patou <mat@matws.net>
Sun, 5 Jun 2011 13:26:07 +0000 (17:26 +0400)
committerMatthieu Patou <mat@samba.org>
Sun, 19 Jun 2011 21:21:07 +0000 (23:21 +0200)
Thanks to Dirk Paulli for pointing it with his bug report.

source4/scripting/bin/upgradeprovision

index e58a2647b63477f20856763612f18d61437b56aa..9d3b6839409c7df5ad7cf6580a05525682e2f290 100755 (executable)
@@ -905,7 +905,7 @@ def update_present(ref_samdb, samdb, basedn, listPresent, usns, invocationid):
                     cursddl = cursd.as_sddl(names.domainsid)
                     refsd = ndr_unpack(security.descriptor,
                         str(reference[0]["nTSecurityDescriptor"]))
-                    refsddl = cursd.as_sddl(names.domainsid)
+                    refsddl = refsd.as_sddl(names.domainsid)
 
                     if get_diff_sddls(refsddl, cursddl) == "":
                        message(CHANGE, "sd are identical")