r14155: Fix coverity #115: free storage alloc'ed by sstring_sub()

(This used to be commit a197b8c5cb02c8a5fac3882e7b76bcd7abb0279c)

diff --git a/source3/utils/net_rpc_samsync.c b/source3/utils/net_rpc_samsync.c
index a171782c488c5de852cdd26228b22bd20b551744..691e28af8eb0adc722842765a6a79937999abfb0 100644 (file)
--- a/source3/utils/net_rpc_samsync.c
+++ b/source3/utils/net_rpc_samsync.c
@@ -1636,6 +1636,7 @@ static NTSTATUS fetch_alias_info_to_ldif(SAM_DELTA_CTR *delta, GROUPMAP *groupma
            strcmp(aliasname, "Print Operators") == 0 ||
            strcmp(aliasname, "Backup Operators") == 0 ||
            strcmp(aliasname, "Replicator") == 0) {
+               SAFE_FREE(group_attr);
                return NT_STATUS_OK;
        } else {
                /* Increment the gid for the new group */
@@ -1663,6 +1664,7 @@ static NTSTATUS fetch_alias_info_to_ldif(SAM_DELTA_CTR *delta, GROUPMAP *groupma
        fprintf(add_fd, "\n");
        fflush(add_fd);
 
+       SAFE_FREE(group_attr);
        /* Return */
        return NT_STATUS_OK;
 }