tests: Completely replace s4 connection in smb tests
authorTim Beale <timbeale@catalyst.net.nz>
Wed, 12 Dec 2018 01:42:30 +0000 (14:42 +1300)
committerTim Beale <timbeale@samba.org>
Mon, 7 Jan 2019 00:23:08 +0000 (01:23 +0100)
This test now uses the s3 python bindings completely, so we can remove
the s4 connection.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/smb.py

index df3edd0400469acd6493c0d974605aa8b467cd8e..98e669c5f8c822f32cbbbbf3d1d2df2714c35b05 100644 (file)
@@ -42,12 +42,8 @@ class SMBTests(samba.tests.TestCase):
         super(SMBTests, self).setUp()
         self.server = os.environ["SERVER"]
         creds = self.insta_creds(template=self.get_credentials())
-        self.conn = smb.SMB(self.server,
-                            "sysvol",
-                            lp=self.get_loadparm(),
-                            creds=creds)
 
-        # temporarily create a 2nd SMB connection for migrating the py-bindings
+        # create an SMB connection to the server
         lp = s3param.get_context()
         lp.load(os.getenv("SMB_CONF_PATH"))
         self.smb_conn = libsmb_samba_internal.Conn(self.server, "sysvol",