REVIEW: pidl/Python: make use of pyrpc_string_array_{from,to}_PyList()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
TODO: Reviewed-by: Arvid Requate <requate@univention.de>

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index 032ddf74984e5f24eb2a6b254b3bcc65fd475d6b..7f5fd20dbda81cc04345611608b9f6e64530758d 100644 (file)
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -1812,7 +1812,8 @@ sub ConvertObjectFromPythonData($$$$$$;$$)
        }
 
        if ($actual_ctype->{TYPE} eq "SCALAR" and $actual_ctype->{NAME} eq "string_array") {
-               $self->pidl("$target = pytalloc_get_ptr($cvar);");
+               $self->pidl("$target = pyrpc_string_array_from_PyList($mem_ctx, $cvar, \"$target\");");
+               $self->fail_on_null($target, $fail);
                return;
        }
 
@@ -2024,9 +2025,8 @@ sub ConvertScalarToPython($$$$)
                return "PyString_FromStringOrNULL($cvar)";
        }
 
-       # Not yet supported
        if ($ctypename eq "string_array") {
-               return "pytalloc_GenericObject_reference_ex($mem_ctx, $cvar)";
+               return "pyrpc_string_array_to_PyList($cvar, \"$cvar\")";
        }
        if ($ctypename eq "ipv4address") { return "PyString_FromStringOrNULL($cvar)"; }
        if ($ctypename eq "ipv6address") { return "PyString_FromStringOrNULL($cvar)"; }