selftest: enable py3 for samba.tests.dcerpc.bare
authorJoe Guo <joeg@catalyst.net.nz>
Tue, 10 Apr 2018 23:39:56 +0000 (11:39 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Fri, 13 Apr 2018 05:27:12 +0000 (07:27 +0200)
Prefix b to bytes.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
python/samba/tests/dcerpc/bare.py
source4/selftest/tests.py

index 270c7af382e3c8d5b3ce31cee419d450fcd41127..380164cff1081da14e4fcde3e3b0f68a8ccf27fa 100644 (file)
@@ -30,7 +30,7 @@ class BareTestCase(samba.tests.TestCase):
         x = ClientConnection("ncalrpc:localhost[DEFAULT]",
                 ("60a15ec5-4de8-11d7-a637-005056a20182", 1),
                 lp_ctx=samba.tests.env_loadparm())
-        self.assertEquals("\x01\x00\x00\x00", x.request(0, chr(0) * 4))
+        self.assertEquals(b"\x01\x00\x00\x00", x.request(0, chr(0) * 4))
 
     def test_two_contexts(self):
         x = ClientConnection("ncalrpc:localhost[DEFAULT]",
@@ -40,14 +40,14 @@ class BareTestCase(samba.tests.TestCase):
                 ("60a15ec5-4de8-11d7-a637-005056a20182", 1),
                 basis_connection=x, lp_ctx=samba.tests.env_loadparm())
         self.assertEquals(24, len(x.request(0, chr(0) * 8)))
-        self.assertEquals("\x01\x00\x00\x00", y.request(0, chr(0) * 4))
+        self.assertEquals(b"\x01\x00\x00\x00", y.request(0, chr(0) * 4))
 
     def test_bare_tcp(self):
         # Connect to the echo pipe
         x = ClientConnection("ncacn_ip_tcp:%s" % os.environ["SERVER"],
                 ("60a15ec5-4de8-11d7-a637-005056a20182", 1),
                 lp_ctx=samba.tests.env_loadparm())
-        self.assertEquals("\x01\x00\x00\x00", x.request(0, chr(0) * 4))
+        self.assertEquals(b"\x01\x00\x00\x00", x.request(0, chr(0) * 4))
 
     def test_two_contexts_tcp(self):
         x = ClientConnection("ncacn_ip_tcp:%s" % os.environ["SERVER"],
@@ -57,4 +57,4 @@ class BareTestCase(samba.tests.TestCase):
                 ("60a15ec5-4de8-11d7-a637-005056a20182", 1),
                 basis_connection=x, lp_ctx=samba.tests.env_loadparm())
         self.assertEquals(24, len(x.request(0, chr(0) * 8)))
-        self.assertEquals("\x01\x00\x00\x00", y.request(0, chr(0) * 4))
+        self.assertEquals(b"\x01\x00\x00\x00", y.request(0, chr(0) * 4))
index 47ff7f24653db6e66441041e6e95c1ce189a047a..95058b1ea2c5211dc43c8ee19f1255ac1e362326 100755 (executable)
@@ -579,7 +579,7 @@ planoldpythontestsuite("none", "simple", extra_path=["%s/lib/tdb/python/tests" %
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.sam", py3_compatible=True)
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dsdb", py3_compatible=True)
 planpythontestsuite("none", "samba.tests.dsdb_lock")
-planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.bare")
+planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.bare", py3_compatible=True)
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.unix")
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.dcerpc.srvsvc")
 planpythontestsuite("ad_dc_ntvfs:local", "samba.tests.samba_tool.timecmd")